mirror of
https://github.com/hanzoai/telemetry.git
synced 2026-10-30 20:01:49 +00:00
Passing multiple positional arguments to the featuregate command is silently accepted and extra arguments are ignored. **Actual behavior** Command succeeds and ignores additional positional arguments. **Expected behavior** Error: accepts at most 1 arg(s), received 2 **Steps to reproduce (from repo root, using the otelcorecol binary as an example):** - cd cmd/otelcorecol - go build -o otelcorecol . - ./otelcorecol featuregate gate1 gate2 This change enforces the documented featuregate [feature-id] contract by rejecting extra positional arguments at the Cobra validation layer, consistent with other otelcol subcommands.
227 lines
6.6 KiB
Go
227 lines
6.6 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package otelcol
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"go.opentelemetry.io/collector/component"
|
|
"go.opentelemetry.io/collector/confmap"
|
|
"go.opentelemetry.io/collector/featuregate"
|
|
)
|
|
|
|
func TestNewCommandVersion(t *testing.T) {
|
|
cmd := NewCommand(CollectorSettings{BuildInfo: component.BuildInfo{Version: "test_version"}})
|
|
assert.Equal(t, "test_version", cmd.Version)
|
|
}
|
|
|
|
func TestNewCommandNoConfigURI(t *testing.T) {
|
|
cmd := NewCommand(CollectorSettings{Factories: nopFactories})
|
|
require.Error(t, cmd.Execute())
|
|
}
|
|
|
|
// This test emulates usage of Collector in Jaeger all-in-one, which
|
|
// allows running the binary with no explicit configuration.
|
|
func TestNewCommandProgrammaticallyPassedConfig(t *testing.T) {
|
|
cmd := NewCommand(CollectorSettings{Factories: nopFactories, ConfigProviderSettings: ConfigProviderSettings{
|
|
ResolverSettings: confmap.ResolverSettings{
|
|
ProviderFactories: []confmap.ProviderFactory{confmap.NewProviderFactory(newFailureProvider)},
|
|
DefaultScheme: "file",
|
|
},
|
|
}})
|
|
otelRunE := cmd.RunE
|
|
cmd.RunE = func(c *cobra.Command, args []string) error {
|
|
configFlag := c.Flag("config")
|
|
cfg := `
|
|
service:
|
|
extensions: [invalid_component_name]
|
|
receivers:
|
|
invalid_component_name:
|
|
`
|
|
require.NoError(t, configFlag.Value.Set("yaml:"+cfg))
|
|
return otelRunE(cmd, args)
|
|
}
|
|
// verify that cmd.Execute was run with the implicitly provided config.
|
|
require.ErrorContains(t, cmd.Execute(), "invalid_component_name")
|
|
}
|
|
|
|
func TestAddFlagToSettings(t *testing.T) {
|
|
filePath := filepath.Join("testdata", "otelcol-invalid.yaml")
|
|
fileProvider := newFakeProvider("file", func(_ context.Context, _ string, _ confmap.WatcherFunc) (*confmap.Retrieved, error) {
|
|
return confmap.NewRetrieved(newConfFromFile(t, filePath))
|
|
})
|
|
set := CollectorSettings{
|
|
ConfigProviderSettings: ConfigProviderSettings{
|
|
ResolverSettings: confmap.ResolverSettings{
|
|
URIs: []string{filePath},
|
|
ProviderFactories: []confmap.ProviderFactory{fileProvider},
|
|
},
|
|
},
|
|
}
|
|
flgs := flags(featuregate.NewRegistry())
|
|
err := flgs.Parse([]string{"--config=otelcol-nop.yaml"})
|
|
require.NoError(t, err)
|
|
|
|
err = updateSettingsUsingFlags(&set, flgs)
|
|
require.NoError(t, err)
|
|
require.Len(t, set.ConfigProviderSettings.ResolverSettings.URIs, 1)
|
|
}
|
|
|
|
func TestInvalidCollectorSettings(t *testing.T) {
|
|
set := CollectorSettings{
|
|
ConfigProviderSettings: ConfigProviderSettings{
|
|
ResolverSettings: confmap.ResolverSettings{
|
|
URIs: []string{"--config=otelcol-nop.yaml"},
|
|
},
|
|
},
|
|
}
|
|
|
|
cmd := NewCommand(set)
|
|
require.Error(t, cmd.Execute())
|
|
}
|
|
|
|
func TestNewCommandInvalidComponent(t *testing.T) {
|
|
filePath := filepath.Join("testdata", "otelcol-invalid.yaml")
|
|
fileProvider := newFakeProvider("file", func(_ context.Context, _ string, _ confmap.WatcherFunc) (*confmap.Retrieved, error) {
|
|
return confmap.NewRetrieved(newConfFromFile(t, filePath))
|
|
})
|
|
set := ConfigProviderSettings{
|
|
ResolverSettings: confmap.ResolverSettings{
|
|
URIs: []string{filePath},
|
|
ProviderFactories: []confmap.ProviderFactory{fileProvider},
|
|
},
|
|
}
|
|
|
|
cmd := NewCommand(CollectorSettings{Factories: nopFactories, ConfigProviderSettings: set})
|
|
require.Error(t, cmd.Execute())
|
|
}
|
|
|
|
func TestNoProvidersReturnsError(t *testing.T) {
|
|
set := CollectorSettings{
|
|
ConfigProviderSettings: ConfigProviderSettings{
|
|
ResolverSettings: confmap.ResolverSettings{
|
|
URIs: []string{filepath.Join("testdata", "otelcol-invalid.yaml")},
|
|
},
|
|
},
|
|
}
|
|
flgs := flags(featuregate.NewRegistry())
|
|
err := flgs.Parse([]string{"--config=otelcol-nop.yaml"})
|
|
require.NoError(t, err)
|
|
|
|
err = updateSettingsUsingFlags(&set, flgs)
|
|
require.ErrorContains(t, err, "at least one Provider must be supplied")
|
|
}
|
|
|
|
func Test_UseUnifiedEnvVarExpansionRules(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
input string
|
|
expected string
|
|
}{
|
|
{
|
|
name: "default scheme set",
|
|
input: "file",
|
|
expected: "file",
|
|
},
|
|
{
|
|
name: "default scheme not set",
|
|
input: "",
|
|
expected: "env",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
fileProvider := newFakeProvider("file", func(_ context.Context, _ string, _ confmap.WatcherFunc) (*confmap.Retrieved, error) {
|
|
return &confmap.Retrieved{}, nil
|
|
})
|
|
set := CollectorSettings{
|
|
ConfigProviderSettings: ConfigProviderSettings{
|
|
ResolverSettings: confmap.ResolverSettings{
|
|
ProviderFactories: []confmap.ProviderFactory{fileProvider},
|
|
DefaultScheme: tt.input,
|
|
},
|
|
},
|
|
}
|
|
flgs := flags(featuregate.NewRegistry())
|
|
err := flgs.Parse([]string{"--config=otelcol-nop.yaml"})
|
|
require.NoError(t, err)
|
|
|
|
err = updateSettingsUsingFlags(&set, flgs)
|
|
require.NoError(t, err)
|
|
require.Equal(t, tt.expected, set.ConfigProviderSettings.ResolverSettings.DefaultScheme)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewFeatureGateCommand(t *testing.T) {
|
|
t.Run("list all featuregates", func(t *testing.T) {
|
|
cmd := newFeatureGateCommand()
|
|
require.NotNil(t, cmd)
|
|
|
|
// Capture stdout
|
|
oldStdout := os.Stdout
|
|
r, w, _ := os.Pipe()
|
|
os.Stdout = w
|
|
|
|
err := cmd.RunE(cmd, []string{})
|
|
require.NoError(t, err)
|
|
|
|
w.Close()
|
|
out, _ := io.ReadAll(r)
|
|
os.Stdout = oldStdout
|
|
|
|
output := string(out)
|
|
assert.Contains(t, output, "ID")
|
|
assert.Contains(t, output, "Enabled")
|
|
assert.Contains(t, output, "Stage")
|
|
assert.Contains(t, output, "Description")
|
|
})
|
|
t.Run("specific featuregate details", func(t *testing.T) {
|
|
cmd := newFeatureGateCommand()
|
|
|
|
// Register a test feature gate in the global registry
|
|
featuregate.GlobalRegistry().MustRegister("test.feature", featuregate.StageBeta,
|
|
featuregate.WithRegisterDescription("Test feature description"))
|
|
|
|
// Capture stdout
|
|
oldStdout := os.Stdout
|
|
r, w, _ := os.Pipe()
|
|
os.Stdout = w
|
|
|
|
err := cmd.RunE(cmd, []string{"test.feature"})
|
|
require.NoError(t, err)
|
|
|
|
w.Close()
|
|
out, _ := io.ReadAll(r)
|
|
os.Stdout = oldStdout
|
|
|
|
output := string(out)
|
|
assert.Contains(t, output, "Feature: test.feature")
|
|
assert.Contains(t, output, "Description: Test feature description")
|
|
assert.Contains(t, output, "Stage: Beta")
|
|
})
|
|
|
|
t.Run("non-existent featuregate", func(t *testing.T) {
|
|
cmd := newFeatureGateCommand()
|
|
err := cmd.RunE(cmd, []string{"non.existent.feature"})
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "feature \"non.existent.feature\" not found")
|
|
})
|
|
|
|
t.Run("rejects multiple arguments", func(t *testing.T) {
|
|
cmd := newFeatureGateCommand()
|
|
cmd.SetArgs([]string{"gate1", "gate2"})
|
|
err := cmd.Execute()
|
|
require.Error(t, err)
|
|
})
|
|
}
|