mirror of
https://github.com/hanzoai/telemetry.git
synced 2026-10-30 20:01:49 +00:00
2d9e97fefd
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Puts all references to the `syscall` package behind build tags, which I believe is generally considered a best practice in Go. In particular, this makes `SIGHUP` and `SIGTERM` no-ops Wasm in JS, which [stubs out `SIGTERM`](https://github.com/golang/go/blob/a59593313d75d9e7c99da0cff0e12555597621ec/src/syscall/syscall_js.go#L101) but not `SIGHUP`, causing build failures. Note that Windows doesn't use Posix process signals, but [Go creates invented Signals](https://github.com/golang/go/blob/d3ddc4854429185e6e06ca1f7628bb790404abb5/src/syscall/types_windows.go#L60) that are used to support this functionality. <!-- Issue number if applicable --> #### Link to tracking issue Works toward #14542. <!--Describe what testing was performed and which tests were added.--> #### Testing The tests now refer to the same build tag-guarded constants, but otherwise don't change, as it's hard to test the absence of functionality. --------- Co-authored-by: Pablo Baeyens <[email protected]>
16 lines
262 B
Go
16 lines
262 B
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
//go:build js && wasm
|
|
|
|
package otelcol // import "go.opentelemetry.io/collector/otelcol"
|
|
|
|
import (
|
|
"syscall"
|
|
)
|
|
|
|
const (
|
|
SIGHUP = syscall.Signal(-1)
|
|
SIGTERM = syscall.Signal(-1)
|
|
)
|