Files
Florian Lehnerandzeekay 9d40d96a8a [pdata/pprofile] fix off-by one Dictionary issue (#14534)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Fix off-by-one issue in dictionary lookups.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

Signed-off-by: Florian Lehner <[email protected]>
2026-02-22 00:54:49 -08:00

249 lines
5.1 KiB
Go

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
package pprofile
import (
"errors"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/internal/testutil"
)
func TestStackEqual(t *testing.T) {
for _, tt := range []struct {
name string
orig Stack
dest Stack
want bool
}{
{
name: "with empty stacks",
orig: NewStack(),
dest: NewStack(),
want: true,
},
{
name: "with non-empty equal stacks",
orig: func() Stack {
s := NewStack()
s.LocationIndices().Append(1)
return s
}(),
dest: func() Stack {
s := NewStack()
s.LocationIndices().Append(1)
return s
}(),
want: true,
},
{
name: "with different location indices lengths",
orig: func() Stack {
s := NewStack()
s.LocationIndices().Append(1)
return s
}(),
dest: NewStack(),
want: false,
},
{
name: "with non-equal location indices",
orig: func() Stack {
s := NewStack()
s.LocationIndices().Append(2)
return s
}(),
dest: func() Stack {
s := NewStack()
s.LocationIndices().Append(1)
return s
}(),
want: false,
},
} {
t.Run(tt.name, func(t *testing.T) {
if tt.want {
assert.True(t, tt.orig.Equal(tt.dest))
} else {
assert.False(t, tt.orig.Equal(tt.dest))
}
})
}
}
func TestStackSwitchDictionary(t *testing.T) {
for _, tt := range []struct {
name string
stack Stack
src ProfilesDictionary
dst ProfilesDictionary
wantStack Stack
wantDictionary ProfilesDictionary
wantErr error
}{
{
name: "with an empty stack",
stack: NewStack(),
src: NewProfilesDictionary(),
dst: NewProfilesDictionary(),
wantStack: NewStack(),
wantDictionary: NewProfilesDictionary(),
},
{
name: "with an existing location",
stack: func() Stack {
s := NewStack()
s.LocationIndices().Append(0)
return s
}(),
src: func() ProfilesDictionary {
d := NewProfilesDictionary()
loc := d.LocationTable().AppendEmpty()
loc.SetAddress(42)
return d
}(),
dst: NewProfilesDictionary(),
wantStack: func() Stack {
s := NewStack()
s.LocationIndices().Append(0)
return s
}(),
wantDictionary: func() ProfilesDictionary {
d := NewProfilesDictionary()
loc := d.LocationTable().AppendEmpty()
loc.SetAddress(42)
return d
}(),
},
{
name: "with an existing location that needs a new indice",
stack: func() Stack {
s := NewStack()
s.LocationIndices().Append(0)
return s
}(),
src: func() ProfilesDictionary {
d := NewProfilesDictionary()
loc := d.LocationTable().AppendEmpty()
loc.SetAddress(42)
return d
}(),
dst: func() ProfilesDictionary {
d := NewProfilesDictionary()
loc := d.LocationTable().AppendEmpty()
loc.SetAddress(2)
return d
}(),
wantStack: func() Stack {
s := NewStack()
s.LocationIndices().Append(1)
return s
}(),
wantDictionary: func() ProfilesDictionary {
d := NewProfilesDictionary()
loc := d.LocationTable().AppendEmpty()
loc.SetAddress(2)
loc = d.LocationTable().AppendEmpty()
loc.SetAddress(42)
return d
}(),
},
{
name: "with a location index that does not match anything",
stack: func() Stack {
s := NewStack()
s.LocationIndices().Append(2)
return s
}(),
src: NewProfilesDictionary(),
dst: NewProfilesDictionary(),
wantStack: func() Stack {
s := NewStack()
s.LocationIndices().Append(2)
return s
}(),
wantDictionary: NewProfilesDictionary(),
wantErr: errors.New("invalid location index 2"),
},
{
name: "with a location index equal to the source table length (boundary condition)",
stack: func() Stack {
s := NewStack()
s.LocationIndices().Append(2) // Index 2 with length 2 (indices 0,1 are valid)
return s
}(),
src: func() ProfilesDictionary {
d := NewProfilesDictionary()
d.LocationTable().AppendEmpty() // Index 0
d.LocationTable().AppendEmpty() // Index 1
return d
}(),
dst: NewProfilesDictionary(),
wantStack: func() Stack {
s := NewStack()
s.LocationIndices().Append(2)
return s
}(),
wantDictionary: NewProfilesDictionary(),
wantErr: errors.New("invalid location index 2"),
},
} {
t.Run(tt.name, func(t *testing.T) {
stack := tt.stack
dst := tt.dst
err := stack.switchDictionary(tt.src, dst)
if tt.wantErr == nil {
require.NoError(t, err)
} else {
require.Equal(t, tt.wantErr, err)
}
assert.Equal(t, tt.wantStack, stack)
assert.Equal(t, tt.wantDictionary, dst)
})
}
}
func BenchmarkStackSwitchDictionary(b *testing.B) {
testutil.SkipMemoryBench(b)
s := NewStack()
s.LocationIndices().Append(1, 2)
src := NewProfilesDictionary()
src.LocationTable().AppendEmpty()
src.LocationTable().AppendEmpty().SetAddress(42)
src.LocationTable().AppendEmpty().SetAddress(43)
b.ReportAllocs()
for b.Loop() {
b.StopTimer()
dst := NewProfilesDictionary()
dst.LocationTable().AppendEmpty()
dst.LocationTable().AppendEmpty().SetAddress(43)
b.StartTimer()
_ = s.switchDictionary(src, dst)
}
}