mirror of
https://github.com/hanzoai/telemetry.git
synced 2026-10-30 20:01:49 +00:00
8bea0d372c
**Description:** - Validate Gate IDs: ids must be alphanumeric with dots. At a minimum we have to disallow `,` to avoid ambiguity in the CLI, but I am being intentionally more restrictive here - Validate URLs: we check that a valid URL can be built from it using the `net/url` stdlib package - Validate versions: we check that a valid version is passed to the `To/FromVersion` options using hashicorp's libraries and also that the implicit version range, when defined, is not empty. This does not change the public API types, it only adds validation. Relates to #8220 --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Alex Boten <[email protected]>
41 lines
967 B
Go
41 lines
967 B
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package featuregate
|
|
|
|
import (
|
|
"sync/atomic"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/go-version"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGate(t *testing.T) {
|
|
enabled := &atomic.Bool{}
|
|
enabled.Store(true)
|
|
from, err := version.NewVersion("v0.61.0")
|
|
require.NoError(t, err)
|
|
to, err := version.NewVersion("v0.64.0")
|
|
require.NoError(t, err)
|
|
|
|
g := &Gate{
|
|
id: "test",
|
|
description: "test gate",
|
|
enabled: enabled,
|
|
stage: StageAlpha,
|
|
referenceURL: "http://example.com",
|
|
fromVersion: from,
|
|
toVersion: to,
|
|
}
|
|
|
|
assert.Equal(t, "test", g.ID())
|
|
assert.Equal(t, "test gate", g.Description())
|
|
assert.True(t, g.IsEnabled())
|
|
assert.Equal(t, StageAlpha, g.Stage())
|
|
assert.Equal(t, "http://example.com", g.ReferenceURL())
|
|
assert.Equal(t, "v0.61.0", g.FromVersion())
|
|
assert.Equal(t, "v0.64.0", g.ToVersion())
|
|
}
|