mirror of
https://github.com/hanzoai/telemetry.git
synced 2026-10-30 20:01:49 +00:00
am1r021andGitHub
18c6cb9e7b
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `batchprocessor` could drop resource/scope `SchemaURL` during partial batch splits. This causes exported data to lose schema context. This change fixes it by copying `SchemaURL` on resource and scope containers in partial split logic for traces, metrics, and logs. <!-- Issue number if applicable --> #### Link to tracking issue Fixes # #12279 <!--Describe what testing was performed and which tests were added.--> #### Testing A unit test has been added for partial splits on metrics, traces, and logs to check if output still contains `schemaUrl`. <!--Describe the documentation added.--> #### Documentation N/A
161 lines
6.1 KiB
Go
161 lines
6.1 KiB
Go
// Copyright The OpenTelemetry Authors
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package batchprocessor
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"go.opentelemetry.io/collector/pdata/ptrace"
|
|
"go.opentelemetry.io/collector/pdata/testdata"
|
|
)
|
|
|
|
func TestSplitTraces_noop(t *testing.T) {
|
|
td := testdata.GenerateTraces(20)
|
|
splitSize := 40
|
|
split := splitTraces(splitSize, td)
|
|
assert.Equal(t, td, split)
|
|
|
|
i := 0
|
|
td.ResourceSpans().At(0).ScopeSpans().At(0).Spans().RemoveIf(func(ptrace.Span) bool {
|
|
i++
|
|
return i > 5
|
|
})
|
|
assert.Equal(t, td, split)
|
|
}
|
|
|
|
func TestSplitTraces(t *testing.T) {
|
|
td := testdata.GenerateTraces(20)
|
|
spans := td.ResourceSpans().At(0).ScopeSpans().At(0).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(0, i))
|
|
}
|
|
cp := ptrace.NewTraces()
|
|
cpSpans := cp.ResourceSpans().AppendEmpty().ScopeSpans().AppendEmpty().Spans()
|
|
cpSpans.EnsureCapacity(5)
|
|
td.ResourceSpans().At(0).Resource().CopyTo(
|
|
cp.ResourceSpans().At(0).Resource())
|
|
td.ResourceSpans().At(0).ScopeSpans().At(0).Scope().CopyTo(
|
|
cp.ResourceSpans().At(0).ScopeSpans().At(0).Scope())
|
|
spans.At(0).CopyTo(cpSpans.AppendEmpty())
|
|
spans.At(1).CopyTo(cpSpans.AppendEmpty())
|
|
spans.At(2).CopyTo(cpSpans.AppendEmpty())
|
|
spans.At(3).CopyTo(cpSpans.AppendEmpty())
|
|
spans.At(4).CopyTo(cpSpans.AppendEmpty())
|
|
|
|
splitSize := 5
|
|
split := splitTraces(splitSize, td)
|
|
assert.Equal(t, splitSize, split.SpanCount())
|
|
assert.Equal(t, cp, split)
|
|
assert.Equal(t, 15, td.SpanCount())
|
|
assert.Equal(t, "test-span-0-0", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-4", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(4).Name())
|
|
|
|
split = splitTraces(splitSize, td)
|
|
assert.Equal(t, 10, td.SpanCount())
|
|
assert.Equal(t, "test-span-0-5", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-9", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(4).Name())
|
|
|
|
split = splitTraces(splitSize, td)
|
|
assert.Equal(t, 5, td.SpanCount())
|
|
assert.Equal(t, "test-span-0-10", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-14", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(4).Name())
|
|
|
|
split = splitTraces(splitSize, td)
|
|
assert.Equal(t, 5, td.SpanCount())
|
|
assert.Equal(t, "test-span-0-15", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-19", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(4).Name())
|
|
}
|
|
|
|
func TestSplitTracesMultipleResourceSpans(t *testing.T) {
|
|
td := testdata.GenerateTraces(20)
|
|
spans := td.ResourceSpans().At(0).ScopeSpans().At(0).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(0, i))
|
|
}
|
|
// add second index to resource spans
|
|
testdata.GenerateTraces(20).
|
|
ResourceSpans().At(0).CopyTo(td.ResourceSpans().AppendEmpty())
|
|
spans = td.ResourceSpans().At(1).ScopeSpans().At(0).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(1, i))
|
|
}
|
|
|
|
splitSize := 5
|
|
split := splitTraces(splitSize, td)
|
|
assert.Equal(t, splitSize, split.SpanCount())
|
|
assert.Equal(t, 35, td.SpanCount())
|
|
assert.Equal(t, "test-span-0-0", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-4", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(4).Name())
|
|
}
|
|
|
|
func TestSplitTracesMultipleResourceSpans_SplitSizeGreaterThanSpanSize(t *testing.T) {
|
|
td := testdata.GenerateTraces(20)
|
|
spans := td.ResourceSpans().At(0).ScopeSpans().At(0).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(0, i))
|
|
}
|
|
// add second index to resource spans
|
|
testdata.GenerateTraces(20).
|
|
ResourceSpans().At(0).CopyTo(td.ResourceSpans().AppendEmpty())
|
|
spans = td.ResourceSpans().At(1).ScopeSpans().At(0).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(1, i))
|
|
}
|
|
|
|
splitSize := 25
|
|
split := splitTraces(splitSize, td)
|
|
assert.Equal(t, splitSize, split.SpanCount())
|
|
assert.Equal(t, 40-splitSize, td.SpanCount())
|
|
assert.Equal(t, 1, td.ResourceSpans().Len())
|
|
assert.Equal(t, "test-span-0-0", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-19", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(19).Name())
|
|
assert.Equal(t, "test-span-1-0", split.ResourceSpans().At(1).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-1-4", split.ResourceSpans().At(1).ScopeSpans().At(0).Spans().At(4).Name())
|
|
}
|
|
|
|
func TestSplitTracesMultipleILS(t *testing.T) {
|
|
td := testdata.GenerateTraces(20)
|
|
spans := td.ResourceSpans().At(0).ScopeSpans().At(0).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(0, i))
|
|
}
|
|
// add second index to ILS
|
|
td.ResourceSpans().At(0).ScopeSpans().At(0).
|
|
CopyTo(td.ResourceSpans().At(0).ScopeSpans().AppendEmpty())
|
|
spans = td.ResourceSpans().At(0).ScopeSpans().At(1).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(1, i))
|
|
}
|
|
|
|
// add third index to ILS
|
|
td.ResourceSpans().At(0).ScopeSpans().At(0).
|
|
CopyTo(td.ResourceSpans().At(0).ScopeSpans().AppendEmpty())
|
|
spans = td.ResourceSpans().At(0).ScopeSpans().At(2).Spans()
|
|
for i := 0; i < spans.Len(); i++ {
|
|
spans.At(i).SetName(getTestSpanName(2, i))
|
|
}
|
|
|
|
splitSize := 40
|
|
split := splitTraces(splitSize, td)
|
|
assert.Equal(t, splitSize, split.SpanCount())
|
|
assert.Equal(t, 20, td.SpanCount())
|
|
assert.Equal(t, "test-span-0-0", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0).Name())
|
|
assert.Equal(t, "test-span-0-4", split.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(4).Name())
|
|
}
|
|
|
|
func TestSplitTracesPreserveSchemaURLOnPartialSplit(t *testing.T) {
|
|
resourceSchemaURL := "https://test-resource-schema-url.com/"
|
|
scopeSchemaURL := "https://test-scope-schema-url.com/"
|
|
td := testdata.GenerateTraces(2)
|
|
td.ResourceSpans().At(0).SetSchemaUrl(resourceSchemaURL)
|
|
td.ResourceSpans().At(0).ScopeSpans().At(0).SetSchemaUrl(scopeSchemaURL)
|
|
|
|
splitSize := 1
|
|
split := splitTraces(splitSize, td)
|
|
assert.Equal(t, resourceSchemaURL, split.ResourceSpans().At(0).SchemaUrl())
|
|
assert.Equal(t, scopeSchemaURL, split.ResourceSpans().At(0).ScopeSpans().At(0).SchemaUrl())
|
|
}
|