Files
Joe ElliottandGitHub 43584e1fcb Query-frontend: Performance Improvements and Refactor (#3888)
* notes

Signed-off-by: Joe Elliott <[email protected]>

* bench

Signed-off-by: Joe Elliott <[email protected]>

* reduce cost of setting requestURI

Signed-off-by: Joe Elliott <[email protected]>

* Swap to interface

Signed-off-by: Joe Elliott <[email protected]>

* wip: cache failing

Signed-off-by: Joe Elliott <[email protected]>

* Response interface in the async pipeline

Signed-off-by: Joe Elliott <[email protected]>

* changelog

Signed-off-by: Joe Elliott <[email protected]>

* remove all hidden context propagation

Signed-off-by: Joe Elliott <[email protected]>

* lint and remove notes

Signed-off-by: Joe Elliott <[email protected]>

* its gonna be one of those linty kind of days

Signed-off-by: Joe Elliott <[email protected]>

* more lint

Signed-off-by: Joe Elliott <[email protected]>

---------

Signed-off-by: Joe Elliott <[email protected]>
2024-07-23 12:55:45 -04:00

106 lines
2.3 KiB
Go

package pipeline
import (
"context"
"sync"
"github.com/grafana/tempo/modules/frontend/combiner"
"github.com/grafana/tempo/pkg/boundedwaitgroup"
)
type waitGroup interface {
Add(int)
Done()
Wait()
}
// NewAsyncSharderFunc creates a new AsyncResponse that shards requests to the next AsyncRoundTripper[combiner.PipelineResponse]. It creates one
// goroutine per concurrent request.
func NewAsyncSharderFunc(ctx context.Context, concurrentReqs, totalReqs int, reqFn func(i int) Request, next AsyncRoundTripper[combiner.PipelineResponse]) Responses[combiner.PipelineResponse] {
var wg waitGroup
if concurrentReqs <= 0 {
wg = &sync.WaitGroup{}
} else {
bwg := boundedwaitgroup.New(uint(concurrentReqs))
wg = &bwg
}
asyncResp := newAsyncResponse()
go func() {
defer asyncResp.SendComplete()
for i := 0; i < totalReqs; i++ {
req := reqFn(i)
// else check for a request to pass down the pipeline
if req == nil {
continue
}
if err := req.Context().Err(); err != nil {
asyncResp.SendError(err)
continue
}
wg.Add(1)
go func(r Request) {
defer wg.Done()
resp, err := next.RoundTrip(r)
if err != nil {
asyncResp.SendError(err)
return
}
asyncResp.Send(ctx, resp)
}(req)
}
wg.Wait()
}()
return asyncResp
}
// NewAsyncSharderChan creates a new AsyncResponse that shards requests to the next AsyncRoundTripper[combiner.PipelineResponse] using a limited number of goroutines.
func NewAsyncSharderChan(ctx context.Context, concurrentReqs int, reqs <-chan Request, resps Responses[combiner.PipelineResponse], next AsyncRoundTripper[combiner.PipelineResponse]) Responses[combiner.PipelineResponse] {
if concurrentReqs == 0 {
panic("NewAsyncSharderChan: concurrentReqs must be greater than 0")
}
wg := &sync.WaitGroup{}
asyncResp := newAsyncResponse()
for i := 0; i < concurrentReqs; i++ {
wg.Add(1)
go func() {
defer wg.Done()
for req := range reqs {
if err := req.Context().Err(); err != nil {
asyncResp.SendError(err)
continue
}
resp, err := next.RoundTrip(req)
if err != nil {
asyncResp.SendError(err)
continue
}
asyncResp.Send(ctx, resp)
}
}()
}
go func() {
// send any responses back the caller would like to send
if resps != nil {
asyncResp.Send(ctx, resps)
}
wg.Wait()
asyncResp.SendComplete()
}()
return asyncResp
}