mirror of
https://github.com/hanzoai/traces.git
synced 2026-10-30 18:20:41 +00:00
Carles GarciaandGitHub
25606a1054
* frontend, distributor: Add tenant ID validation
Use the same validation than in Mimir for consistency.
In addition, reject empty IDs ("").
* Validate tenantID everywhere except in frontend handlers
We can't do it in frontend handlers because we need to wait for the multitenant middleware,
but we rely on the validation middleware.
Validating everywhere follows the same pattern as Mimir and ensures we don't miss any edge case.
* Check status codes
* Add test for user overrides API
* add comment
144 lines
3.8 KiB
Go
144 lines
3.8 KiB
Go
package ingester
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"runtime/debug"
|
|
|
|
"github.com/go-kit/log/level"
|
|
"github.com/grafana/tempo/pkg/tempopb"
|
|
"github.com/grafana/tempo/pkg/util/log"
|
|
"github.com/grafana/tempo/pkg/validation"
|
|
)
|
|
|
|
func (i *Ingester) SearchRecent(ctx context.Context, req *tempopb.SearchRequest) (res *tempopb.SearchResponse, err error) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
level.Error(log.Logger).Log("msg", "recover in SearchRecent", "query", req.Query, "stack", r, string(debug.Stack()))
|
|
err = errors.New("recovered in SearchRecent")
|
|
}
|
|
}()
|
|
|
|
instanceID, err := validation.ExtractValidTenantID(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
inst, ok := i.getInstanceByID(instanceID)
|
|
if !ok || inst == nil {
|
|
return &tempopb.SearchResponse{}, nil
|
|
}
|
|
|
|
res, err = inst.Search(ctx, req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (i *Ingester) SearchTags(ctx context.Context, req *tempopb.SearchTagsRequest) (res *tempopb.SearchTagsResponse, err error) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
level.Error(log.Logger).Log("msg", "recover in SearchTags", "stack", r, string(debug.Stack()))
|
|
err = errors.New("recovered in SearchTags")
|
|
}
|
|
}()
|
|
|
|
instanceID, err := validation.ExtractValidTenantID(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
inst, ok := i.getInstanceByID(instanceID)
|
|
if !ok || inst == nil {
|
|
return &tempopb.SearchTagsResponse{}, nil
|
|
}
|
|
|
|
res, err = inst.SearchTags(ctx, req.Scope)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (i *Ingester) SearchTagsV2(ctx context.Context, req *tempopb.SearchTagsRequest) (res *tempopb.SearchTagsV2Response, err error) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
level.Error(log.Logger).Log("msg", "recover in SearchTagsV2", "stack", r, string(debug.Stack()))
|
|
err = errors.New("recovered in SearchTagsV2")
|
|
}
|
|
}()
|
|
|
|
instanceID, err := validation.ExtractValidTenantID(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
inst, ok := i.getInstanceByID(instanceID)
|
|
if !ok || inst == nil {
|
|
return &tempopb.SearchTagsV2Response{}, nil
|
|
}
|
|
|
|
res, err = inst.SearchTagsV2(ctx, req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (i *Ingester) SearchTagValues(ctx context.Context, req *tempopb.SearchTagValuesRequest) (res *tempopb.SearchTagValuesResponse, err error) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
level.Error(log.Logger).Log("msg", "recover in SearchTagValues", "stack", r, string(debug.Stack()))
|
|
err = errors.New("recovered in SearchTagValues")
|
|
}
|
|
}()
|
|
|
|
instanceID, err := validation.ExtractValidTenantID(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
inst, ok := i.getInstanceByID(instanceID)
|
|
if !ok || inst == nil {
|
|
return &tempopb.SearchTagValuesResponse{}, nil
|
|
}
|
|
|
|
res, err = inst.SearchTagValues(ctx, req.TagName, req.MaxTagValues, req.StaleValueThreshold)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (i *Ingester) SearchTagValuesV2(ctx context.Context, req *tempopb.SearchTagValuesRequest) (res *tempopb.SearchTagValuesV2Response, err error) {
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
level.Error(log.Logger).Log("msg", "recover in SearchTagValuesV2", "tag", req.TagName, "query", req.Query, "stack", r, string(debug.Stack()))
|
|
err = errors.New("recovered in SearchTagValuesV2")
|
|
}
|
|
}()
|
|
|
|
instanceID, err := validation.ExtractValidTenantID(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
inst, ok := i.getInstanceByID(instanceID)
|
|
if !ok || inst == nil {
|
|
return &tempopb.SearchTagValuesV2Response{}, nil
|
|
}
|
|
|
|
res, err = inst.SearchTagValuesV2(ctx, req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
// SearchBlock only exists here to fulfill the protobuf interface. The ingester will never support
|
|
// backend search
|
|
func (i *Ingester) SearchBlock(context.Context, *tempopb.SearchBlockRequest) (*tempopb.SearchResponse, error) {
|
|
return nil, errors.New("not implemented")
|
|
}
|