mirror of
https://github.com/hanzoai/traces.git
synced 2026-10-30 18:20:41 +00:00
Koenraad VerheydenandGitHub
879a61b482
* User-configurable overrides: add optional check to block API requests that conflict with runtime overrides * Simplify interface, omit concept of a level * Drop gofakeit.Fakeable interface implementation * Add UserConfigurableOverridesAPIConfig.RegisterFlagsAndApplyDefaults * Fix test, return err when parameter can not be parsed * Addressing review comments
77 lines
2.5 KiB
Go
77 lines
2.5 KiB
Go
package overrides
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/grafana/tempo/modules/overrides/userconfigurable/client"
|
|
)
|
|
|
|
func TestRuntimeConfigOverridesManager_GetRuntimeOverridesFor_runtimeConfigOverridesManager(t *testing.T) {
|
|
defaults := Overrides{
|
|
MetricsGenerator: MetricsGeneratorOverrides{
|
|
CollectionInterval: 60 * time.Second,
|
|
},
|
|
}
|
|
tenantOverrides := &perTenantOverrides{
|
|
TenantLimits: map[string]*Overrides{
|
|
"foo": {
|
|
MetricsGenerator: MetricsGeneratorOverrides{
|
|
CollectionInterval: 15 * time.Second,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
runtimeOverridesManager, cleanup := createAndInitializeRuntimeOverridesManager(t, defaults, toYamlBytes(t, tenantOverrides))
|
|
defer cleanup()
|
|
|
|
overrides := runtimeOverridesManager.GetRuntimeOverridesFor("default")
|
|
assert.NotNil(t, overrides)
|
|
assert.Equal(t, 60*time.Second, overrides.MetricsGenerator.CollectionInterval)
|
|
|
|
overrides = runtimeOverridesManager.GetRuntimeOverridesFor("foo")
|
|
assert.NotNil(t, overrides)
|
|
assert.Equal(t, 15*time.Second, overrides.MetricsGenerator.CollectionInterval)
|
|
}
|
|
|
|
func TestRuntimeConfigOverridesManager_GetRuntimeOverridesFor_userConfigurableOverridesManager(t *testing.T) {
|
|
defaults := Overrides{
|
|
MetricsGenerator: MetricsGeneratorOverrides{
|
|
CollectionInterval: 60 * time.Second,
|
|
},
|
|
}
|
|
tenantOverrides := &perTenantOverrides{
|
|
TenantLimits: map[string]*Overrides{
|
|
"foo": {
|
|
MetricsGenerator: MetricsGeneratorOverrides{
|
|
CollectionInterval: 15 * time.Second,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
_, userConfigurableOverridesManager, cleanup := localUserConfigOverrides(t, defaults, toYamlBytes(t, tenantOverrides))
|
|
defer cleanup()
|
|
|
|
// put in some user-configurable limits - these will be ignored anyway
|
|
userConfigurableOverridesManager.setTenantLimit("foo", &client.Limits{
|
|
Forwarders: nil,
|
|
MetricsGenerator: client.LimitsMetricsGenerator{
|
|
CollectionInterval: &client.Duration{Duration: 5 * time.Minute},
|
|
},
|
|
})
|
|
|
|
overrides := userConfigurableOverridesManager.GetRuntimeOverridesFor("default")
|
|
assert.NotNil(t, overrides)
|
|
assert.Equal(t, 60*time.Second, userConfigurableOverridesManager.MetricsGeneratorCollectionInterval("default"))
|
|
assert.Equal(t, 60*time.Second, overrides.MetricsGenerator.CollectionInterval)
|
|
|
|
overrides = userConfigurableOverridesManager.GetRuntimeOverridesFor("foo")
|
|
assert.NotNil(t, overrides)
|
|
assert.Equal(t, 5*time.Minute, userConfigurableOverridesManager.MetricsGeneratorCollectionInterval("foo"))
|
|
assert.Equal(t, 15*time.Second, overrides.MetricsGenerator.CollectionInterval)
|
|
}
|