mirror of
https://github.com/hanzoai/traces.git
synced 2026-10-30 18:20:41 +00:00
aeda5144b1
* fix: correctly publish the hedgedmetrics counter with delta * fix and update CHANGELOG.md * fix datarace in the test * replace locking with atomic * remove locking and unnecessary code Signed-off-by: Joe Elliott <[email protected]> * i don't care Signed-off-by: Joe Elliott <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]> Co-authored-by: Joe Elliott <[email protected]>
110 lines
2.8 KiB
Go
110 lines
2.8 KiB
Go
package hedgedmetrics
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cristalhq/hedgedhttp"
|
|
"github.com/grafana/tempo/pkg/util/test"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestDiffCounter(t *testing.T) {
|
|
ctr := prometheus.NewCounter(prometheus.CounterOpts{Name: test.RandomString()})
|
|
dc := &diffCounter{previous: 0, counter: ctr}
|
|
|
|
dc.addAbsoluteToCounter(5)
|
|
require.Equal(t, 5.0, ctrVal(t, ctr))
|
|
|
|
dc.addAbsoluteToCounter(7)
|
|
require.Equal(t, 7.0, ctrVal(t, ctr))
|
|
|
|
dc.addAbsoluteToCounter(57)
|
|
require.Equal(t, 57.0, ctrVal(t, ctr))
|
|
}
|
|
|
|
/* Fails in CI. potentially due to an architectural difference and prom internals.
|
|
func TestDiffCounterOverflow(t *testing.T) {
|
|
ctr := prometheus.NewCounter(prometheus.CounterOpts{Name: test.RandomString()})
|
|
dc := &diffCounter{previous: 0, counter: ctr}
|
|
|
|
// start with something large
|
|
bigNum := math.MaxUint64 - uint64(1)
|
|
dc.addAbsoluteToCounter(bigNum)
|
|
require.Equal(t, float64(bigNum), ctrVal(t, ctr))
|
|
|
|
// then wrap the uint64s
|
|
dc.addAbsoluteToCounter(2)
|
|
require.Equal(t, 1.0, ctrVal(t, ctr)) // this is one off b/c of the internal counter wrap in prom. this could be corrected for but doesn't matter
|
|
|
|
dc.addAbsoluteToCounter(7)
|
|
require.Equal(t, 6.0, ctrVal(t, ctr))
|
|
}
|
|
*/
|
|
|
|
// MockStatsProvider is StatsProvider for testing
|
|
type MockStatsProvider struct {
|
|
mu sync.Mutex
|
|
actualRoundTrips uint64
|
|
requestedRoundTrips uint64
|
|
}
|
|
|
|
func (m *MockStatsProvider) Snapshot() hedgedhttp.StatsSnapshot {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
return hedgedhttp.StatsSnapshot{
|
|
ActualRoundTrips: m.actualRoundTrips,
|
|
RequestedRoundTrips: m.requestedRoundTrips,
|
|
}
|
|
}
|
|
|
|
func (m *MockStatsProvider) SetStats(actual, requested uint64) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
m.actualRoundTrips = actual
|
|
m.requestedRoundTrips = requested
|
|
}
|
|
|
|
func TestPublish(t *testing.T) {
|
|
ctr := prometheus.NewCounter(prometheus.CounterOpts{Name: test.RandomString()})
|
|
stats := &MockStatsProvider{}
|
|
|
|
publishWithDuration(stats, ctr, 10*time.Millisecond)
|
|
|
|
require.Equal(t, 0.0, ctrVal(t, ctr))
|
|
|
|
// Set initial stats values
|
|
stats.SetStats(5, 5)
|
|
time.Sleep(30 * time.Millisecond)
|
|
require.Equal(t, 0.0, ctrVal(t, ctr))
|
|
|
|
stats.SetStats(15, 10)
|
|
time.Sleep(30 * time.Millisecond)
|
|
require.Equal(t, 5.0, ctrVal(t, ctr))
|
|
|
|
stats.SetStats(28, 20)
|
|
time.Sleep(30 * time.Millisecond)
|
|
require.Equal(t, 8.0, ctrVal(t, ctr))
|
|
|
|
stats.SetStats(38, 25)
|
|
time.Sleep(30 * time.Millisecond)
|
|
require.Equal(t, 13.0, ctrVal(t, ctr))
|
|
|
|
time.Sleep(30 * time.Millisecond)
|
|
|
|
// counter doesn't increase if stats stay same
|
|
time.Sleep(30 * time.Millisecond)
|
|
require.Equal(t, 13.0, ctrVal(t, ctr))
|
|
}
|
|
|
|
func ctrVal(t *testing.T, ctr prometheus.Counter) float64 {
|
|
t.Helper()
|
|
|
|
val, err := test.GetCounterValue(ctr)
|
|
require.NoError(t, err)
|
|
|
|
return val
|
|
}
|