Files
76c2c85b97 [Generator] Add DRAIN span_name sanitizer (#6098)
* [Generator] Add DRAIN span_name sanitizer

* Fix linter

* Fix formatting

* Update default manifest

* Fix build error in update-fixtures

* Remove bad test

* Remove misleading comment

* Add per-tenant override for drain mode

* Do a machines job

* Address PR feedback

* Address PR review: rename drain_mode config and improve sanitizer

- Rename `drain_mode` to `span_name_sanitization` across all config,
  legacy config, interfaces, and overrides for better user-facing clarity
- Add explicit default value "disabled" in RegisterFlagsAndApplyDefaults
- Add ValidateSpanNameSanitization function in validation/fields.go
- Rename metrics to remove DRAIN reference:
  `drain_spans_compacted_total` -> `spans_sanitized_total`
  `post_drain_demand_estimate` -> `post_sanitization_demand_estimate`
- Pass configured staleDuration to NewDrainSanitizer instead of
  hardcoded 15min, consistent with other registry components
- Extract "span_name" magic string to labelSpanName constant
- Update all tests with new names and signatures

* Update manifest

* Use empty string as disabled

* Update CHANGELOG.md

Co-authored-by: Suraj Nath <[email protected]>

* Update manifest

---------

Co-authored-by: Suraj Nath <[email protected]>
2026-02-22 00:55:22 -08:00

103 lines
3.6 KiB
Go

// Copyright (c) 2024 Alexey Mayshev and contributors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package stats
import (
"math"
"sync/atomic"
"time"
"github.com/maypok86/otter/v2/internal/xruntime"
"github.com/maypok86/otter/v2/internal/xsync"
)
// Counter is a goroutine-safe [Recorder] implementation for use by otter.Cache.
type Counter struct {
hits *xsync.Adder
misses *xsync.Adder
_ [xruntime.CacheLineSize - 16]byte
evictions atomic.Uint64
evictionWeight atomic.Uint64
_ [xruntime.CacheLineSize - 16]byte
loadSuccesses atomic.Uint64
loadFailures atomic.Uint64
totalLoadTime atomic.Uint64
}
// NewCounter constructs a [Counter] instance with all counts initialized to zero.
func NewCounter() *Counter {
return &Counter{
hits: xsync.NewAdder(),
misses: xsync.NewAdder(),
}
}
// Snapshot returns a snapshot of this recorder's values. Note that this may be an inconsistent view, as it
// may be interleaved with update operations.
//
// NOTE: the values of the metrics are undefined in case of overflow. If you require specific handling, we recommend
// implementing your own [Recorder].
func (c *Counter) Snapshot() Stats {
totalLoadTime := c.totalLoadTime.Load()
if totalLoadTime > uint64(math.MaxInt64) {
totalLoadTime = uint64(math.MaxInt64)
}
return Stats{
Hits: c.hits.Value(),
Misses: c.misses.Value(),
Evictions: c.evictions.Load(),
EvictionWeight: c.evictionWeight.Load(),
LoadSuccesses: c.loadSuccesses.Load(),
LoadFailures: c.loadFailures.Load(),
TotalLoadTime: time.Duration(totalLoadTime),
}
}
// RecordHits records cache hits. This should be called when a cache request returns a cached value.
func (c *Counter) RecordHits(count int) {
//nolint:gosec // there is no overflow
c.hits.Add(uint64(count))
}
// RecordMisses records cache misses. This should be called when a cache request returns a value that was not
// found in the cache.
func (c *Counter) RecordMisses(count int) {
//nolint:gosec // there is no overflow
c.misses.Add(uint64(count))
}
// RecordEviction records the eviction of an entry from the cache. This should only been called when an entry is
// evicted due to the cache's eviction strategy, and not as a result of manual deletions.
func (c *Counter) RecordEviction(weight uint32) {
c.evictions.Add(1)
c.evictionWeight.Add(uint64(weight))
}
// RecordLoadSuccess records the successful load of a new entry. This method should be called when a cache request
// causes an entry to be loaded and the loading completes successfully (either no error or otter.ErrNotFound).
func (c *Counter) RecordLoadSuccess(loadTime time.Duration) {
c.loadSuccesses.Add(1)
//nolint:gosec // there is no overflow
c.totalLoadTime.Add(uint64(loadTime))
}
// RecordLoadFailure records the failed load of a new entry. This method should be called when a cache request
// causes an entry to be loaded, but the loading function returns an error that is not otter.ErrNotFound.
func (c *Counter) RecordLoadFailure(loadTime time.Duration) {
c.loadFailures.Add(1)
//nolint:gosec // there is no overflow
c.totalLoadTime.Add(uint64(loadTime))
}