mirror of
https://github.com/hanzoai/ui.git
synced 2026-11-21 00:18:41 +00:00
Red review of the cd.hanzo.ai app found three real defects in the SHARED components (so this hardens the console surfaces too): - tree: buildResourceGraph seeded `children` lazily per node, so any tree that listed a child before its parent — or any ownerRef cycle — dereferenced undefined and threw during render. K8s object lists are not topologically sorted, so this fired on ordinary data and, with no error boundary, blanked the whole dashboard. Pre-seed every id before the edge pass. - health/sync: the substring fallback up-guessed a BAD state to a GOOD one (NotReady/unavailable -> Healthy, notsynced -> Synced). An incident shown green is worse than one shown Unknown, so the positive up-guess is gone; unrecognized folds to Unknown. foldSync also normalizes separators so the canonical out-of-sync folds at the source. - diff: lineDiff always built the full O(n*m) LCS matrix; a large ConfigMap (reachable — not Secret-excluded) froze the tab. Size-guard to a block diff. Also: an app-level ErrorBoundary so one render throw can never white-screen the dashboard, client log caps + array-shaped log tolerance, a Secret-kind skip in the tree, and vitest no longer globs the Playwright specs. Tests assert the fixed behavior: 35/35 unit (incl. the adversarial fuzz suite flipped from codifying the bugs), 42/42 gitops, 2/2 e2e desktop+mobile.