Files
Jamie LiuandgVisor bot b8de7c720c Minor FPU save/restore fixes.
- Use the correct instruction in safecopy.checkXstate(). Before this CL:

```
TEXT pkg/sentry/arch/fpu/fpu.initX86FPState.abi0(SB)
  ...
  fpu_amd64.s:78        0x7661b2                480fae2f                XRSTOR64 0(DI)

TEXT pkg/safecopy/safecopy.checkXstate.abi0(SB)
  ...
  xrstor_amd64.s:54     0x7648a0                0fae2f                  XRSTOR 0(DI)
```

I'm not sure what the actual difference between XRSTOR and XRSTOR64 is, but
Linux is careful to use XRSTOR64 (arch/x86/kernel/fpu/xstate.h:XRSTOR,
REX_PREFIX) so it probably matters.

- When an AfterLoad callback fails, log the error message before the failing
  object, since the latter can be huge and prevent the error message from being
  logged.

- Include additional information in the error message emitted by
  fpu.State.AfterLoad().

PiperOrigin-RevId: 605534648
2024-02-08 23:11:09 -08:00

60 lines
2.0 KiB
ArmAsm

// Copyright 2023 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "textflag.h"
// handleCheckXstateFault returns (the value stored in AX, the value stored in DI).
// Control is transferred to it when checkXstate below receives SIGSEGV or SIGBUS,
// with the faulting address stored in AX and the signal number stored in DI.
//
// It must have the same frame configuration as memcpy so that it can undo any
// potential call frame set up by the assembler.
TEXT handleCheckXstateFault(SB), NOSPLIT|NOFRAME, $0-26
MOVQ AX, addr+8(FP)
MOVL DI, sig+16(FP)
LDMXCSR mxcsr+20(FP)
BYTE $0xDB; BYTE $0xE2; // FNCLEX
FLDCW cw+24(FP)
RET
// ·checkXstate verifies that the specified floating point state can be loaded.
TEXT ·checkXstate(SB),NOSPLIT|NOFRAME,$0-26
// Store 0 as the returned signal number. If we run to completion,
// this is the value the caller will see; if a signal is received,
// handleMemcpyFault will store a different value in this address.
MOVL $0, sig+16(FP)
// MXCSR and the x87 control word are the only floating point state
// that is callee-save and thus we must save.
STMXCSR mxcsr+20(FP)
FSTCW cw+24(FP)
MOVQ addr+0(FP), DI
MOVL $0xffffffff, AX
MOVL $0xffffffff, DX
XRSTOR64 (DI)
// Restore MXCSR and the x87 control word.
LDMXCSR mxcsr+20(FP)
BYTE $0xDB; BYTE $0xE2; // FNCLEX
FLDCW cw+24(FP)
RET
// func addrOfCheckXstate() uintptr
TEXT ·addrOfCheckXstate(SB), $0-8
MOVQ $·checkXstate(SB), AX
MOVQ AX, ret+0(FP)
RET