Files
Ryan El Kochta efb3bcd85f Implement openat2(2) in gVisor
Seems that GNU tar extraction has been broken in gVisor since 75b03fd
(11/15/2025), which started using openat2(2) to address CVE-2025-45582.

tar uses openat2(2) for the RESOLVE_BENEATH flag which allows scoping
the path resolution underneath the specified dirfd.

This commit implements openat2(2) in gVisor, with support for all flags
supported by Linux: RESOLVE_BENEATH, RESOLVE_IN_ROOT, RESOLVE_CACHED,
RESOLVE_NO_MAGICLINKS, RESOLVE_NO_SYMLINKS, and RESOLVE_NO_XDEV.

This commit also introduces VirtualFilesystem.renameSeq, a global
sequence counter that along with mountSeq detects mount or rename
operations that race with scoped traversals.

A final "resolved-path-is-under-dirfd" check is performed after
the traversal. This is for two reasons: (1) in case of a bug in
any of the above logic, or (2) in case of an (extremely unlikely)
attack where mountSeq overflows by exactly 2^32 during a path
resolution. Unfortunately, due to the way path traversal in gVisor
is tightly coupled to the operation being performed by a VFS method,
using scoped traversals in an operation that *mutates* anything will
be difficult, since without major refactoring, the check must happen
after the side effect has taken place.

Currently, Linux only exposes scoped traversals through openat2(2),
so destroying the created fd is all we need to do if the final check
fails. (As a result of this limitation, most VFS functions have been
modified to reject scoped traversals "just-in-case".)

The RESOLVE_NO_XDEV implementation has a slight divergence from
Linux. It is a bit looser, permitting absolute symlinks in any case
where the root dentry's mount matches the mount the traversal is
locked to. Linux's behavior here is likely a bug, and since we can
safely be *more* permissive, there's not much reason to match it.

This commit also adds syscall tests and an strace formatter for
openat2(2).
2026-08-21 10:34:56 -07:00

305 lines
7.8 KiB
Go

// Copyright 2018 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package strace
import (
"gvisor.dev/gvisor/pkg/abi"
"gvisor.dev/gvisor/pkg/sentry/arch"
"gvisor.dev/gvisor/pkg/sentry/kernel"
)
// FormatSpecifier values describe how an individual syscall argument should be
// formatted.
type FormatSpecifier int
// Valid FormatSpecifiers.
//
// Unless otherwise specified, values are formatted before syscall execution
// and not updated after syscall execution (the same value is output).
const (
// Hex is just a hexadecimal number.
Hex FormatSpecifier = iota
// Oct is just an octal number.
Oct
// FD is a file descriptor.
FD
// ReadBuffer is a buffer for a read-style call. The syscall return
// value is used for the length.
//
// Formatted after syscall execution.
ReadBuffer
// WriteBuffer is a buffer for a write-style call. The following arg is
// used for the length.
//
// Contents omitted after syscall execution.
WriteBuffer
// ReadIOVec is a pointer to a struct iovec for a writev-style call.
// The following arg is used for the length. The return value is used
// for the total length.
//
// Complete contents only formatted after syscall execution.
ReadIOVec
// WriteIOVec is a pointer to a struct iovec for a writev-style call.
// The following arg is used for the length.
//
// Complete contents only formatted before syscall execution, omitted
// after.
WriteIOVec
// IOVec is a generic pointer to a struct iovec. Contents are not dumped.
IOVec
// SendMsgHdr is a pointer to a struct msghdr for a sendmsg-style call.
// Contents formatted only before syscall execution, omitted after.
SendMsgHdr
// RecvMsgHdr is a pointer to a struct msghdr for a recvmsg-style call.
// Contents formatted only after syscall execution.
RecvMsgHdr
// Path is a pointer to a char* path.
Path
// PostPath is a pointer to a char* path, formatted after syscall
// execution.
PostPath
// ExecveStringVector is a NULL-terminated array of strings. Enforces
// the maximum execve array length.
ExecveStringVector
// PipeFDs is an array of two FDs, formatted after syscall execution.
PipeFDs
// Uname is a pointer to a struct uname, formatted after syscall execution.
Uname
// Stat is a pointer to a struct stat, formatted after syscall execution.
Stat
// SockAddr is a pointer to a struct sockaddr. The following arg is
// used for length.
SockAddr
// PostSockAddr is a pointer to a struct sockaddr, formatted after
// syscall execution. The following arg is a pointer to the socklen_t
// length.
PostSockAddr
// SockLen is a pointer to a socklen_t, formatted before and after
// syscall execution.
SockLen
// SockFamily is a socket protocol family value.
SockFamily
// SockType is a socket type and flags value.
SockType
// SockProtocol is a socket protocol value. Argument n-2 is the socket
// protocol family.
SockProtocol
// SockFlags are socket flags.
SockFlags
// Timespec is a pointer to a struct timespec.
Timespec
// PostTimespec is a pointer to a struct timespec, formatted after
// syscall execution.
PostTimespec
// UTimeTimespec is a pointer to a struct timespec. Formatting includes
// UTIME_NOW and UTIME_OMIT.
UTimeTimespec
// ItimerVal is a pointer to a struct itimerval.
ItimerVal
// PostItimerVal is a pointer to a struct itimerval, formatted after
// syscall execution.
PostItimerVal
// ItimerSpec is a pointer to a struct itimerspec.
ItimerSpec
// PostItimerSpec is a pointer to a struct itimerspec, formatted after
// syscall execution.
PostItimerSpec
// Timeval is a pointer to a struct timeval, formatted before and after
// syscall execution.
Timeval
// Utimbuf is a pointer to a struct utimbuf.
Utimbuf
// Rusage is a struct rusage, formatted after syscall execution.
Rusage
// CloneFlags are clone(2) flags.
CloneFlags
// OpenFlags are open(2) flags.
OpenFlags
// OpenHow is how for openat2(2).
OpenHow
// Mode is a mode_t.
Mode
// FutexOp is the futex(2) operation.
FutexOp
// PtraceRequest is the ptrace(2) request.
PtraceRequest
// ItimerType is an itimer type (ITIMER_REAL, etc).
ItimerType
// Signal is a signal number.
Signal
// SignalMaskAction is a signal mask action passed to rt_sigprocmask(2).
SignalMaskAction
// SigSet is a signal set.
SigSet
// PostSigSet is a signal set, formatted after syscall execution.
PostSigSet
// SigAction is a struct sigaction.
SigAction
// PostSigAction is a struct sigaction, formatted after syscall execution.
PostSigAction
// CapHeader is a cap_user_header_t.
CapHeader
// CapData is the data argument to capget(2)/capset(2). The previous
// argument must be CapHeader.
CapData
// PostCapData is the data argument to capget(2)/capset(2), formatted
// after syscall execution. The previous argument must be CapHeader.
PostCapData
// PollFDs is an array of struct pollfd. The number of entries in the
// array is in the next argument.
PollFDs
// SelectFDSet is an fd_set argument in select(2)/pselect(2). The
// number of FDs represented must be the first argument.
SelectFDSet
// GetSockOptVal is the optval argument in getsockopt(2).
//
// Formatted after syscall execution.
GetSockOptVal
// SetSockOptVal is the optval argument in setsockopt(2).
//
// Contents omitted after syscall execution.
SetSockOptVal
// SockOptLevel is the level argument in getsockopt(2) and
// setsockopt(2).
SockOptLevel
// SockOptLevel is the optname argument in getsockopt(2) and
// setsockopt(2).
SockOptName
// EpollCtlOp is the op argument to epoll_ctl(2).
EpollCtlOp
// EpollEvent is the event argument in epoll_ctl(2).
EpollEvent
// EpollEvents is an array of struct epoll_event. It is the events
// argument in epoll_wait(2)/epoll_pwait(2).
EpollEvents
// MmapProt is the protection argument in mmap(2).
MmapProt
// MmapFlags is the flags argument in mmap(2).
MmapFlags
// CloseRangeFlags are close_range(2) flags.
CloseRangeFlags
)
// defaultFormat is the syscall argument format to use if the actual format is
// not known. It formats all six arguments as hex.
var defaultFormat = []FormatSpecifier{Hex, Hex, Hex, Hex, Hex, Hex}
// SyscallInfo captures the name and printing format of a syscall.
type SyscallInfo struct {
// name is the name of the syscall.
name string
// format contains the format specifiers for each argument.
//
// Syscall calls can have up to six arguments. Arguments without a
// corresponding entry in format will not be printed.
format []FormatSpecifier
}
// makeSyscallInfo returns a SyscallInfo for a syscall.
func makeSyscallInfo(name string, f ...FormatSpecifier) SyscallInfo {
return SyscallInfo{name: name, format: f}
}
// SyscallMap maps syscalls into names and printing formats.
type SyscallMap map[uintptr]SyscallInfo
var _ kernel.Stracer = (SyscallMap)(nil)
// syscallTable contains the syscalls for a specific OS/Arch.
type syscallTable struct {
// os is the operating system this table targets.
os abi.OS
// arch is the architecture this table targets.
arch arch.Arch
// syscalls contains the syscall mappings.
syscalls SyscallMap
}
var syscallTables []syscallTable
// Lookup returns the SyscallMap for the OS/Arch combination. The returned map
// must not be changed.
func Lookup(os abi.OS, a arch.Arch) (SyscallMap, bool) {
for _, s := range syscallTables {
if s.os == os && s.arch == a {
return s.syscalls, true
}
}
return nil, false
}