Files
Shayon Mukherjee 27f11cc665 tmpfs: Clear security.capability xattr on write
When a non-privileged user writes to a file on tmpfs, Linux clears both
the setuid/setgid mode bits and the security.capability xattr via
file_remove_privs. The mode bit clearing was already implemented through
ClearSUIDAndSGID, but the xattr removal was missing, so file
capabilities survived content replacement. An unprivileged user could
overwrite a capability-bearing binary and execute it with the retained
privileges.

Fixes #13063
2026-05-05 21:25:01 -04:00

164 lines
4.8 KiB
Go

// Copyright 2020 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Package memxattr provides a default, in-memory extended attribute
// implementation.
package memxattr
import (
"maps"
"strings"
"gvisor.dev/gvisor/pkg/abi/linux"
"gvisor.dev/gvisor/pkg/errors/linuxerr"
"gvisor.dev/gvisor/pkg/sentry/kernel/auth"
"gvisor.dev/gvisor/pkg/sentry/vfs"
"gvisor.dev/gvisor/pkg/sync"
)
// SimpleExtendedAttributes implements extended attributes using a map of
// names to values.
//
// SimpleExtendedAttributes calls vfs.CheckXattrPermissions, so callers are not
// required to do so.
//
// +stateify savable
type SimpleExtendedAttributes struct {
// mu protects the below fields.
mu sync.RWMutex `state:"nosave"`
xattrs map[string]string
}
// GetXattr returns the value at 'name'.
func (x *SimpleExtendedAttributes) GetXattr(creds *auth.Credentials, mode linux.FileMode, kuid auth.KUID, opts *vfs.GetXattrOptions) (string, error) {
if err := vfs.CheckXattrPermissions(creds, vfs.MayRead, mode, kuid, opts.Name); err != nil {
return "", err
}
x.mu.RLock()
value, ok := x.xattrs[opts.Name]
x.mu.RUnlock()
if !ok {
return "", linuxerr.ENODATA
}
// Check that the size of the buffer provided in getxattr(2) is large enough
// to contain the value.
if opts.Size != 0 && uint64(len(value)) > opts.Size {
return "", linuxerr.ERANGE
}
if opts.Name == linux.XATTR_SECURITY_CAPABILITY {
return auth.FixupVfsCapDataOnGet(creds, value)
}
return value, nil
}
// SetXattr sets 'value' at 'name'.
func (x *SimpleExtendedAttributes) SetXattr(creds *auth.Credentials, mode linux.FileMode, kuid auth.KUID, kgid auth.KGID, opts *vfs.SetXattrOptions) error {
if err := vfs.CheckXattrPermissions(creds, vfs.MayWrite, mode, kuid, opts.Name); err != nil {
return err
}
x.mu.Lock()
defer x.mu.Unlock()
if x.xattrs == nil {
if opts.Flags&linux.XATTR_REPLACE != 0 {
return linuxerr.ENODATA
}
x.xattrs = make(map[string]string)
}
_, ok := x.xattrs[opts.Name]
if ok && opts.Flags&linux.XATTR_CREATE != 0 {
return linuxerr.EEXIST
}
if !ok && opts.Flags&linux.XATTR_REPLACE != 0 {
return linuxerr.ENODATA
}
if opts.Name == linux.XATTR_SECURITY_CAPABILITY {
var err error
opts.Value, err = auth.FixupVfsCapDataOnSet(creds, opts.Value, kuid, kgid)
if err != nil {
return err
}
}
x.xattrs[opts.Name] = opts.Value
return nil
}
// ListXattr returns all names in xattrs.
func (x *SimpleExtendedAttributes) ListXattr(creds *auth.Credentials, size uint64) ([]string, error) {
// Keep track of the size of the buffer needed in listxattr(2) for the list.
listSize := 0
x.mu.RLock()
names := make([]string, 0, len(x.xattrs))
haveCap := creds.HasRootCapability(linux.CAP_SYS_ADMIN)
for n := range x.xattrs {
// Hide extended attributes in the "trusted" namespace from
// non-privileged users. This is consistent with Linux's
// fs/xattr.c:simple_xattr_list().
if !haveCap && strings.HasPrefix(n, linux.XATTR_TRUSTED_PREFIX) {
continue
}
names = append(names, n)
// Add one byte per null terminator.
listSize += len(n) + 1
}
x.mu.RUnlock()
if size != 0 && uint64(listSize) > size {
return nil, linuxerr.ERANGE
}
return names, nil
}
// KillPriv removes the "security.capability" xattr if present. No permission
// check is needed because the caller is removing privileges on behalf of the
// kernel, not userspace.
func (x *SimpleExtendedAttributes) KillPriv() {
x.mu.Lock()
delete(x.xattrs, linux.XATTR_SECURITY_CAPABILITY)
x.mu.Unlock()
}
// RemoveXattr removes the xattr at 'name'.
func (x *SimpleExtendedAttributes) RemoveXattr(creds *auth.Credentials, mode linux.FileMode, kuid auth.KUID, name string) error {
if err := vfs.CheckXattrPermissions(creds, vfs.MayWrite, mode, kuid, name); err != nil {
return err
}
x.mu.Lock()
defer x.mu.Unlock()
if _, ok := x.xattrs[name]; !ok {
return linuxerr.ENODATA
}
delete(x.xattrs, name)
return nil
}
// RawXattrs returns a copy of the underlying xattr map for serialization.
// No permission checks are performed.
func (x *SimpleExtendedAttributes) RawXattrs() map[string]string {
x.mu.RLock()
defer x.mu.RUnlock()
return maps.Clone(x.xattrs)
}
// SetRawXattrs sets the underlying xattr map from deserialized data.
// No permission checks are performed.
func (x *SimpleExtendedAttributes) SetRawXattrs(xattrs map[string]string) {
x.mu.Lock()
defer x.mu.Unlock()
x.xattrs = xattrs
}