Files
Tamir DubersteinandHanzo Dev 975aed380a checklocks: guard UDP binding and error state
Annotate the existing port, binding and last-error lock contracts,
including self-locking methods and the helpers called under e.mu.
Keep the receive-state synchronization fix separate.

Document synchronous callback ownership where the analyzer cannot
propagate captured locks, and the stored socket-option interface's
concrete lock requirements. Preserve the unlocked loopback send path.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-26 12:57:28 -04:00

73 lines
1.8 KiB
Go

// Copyright 2018 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package udp
import (
"context"
"time"
"gvisor.dev/gvisor/pkg/log"
"gvisor.dev/gvisor/pkg/tcpip"
"gvisor.dev/gvisor/pkg/tcpip/stack"
)
// saveReceivedAt is invoked by stateify.
func (p *udpPacket) saveReceivedAt() int64 {
return p.receivedAt.UnixNano()
}
// loadReceivedAt is invoked by stateify.
func (p *udpPacket) loadReceivedAt(_ context.Context, nsec int64) {
p.receivedAt = time.Unix(0, nsec)
}
// afterLoad is invoked by stateify.
func (e *endpoint) afterLoad(ctx context.Context) {
e.stack.RegisterRestoredEndpoint(e)
}
// beforeSave is invoked by stateify.
//
// +checklocksexclude:e.rcvMu
func (e *endpoint) beforeSave() {
e.freeze()
e.stack.RegisterResumableEndpoint(e)
}
// Restore implements stack.RestoredEndpoint.Restore.
//
// +checklocksexclude:e.rcvMu
// +checklocksexclude:e.mu
func (e *endpoint) Restore(s *stack.Stack) {
e.mu.Lock()
defer e.mu.Unlock()
if err := e.net.Resume(s); err != nil {
log.Warningf("Closing the UDP endpoint as it cannot be restored, err: %v", err)
e.closeLocked()
return
}
e.thaw()
e.ops.InitHandler(e, e.stack, tcpip.GetStackSendBufferLimits, tcpip.GetStackReceiveBufferLimits)
}
// Resume implements stack.ResumableEndpoint.Resume.
//
// +checklocksexclude:e.rcvMu
func (e *endpoint) Resume() {
e.thaw()
}