mirror of
https://github.com/hanzoai/visor.git
synced 2026-09-24 17:04:14 +00:00
The --directfs flag is global. When it is enabled, every gofer mount in the sandbox includes the "directfs" option, which causes the sentry to require a host FD for the mount root from the gofer's Mount RPC reply. Custom gofer servers that back virtual or network-backed filesystems cannot donate such an FD and currently have to disable --directfs globally, which loses the directfs performance benefit on every other mount. Add a new "directfs" key to the dev.gvisor.spec.mount.<NAME>.* and dev.gvisor.spec.rootfs.* annotations. When set to "off", the sentry suppresses the directfs mount option for that mount only. When unset or set to "default", the mount follows the global --directfs setting. This is an opt-out rather than a full per-mount override. The annotation does not enable directfs when --directfs is disabled because directfs requires some sandbox-wide settings (like seccomp filters) that can not be selectively enabled on containers. When global directfs is enabled and a fsgofer-handled mount or bind rootfs opts out, the stock gofer keeps LisaFS seccomp filters because that mount can still issue LisaFS RPCs. Fixes #13098
183 lines
4.8 KiB
Go
183 lines
4.8 KiB
Go
// Copyright 2021 The gVisor Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package boot
|
|
|
|
import (
|
|
"slices"
|
|
"testing"
|
|
|
|
specs "github.com/opencontainers/runtime-spec/specs-go"
|
|
"gvisor.dev/gvisor/runsc/config"
|
|
)
|
|
|
|
func TestGetMountAccessType(t *testing.T) {
|
|
const source = "foo"
|
|
for _, tst := range []struct {
|
|
name string
|
|
annotations map[string]string
|
|
want config.FileAccessType
|
|
}{
|
|
{
|
|
name: "container=exclusive",
|
|
annotations: map[string]string{
|
|
MountPrefix + "mount1.source": source,
|
|
MountPrefix + "mount1.type": "bind",
|
|
MountPrefix + "mount1.share": "container",
|
|
},
|
|
want: config.FileAccessExclusive,
|
|
},
|
|
{
|
|
name: "pod=shared",
|
|
annotations: map[string]string{
|
|
MountPrefix + "mount1.source": source,
|
|
MountPrefix + "mount1.type": "bind",
|
|
MountPrefix + "mount1.share": "pod",
|
|
},
|
|
want: config.FileAccessShared,
|
|
},
|
|
{
|
|
name: "share=shared",
|
|
annotations: map[string]string{
|
|
MountPrefix + "mount1.source": source,
|
|
MountPrefix + "mount1.type": "bind",
|
|
MountPrefix + "mount1.share": "shared",
|
|
},
|
|
want: config.FileAccessShared,
|
|
},
|
|
{
|
|
name: "default=shared",
|
|
annotations: map[string]string{
|
|
MountPrefix + "mount1.source": source + "mismatch",
|
|
MountPrefix + "mount1.type": "bind",
|
|
MountPrefix + "mount1.share": "container",
|
|
},
|
|
want: config.FileAccessShared,
|
|
},
|
|
{
|
|
name: "tmpfs+container=exclusive",
|
|
annotations: map[string]string{
|
|
MountPrefix + "mount1.source": source,
|
|
MountPrefix + "mount1.type": "tmpfs",
|
|
MountPrefix + "mount1.share": "container",
|
|
},
|
|
want: config.FileAccessExclusive,
|
|
},
|
|
{
|
|
name: "tmpfs+pod=exclusive",
|
|
annotations: map[string]string{
|
|
MountPrefix + "mount1.source": source,
|
|
MountPrefix + "mount1.type": "tmpfs",
|
|
MountPrefix + "mount1.share": "pod",
|
|
},
|
|
want: config.FileAccessExclusive,
|
|
},
|
|
} {
|
|
t.Run(tst.name, func(t *testing.T) {
|
|
spec := &specs.Spec{Annotations: tst.annotations}
|
|
podHints, err := NewPodMountHints(spec)
|
|
if err != nil {
|
|
t.Fatalf("newPodMountHints failed: %v", err)
|
|
}
|
|
conf := &config.Config{FileAccessMounts: config.FileAccessShared}
|
|
if got := getMountAccessType(conf, podHints.FindMount(source)); got != tst.want {
|
|
t.Errorf("getMountAccessType(), got: %v, want: %v", got, tst.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGoferMountDataDirectFS(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
name string
|
|
directFS bool
|
|
suppressDirectFS bool
|
|
wantEnabled bool
|
|
}{
|
|
{
|
|
name: "global on, not suppressed",
|
|
directFS: true,
|
|
wantEnabled: true,
|
|
},
|
|
{
|
|
name: "global on, suppressed",
|
|
directFS: true,
|
|
suppressDirectFS: true,
|
|
wantEnabled: false,
|
|
},
|
|
{
|
|
name: "global off, suppressed",
|
|
directFS: false,
|
|
suppressDirectFS: true,
|
|
wantEnabled: false,
|
|
},
|
|
{
|
|
name: "global off, not suppressed",
|
|
directFS: false,
|
|
wantEnabled: false,
|
|
},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
conf := &config.Config{DirectFS: tc.directFS, HostFifo: config.HostFifoOpen}
|
|
opts := goferMountData(7, config.FileAccessExclusive, conf, tc.suppressDirectFS)
|
|
gotEnabled := slices.Contains(opts, "directfs")
|
|
if gotEnabled != tc.wantEnabled {
|
|
t.Errorf("directfs option present = %t, want %t (opts=%v)", gotEnabled, tc.wantEnabled, opts)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCgroupfsCPUDefaults(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
name string
|
|
rawQuota int64
|
|
rawPeriod int64
|
|
wantQuota int64
|
|
wantPeriod int64
|
|
}{
|
|
{
|
|
name: "finite quota",
|
|
rawQuota: 150000,
|
|
rawPeriod: 100000,
|
|
wantQuota: 150000,
|
|
wantPeriod: 100000,
|
|
},
|
|
{
|
|
name: "unlimited quota keeps linux default",
|
|
rawQuota: -1,
|
|
rawPeriod: 100000,
|
|
wantQuota: -1,
|
|
wantPeriod: 100000,
|
|
},
|
|
{
|
|
name: "unset period falls back to linux default period",
|
|
rawQuota: -1,
|
|
rawPeriod: 0,
|
|
wantQuota: -1,
|
|
wantPeriod: 100000,
|
|
},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
defaults := cgroupfsCPUDefaults(tc.rawQuota, tc.rawPeriod)
|
|
if got := defaults["cpu.cfs_quota_us"]; got != tc.wantQuota {
|
|
t.Errorf("quota = %d, want %d", got, tc.wantQuota)
|
|
}
|
|
if got := defaults["cpu.cfs_period_us"]; got != tc.wantPeriod {
|
|
t.Errorf("period = %d, want %d", got, tc.wantPeriod)
|
|
}
|
|
})
|
|
}
|
|
}
|