mirror of
https://github.com/hanzoai/visor.git
synced 2026-09-24 17:04:14 +00:00
There were several issues with how runsc log and profile files were generated:
- Variables like "%ID" in flag-specified file paths were substituted by the
runsc shim in `pkg/shim/v1/runsccmd/utils.go:replaceID()`. Consequently, runsc
commands that did *not* invoke the shim missed this logic. Notably, Docker
invokes runsc via `runc shim`, so Docker use cases were missing this
feature.
- Variable support across flags was inconsistent. For example, the --debug-log
flag supported variables like ID, TIMESTAMP, COMMAND, and TEST, while
--profile-cpu supported ID, TIMESTAMP, YYYY, MM, etc.
- "%ID%" was intended to be substituted with the sandbox ID, but the shim was
incorrectly substituting it with the container ID.
- Variables specified via flag annotations were not substituted because the
shim did not process flag annotations.
- `specutils.ReadSpec() => ReadSpecFromFile() => fixSpec()` had the side effect
of modifying the `Config` object itself with annotation-based flags, rather
than just fixing the spec.
- Flag annotations were applied to Config for only 6 runsc commands (via
`fixSpec()`): boot, gofer, create, restore, run, and start. Other commands
did not see flags set via annotations.
- When using flag annotations to generate debug logs, only boot and gofer logs
were generated. This is because the debug file was created by the runsc CLI,
but flag annotations were processed later by the sub-command implementation.
Only `boot` and `gofer` had the correct configuration because `runsc create`
had already fixed its config by the time it invoked them.
- The parent directories of the configured file paths is created via
os.MkdirAll() only for a subset of the flags. This is inconsistent.
This change fixes all above-mentioned issues:
- Moves all variable substitution logic from the shim to the runsc CLI.
- Centralizes the logic for opening and formatting paths for log and profile
files within `specutils`.
- Introduces `specutils.LogFileOpts` to standardize variable substitution in
log and profile paths.
- Refactors profile file handling to use `DonateProfileFDs`, leveraging
`LogFileOpts` and `DonateLogFile` for consistent path substitution.
- Extracts `specutils.FixConfig()` from `specutils.fixSpec()` to only call it
when necessary. This prevents side effects; `fixSpec()` now only fixes the OCI
spec, and `FixConfig()` only fixes `config.Config`. The config is now fixed
uniformly for all commands via the runsc CLI.
- Standarizes the variables supported across all file path flags:
- `%TIMESTAMP%`: Replaced with the start-up time of the command with format
`<yyyymmdd-hhmmss.uuuuuu>`.
- `%COMMAND%`: Replaced with the command name.
- `%TEST%`: Replaced with the value of the environment variable named
`-TESTONLY-test-name-env`. The value is fetched from container spec.
- `%ID%`: Replaced with the sandbox ID.
- `%CID%`: Replaced with the container ID.
- Open all log files consistently with mode 0644 and create intermediate
directories with mode 0755.
To facilitate these improvements, the `subcommands.Command` interface has been
extended via `util.SubCommand` to include `FetchSpec(conf, flatSet)`.
- All runsc sub-commands must implement this interface.
- `FetchSpec` extracts the container ID from the command line arguments and
ensures the OCI spec is loaded (either from the bundle or container) for
configuration processing.
- Caching is added to all sub-commands to reuse the work done by `FetchSpec`
during `Execute()`.
Note: `runsc tar` and `runsc trace` implement `FetchSpec` as a no-op. These
commands have nested sub-commands that make spec pre-fetching complex. Variable
substitution is currently not supported for their file path flags.
PiperOrigin-RevId: 877758843
409 lines
12 KiB
Go
409 lines
12 KiB
Go
// Copyright 2018 The gVisor Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"os/signal"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/google/subcommands"
|
|
specs "github.com/opencontainers/runtime-spec/specs-go"
|
|
"golang.org/x/sys/unix"
|
|
"gvisor.dev/gvisor/pkg/log"
|
|
"gvisor.dev/gvisor/pkg/sentry/control"
|
|
"gvisor.dev/gvisor/runsc/cmd/util"
|
|
"gvisor.dev/gvisor/runsc/config"
|
|
"gvisor.dev/gvisor/runsc/container"
|
|
"gvisor.dev/gvisor/runsc/flag"
|
|
)
|
|
|
|
// Debug implements subcommands.Command for the "debug" command.
|
|
type Debug struct {
|
|
containerLoader
|
|
pid int
|
|
stacks bool
|
|
signal int
|
|
profileBlock string
|
|
profileCPU string
|
|
profileHeap string
|
|
profileMutex string
|
|
trace string
|
|
strace string
|
|
logLevel string
|
|
logPackets string
|
|
delay time.Duration
|
|
duration time.Duration
|
|
ps bool
|
|
mount string
|
|
}
|
|
|
|
// Name implements subcommands.Command.
|
|
func (*Debug) Name() string {
|
|
return "debug"
|
|
}
|
|
|
|
// Synopsis implements subcommands.Command.
|
|
func (*Debug) Synopsis() string {
|
|
return "shows a variety of debug information"
|
|
}
|
|
|
|
// Usage implements subcommands.Command.
|
|
func (*Debug) Usage() string {
|
|
return "debug [flags] <container id>\n"
|
|
}
|
|
|
|
// SetFlags implements subcommands.Command.
|
|
func (d *Debug) SetFlags(f *flag.FlagSet) {
|
|
f.IntVar(&d.pid, "pid", 0, "sandbox process ID. Container ID is not necessary if this is set")
|
|
f.BoolVar(&d.stacks, "stacks", false, "if true, dumps all sandbox stacks to the log")
|
|
f.StringVar(&d.profileBlock, "profile-block", "", "writes block profile to the given file.")
|
|
f.StringVar(&d.profileCPU, "profile-cpu", "", "writes CPU profile to the given file.")
|
|
f.StringVar(&d.profileHeap, "profile-heap", "", "writes heap profile to the given file.")
|
|
f.StringVar(&d.profileMutex, "profile-mutex", "", "writes mutex profile to the given file.")
|
|
f.DurationVar(&d.delay, "delay", 0, "amount of time to delay for collecting heap and goroutine profiles.")
|
|
f.DurationVar(&d.duration, "duration", time.Minute, "amount of time to wait for CPU and trace profiles.")
|
|
f.StringVar(&d.trace, "trace", "", "writes an execution trace to the given file.")
|
|
f.IntVar(&d.signal, "signal", -1, "sends signal to the sandbox")
|
|
f.StringVar(&d.strace, "strace", "", `A comma separated list of syscalls to trace. "all" enables all traces, "off" disables all.`)
|
|
f.StringVar(&d.logLevel, "log-level", "", "The log level to set: warning (0), info (1), or debug (2).")
|
|
f.StringVar(&d.logPackets, "log-packets", "", "A boolean value to enable or disable packet logging: true or false.")
|
|
f.BoolVar(&d.ps, "ps", false, "lists processes")
|
|
f.StringVar(&d.mount, "mount", "", "Mount a filesystem (-mount fstype:source:destination).")
|
|
}
|
|
|
|
// FetchSpec implements util.SubCommand.FetchSpec.
|
|
func (d *Debug) FetchSpec(conf *config.Config, f *flag.FlagSet) (string, *specs.Spec, error) {
|
|
c, err := d.loadContainer(conf, f)
|
|
if err != nil {
|
|
return "", nil, fmt.Errorf("loading container: %w", err)
|
|
}
|
|
return c.ID, c.Spec, nil
|
|
}
|
|
|
|
func (d *Debug) loadContainer(conf *config.Config, f *flag.FlagSet) (*container.Container, error) {
|
|
if d.cachedContainer != nil {
|
|
return d.cachedContainer, nil
|
|
}
|
|
if d.pid == 0 {
|
|
// No pid, container ID must be provided as the first argument.
|
|
if f.NArg() != 1 {
|
|
f.Usage()
|
|
return nil, fmt.Errorf("container ID should be provided when -pid is not set")
|
|
}
|
|
return d.containerLoader.loadContainer(conf, f, container.LoadOpts{SkipCheck: true})
|
|
}
|
|
// Fetch the container associated with the PID.
|
|
if f.NArg() != 0 {
|
|
f.Usage()
|
|
return nil, fmt.Errorf("container ID should not be provided when -pid is set")
|
|
}
|
|
// Go over all sandboxes and find the one that matches PID.
|
|
ids, err := container.ListSandboxes(conf.RootDir)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("listing containers: %v", err)
|
|
}
|
|
for _, id := range ids {
|
|
candidate, err := container.Load(conf.RootDir, id, container.LoadOpts{Exact: true, SkipCheck: true})
|
|
if err != nil {
|
|
log.Warningf("Skipping container %q: %v", id, err)
|
|
continue
|
|
}
|
|
if candidate.SandboxPid() == d.pid {
|
|
d.cachedContainer = candidate
|
|
return d.cachedContainer, nil
|
|
}
|
|
}
|
|
return nil, fmt.Errorf("container with PID %d not found", d.pid)
|
|
}
|
|
|
|
// Execute implements subcommands.Command.Execute.
|
|
func (d *Debug) Execute(_ context.Context, f *flag.FlagSet, args ...any) subcommands.ExitStatus {
|
|
conf := args[0].(*config.Config)
|
|
|
|
if conf.ProfileBlock != "" || conf.ProfileCPU != "" || conf.ProfileHeap != "" || conf.ProfileMutex != "" {
|
|
return util.Errorf("global -profile-{block,cpu,heap,mutex} flags have no effect on runsc debug. Pass runsc debug -profile-{block,cpu,heap,mutex} instead")
|
|
}
|
|
if conf.TraceFile != "" {
|
|
return util.Errorf("global -trace flag has no effect on runsc debug. Pass runsc debug -trace instead")
|
|
}
|
|
|
|
c, err := d.loadContainer(conf, f)
|
|
if err != nil {
|
|
return util.Errorf("loading container: %v", err)
|
|
}
|
|
|
|
if !c.IsSandboxRunning() {
|
|
return util.Errorf("container sandbox is not running")
|
|
}
|
|
util.Infof("Found sandbox %q, PID: %d", c.Sandbox.ID, c.Sandbox.Getpid())
|
|
|
|
// Perform synchronous actions.
|
|
if d.signal > 0 {
|
|
pid := c.Sandbox.Getpid()
|
|
util.Infof("Sending signal %d to process: %d", d.signal, pid)
|
|
if err := unix.Kill(pid, unix.Signal(d.signal)); err != nil {
|
|
return util.Errorf("failed to send signal %d to process %d", d.signal, pid)
|
|
}
|
|
}
|
|
if d.stacks {
|
|
util.Infof("Retrieving sandbox stacks")
|
|
stacks, err := c.Sandbox.Stacks()
|
|
if err != nil {
|
|
return util.Errorf("retrieving stacks: %v", err)
|
|
}
|
|
util.Infof(" *** Stack dump ***\n%s", stacks)
|
|
}
|
|
if d.strace != "" || len(d.logLevel) != 0 || len(d.logPackets) != 0 {
|
|
args := control.LoggingArgs{}
|
|
switch strings.ToLower(d.strace) {
|
|
case "":
|
|
// strace not set, nothing to do here.
|
|
|
|
case "off":
|
|
util.Infof("Disabling strace")
|
|
args.SetStrace = true
|
|
|
|
case "all":
|
|
util.Infof("Enabling all straces")
|
|
args.SetStrace = true
|
|
args.EnableStrace = true
|
|
|
|
default:
|
|
util.Infof("Enabling strace for syscalls: %s", d.strace)
|
|
args.SetStrace = true
|
|
args.EnableStrace = true
|
|
args.StraceAllowlist = strings.Split(d.strace, ",")
|
|
}
|
|
|
|
if len(d.logLevel) != 0 {
|
|
args.SetLevel = true
|
|
switch strings.ToLower(d.logLevel) {
|
|
case "warning", "0":
|
|
args.Level = log.Warning
|
|
case "info", "1":
|
|
args.Level = log.Info
|
|
case "debug", "2":
|
|
args.Level = log.Debug
|
|
default:
|
|
return util.Errorf("invalid log level %q", d.logLevel)
|
|
}
|
|
util.Infof("Setting log level %v", args.Level)
|
|
}
|
|
|
|
if len(d.logPackets) != 0 {
|
|
args.SetLogPackets = true
|
|
lp, err := strconv.ParseBool(d.logPackets)
|
|
if err != nil {
|
|
return util.Errorf("invalid value for log_packets %q", d.logPackets)
|
|
}
|
|
args.LogPackets = lp
|
|
if args.LogPackets {
|
|
util.Infof("Enabling packet logging")
|
|
} else {
|
|
util.Infof("Disabling packet logging")
|
|
}
|
|
}
|
|
|
|
if err := c.Sandbox.ChangeLogging(args); err != nil {
|
|
return util.Errorf("%s", err.Error())
|
|
}
|
|
util.Infof("Logging options changed")
|
|
}
|
|
if d.ps {
|
|
util.Infof("Retrieving process list")
|
|
pList, err := c.Processes()
|
|
if err != nil {
|
|
util.Fatalf("getting processes for container: %v", err)
|
|
}
|
|
o, err := control.ProcessListToJSON(pList)
|
|
if err != nil {
|
|
util.Fatalf("generating JSON: %v", err)
|
|
}
|
|
util.Infof("%s", o)
|
|
}
|
|
if d.mount != "" {
|
|
opts := strings.Split(d.mount, ":")
|
|
if len(opts) != 3 {
|
|
util.Fatalf("Mount failed: invalid option: %v", d.mount)
|
|
}
|
|
fstype := opts[0]
|
|
src := opts[1]
|
|
dest := opts[2]
|
|
if err := c.Sandbox.Mount(c.ID, fstype, src, dest); err != nil {
|
|
util.Fatalf("%s", err.Error())
|
|
}
|
|
}
|
|
|
|
// Open profiling files.
|
|
var (
|
|
blockFile *os.File
|
|
cpuFile *os.File
|
|
heapFile *os.File
|
|
mutexFile *os.File
|
|
traceFile *os.File
|
|
)
|
|
if d.profileBlock != "" {
|
|
f, err := os.OpenFile(d.profileBlock, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
|
|
if err != nil {
|
|
return util.Errorf("error opening blocking profile output: %v", err)
|
|
}
|
|
defer f.Close()
|
|
blockFile = f
|
|
}
|
|
if d.profileCPU != "" {
|
|
f, err := os.OpenFile(d.profileCPU, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
|
|
if err != nil {
|
|
return util.Errorf("error opening cpu profile output: %v", err)
|
|
}
|
|
defer f.Close()
|
|
cpuFile = f
|
|
}
|
|
if d.profileHeap != "" {
|
|
f, err := os.OpenFile(d.profileHeap, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
|
|
if err != nil {
|
|
return util.Errorf("error opening heap profile output: %v", err)
|
|
}
|
|
defer f.Close()
|
|
heapFile = f
|
|
}
|
|
if d.profileMutex != "" {
|
|
f, err := os.OpenFile(d.profileMutex, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
|
|
if err != nil {
|
|
return util.Errorf("error opening mutex profile output: %v", err)
|
|
}
|
|
defer f.Close()
|
|
mutexFile = f
|
|
}
|
|
if d.trace != "" {
|
|
f, err := os.OpenFile(d.trace, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
|
|
if err != nil {
|
|
return util.Errorf("error opening trace profile output: %v", err)
|
|
}
|
|
traceFile = f
|
|
}
|
|
|
|
// Collect profiles.
|
|
var (
|
|
wg sync.WaitGroup
|
|
blockErr error
|
|
cpuErr error
|
|
heapErr error
|
|
mutexErr error
|
|
traceErr error
|
|
)
|
|
if blockFile != nil {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
blockErr = c.Sandbox.BlockProfile(blockFile, d.duration)
|
|
}()
|
|
}
|
|
if cpuFile != nil {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
cpuErr = c.Sandbox.CPUProfile(cpuFile, d.duration)
|
|
}()
|
|
}
|
|
if heapFile != nil {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
heapErr = c.Sandbox.HeapProfile(heapFile, d.delay)
|
|
}()
|
|
}
|
|
if mutexFile != nil {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
mutexErr = c.Sandbox.MutexProfile(mutexFile, d.duration)
|
|
}()
|
|
}
|
|
if traceFile != nil {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
traceErr = c.Sandbox.Trace(traceFile, d.duration)
|
|
}()
|
|
}
|
|
|
|
// Before sleeping, allow us to catch signals and try to exit
|
|
// gracefully before just exiting. If we can't wait for wg, then
|
|
// we will not be able to read the errors below safely.
|
|
readyChan := make(chan struct{})
|
|
go func() {
|
|
defer close(readyChan)
|
|
wg.Wait()
|
|
}()
|
|
signals := make(chan os.Signal, 1)
|
|
signal.Notify(signals, unix.SIGTERM, unix.SIGINT)
|
|
select {
|
|
case <-readyChan:
|
|
break // Safe to proceed.
|
|
case <-signals:
|
|
util.Infof("caught signal, waiting at most one more second.")
|
|
select {
|
|
case <-signals:
|
|
util.Infof("caught second signal, exiting immediately.")
|
|
os.Exit(1) // Not finished.
|
|
case <-time.After(time.Second):
|
|
util.Infof("timeout, exiting.")
|
|
os.Exit(1) // Not finished.
|
|
case <-readyChan:
|
|
break // Safe to proceed.
|
|
}
|
|
}
|
|
|
|
// Collect all errors.
|
|
errorCount := 0
|
|
if blockErr != nil {
|
|
errorCount++
|
|
util.Infof("error collecting block profile: %v", blockErr)
|
|
os.Remove(blockFile.Name())
|
|
}
|
|
if cpuErr != nil {
|
|
errorCount++
|
|
util.Infof("error collecting cpu profile: %v", cpuErr)
|
|
os.Remove(cpuFile.Name())
|
|
}
|
|
if heapErr != nil {
|
|
errorCount++
|
|
util.Infof("error collecting heap profile: %v", heapErr)
|
|
os.Remove(heapFile.Name())
|
|
}
|
|
if mutexErr != nil {
|
|
errorCount++
|
|
util.Infof("error collecting mutex profile: %v", mutexErr)
|
|
os.Remove(mutexFile.Name())
|
|
}
|
|
if traceErr != nil {
|
|
errorCount++
|
|
util.Infof("error collecting trace profile: %v", traceErr)
|
|
os.Remove(traceFile.Name())
|
|
}
|
|
|
|
if errorCount > 0 {
|
|
return subcommands.ExitFailure
|
|
}
|
|
|
|
return subcommands.ExitSuccess
|
|
}
|