mirror of
https://github.com/hanzoai/visor.git
synced 2026-09-24 17:04:14 +00:00
There were several issues with how runsc log and profile files were generated:
- Variables like "%ID" in flag-specified file paths were substituted by the
runsc shim in `pkg/shim/v1/runsccmd/utils.go:replaceID()`. Consequently, runsc
commands that did *not* invoke the shim missed this logic. Notably, Docker
invokes runsc via `runc shim`, so Docker use cases were missing this
feature.
- Variable support across flags was inconsistent. For example, the --debug-log
flag supported variables like ID, TIMESTAMP, COMMAND, and TEST, while
--profile-cpu supported ID, TIMESTAMP, YYYY, MM, etc.
- "%ID%" was intended to be substituted with the sandbox ID, but the shim was
incorrectly substituting it with the container ID.
- Variables specified via flag annotations were not substituted because the
shim did not process flag annotations.
- `specutils.ReadSpec() => ReadSpecFromFile() => fixSpec()` had the side effect
of modifying the `Config` object itself with annotation-based flags, rather
than just fixing the spec.
- Flag annotations were applied to Config for only 6 runsc commands (via
`fixSpec()`): boot, gofer, create, restore, run, and start. Other commands
did not see flags set via annotations.
- When using flag annotations to generate debug logs, only boot and gofer logs
were generated. This is because the debug file was created by the runsc CLI,
but flag annotations were processed later by the sub-command implementation.
Only `boot` and `gofer` had the correct configuration because `runsc create`
had already fixed its config by the time it invoked them.
- The parent directories of the configured file paths is created via
os.MkdirAll() only for a subset of the flags. This is inconsistent.
This change fixes all above-mentioned issues:
- Moves all variable substitution logic from the shim to the runsc CLI.
- Centralizes the logic for opening and formatting paths for log and profile
files within `specutils`.
- Introduces `specutils.LogFileOpts` to standardize variable substitution in
log and profile paths.
- Refactors profile file handling to use `DonateProfileFDs`, leveraging
`LogFileOpts` and `DonateLogFile` for consistent path substitution.
- Extracts `specutils.FixConfig()` from `specutils.fixSpec()` to only call it
when necessary. This prevents side effects; `fixSpec()` now only fixes the OCI
spec, and `FixConfig()` only fixes `config.Config`. The config is now fixed
uniformly for all commands via the runsc CLI.
- Standarizes the variables supported across all file path flags:
- `%TIMESTAMP%`: Replaced with the start-up time of the command with format
`<yyyymmdd-hhmmss.uuuuuu>`.
- `%COMMAND%`: Replaced with the command name.
- `%TEST%`: Replaced with the value of the environment variable named
`-TESTONLY-test-name-env`. The value is fetched from container spec.
- `%ID%`: Replaced with the sandbox ID.
- `%CID%`: Replaced with the container ID.
- Open all log files consistently with mode 0644 and create intermediate
directories with mode 0755.
To facilitate these improvements, the `subcommands.Command` interface has been
extended via `util.SubCommand` to include `FetchSpec(conf, flatSet)`.
- All runsc sub-commands must implement this interface.
- `FetchSpec` extracts the container ID from the command line arguments and
ensures the OCI spec is loaded (either from the bundle or container) for
configuration processing.
- Caching is added to all sub-commands to reuse the work done by `FetchSpec`
during `Execute()`.
Note: `runsc tar` and `runsc trace` implement `FetchSpec` as a no-op. These
commands have nested sub-commands that make spec pre-fetching complex. Variable
substitution is currently not supported for their file path flags.
PiperOrigin-RevId: 877758843
292 lines
7.9 KiB
Go
292 lines
7.9 KiB
Go
// Copyright 2022 The gVisor Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"strconv"
|
|
|
|
"github.com/google/subcommands"
|
|
specs "github.com/opencontainers/runtime-spec/specs-go"
|
|
"gvisor.dev/gvisor/runsc/cmd/util"
|
|
"gvisor.dev/gvisor/runsc/config"
|
|
"gvisor.dev/gvisor/runsc/container"
|
|
"gvisor.dev/gvisor/runsc/flag"
|
|
)
|
|
|
|
func i64Ptr(i int64) *int64 { return &i }
|
|
func u64Ptr(i uint64) *uint64 { return &i }
|
|
func u16Ptr(i uint16) *uint16 { return &i }
|
|
func boolPtr(b bool) *bool { return &b }
|
|
|
|
// Update implements subcommands.Command for the "update" command.
|
|
type Update struct {
|
|
containerLoader
|
|
resources string
|
|
|
|
blkioWeight int
|
|
|
|
cpuBurst string
|
|
cpuIdle string
|
|
cpuPeriod string
|
|
cpuQuota string
|
|
cpuRtPeriod string
|
|
cpuRtRuntime string
|
|
cpuShares string
|
|
cpusetCpus string
|
|
cpusetMems string
|
|
|
|
memory string
|
|
memoryReservation string
|
|
memorySwap string
|
|
|
|
pidsLimit int64
|
|
|
|
l3CacheSchema string
|
|
memBwSchema string
|
|
}
|
|
|
|
// Name implements subcommands.Command.Name.
|
|
func (*Update) Name() string {
|
|
return "update"
|
|
}
|
|
|
|
// Synopsis implements subcommands.Command.Synopsis.
|
|
func (*Update) Synopsis() string {
|
|
return "update container resource constraints"
|
|
}
|
|
|
|
// Usage implements subcommands.Command.Usage.
|
|
func (*Update) Usage() string {
|
|
return `update [flags] <container id> - update container resource constraints
|
|
`
|
|
}
|
|
|
|
// SetFlags implements subcommands.Command.SetFlags.
|
|
func (u *Update) SetFlags(f *flag.FlagSet) {
|
|
f.StringVar(&u.resources, "resources", "", `path to the file containing the resources to update or '-' to read from the standard input.
|
|
|
|
The default value means resources will be read from the remaining flags.
|
|
|
|
The accepted format is as follows (unchanged values can be omitted):
|
|
|
|
{
|
|
"memory": {
|
|
"limit": 0,
|
|
"reservation": 0,
|
|
"swap": 0,
|
|
"checkBeforeUpdate": true
|
|
},
|
|
"cpu": {
|
|
"shares": 0,
|
|
"quota": 0,
|
|
"burst": 0,
|
|
"period": 0,
|
|
"realtimeRuntime": 0,
|
|
"realtimePeriod": 0,
|
|
"cpus": "",
|
|
"mems": "",
|
|
"idle": 0
|
|
},
|
|
"blockIO": {
|
|
"weight": 0
|
|
}
|
|
}
|
|
|
|
Note: if data is to be read from a file or the standard input, all
|
|
other options are ignored.
|
|
`)
|
|
|
|
f.IntVar(&u.blkioWeight, "blkio-weight", 0, "Specifies per cgroup weight, range is from 10 to 1000")
|
|
|
|
f.StringVar(&u.cpuBurst, "cpu-burst", "", "CPU CFS hardcap burst limit (in usecs). Allowed accumulated cpu time additionally for burst a given period")
|
|
f.StringVar(&u.cpuIdle, "cpu-idle", "", "set cgroup SCHED_IDLE or not, 0: default behavior, 1: SCHED_IDLE")
|
|
f.StringVar(&u.cpuPeriod, "cpu-period", "", "CPU CFS period to be used for hardcapping (in usecs). 0 to use system default")
|
|
f.StringVar(&u.cpuQuota, "cpu-quota", "", "CPU CFS hardcap limit (in usecs). Allowed cpu time in a given period")
|
|
f.StringVar(&u.cpuRtPeriod, "cpu-rt-period", "", "CPU realtime period to be used for hardcapping (in usecs). 0 to use system default")
|
|
f.StringVar(&u.cpuRtRuntime, "cpu-rt-runtime", "", "CPU realtime hardcap limit (in usecs). Allowed cpu time in a given period")
|
|
f.StringVar(&u.cpuShares, "cpu-share", "", "CPU shares (relative weight vs. other containers)")
|
|
f.StringVar(&u.cpusetCpus, "cpuset-cpus", "", "CPU(s) to use")
|
|
f.StringVar(&u.cpusetMems, "cpuset-mems", "", "Memory node(s) to use")
|
|
|
|
f.StringVar(&u.memory, "memory", "", "Memory limit (in bytes)")
|
|
f.StringVar(&u.memoryReservation, "memory-reservation", "", "Memory reservation or soft_limit (in bytes)")
|
|
f.StringVar(&u.memorySwap, "memory-swap", "", "Total memory usage (memory + swap); set '-1' to enable unlimited swap")
|
|
|
|
f.Int64Var(&u.pidsLimit, "pids-limit", 0, "Maximum number of pids allowed in the container")
|
|
|
|
f.StringVar(&u.l3CacheSchema, "l3-cache-schema", "", "The string of Intel RDT/CAT L3 cache schema")
|
|
f.StringVar(&u.memBwSchema, "mem-bw-schema", "", "The string of Intel RDT/MBA memory bandwidth schema")
|
|
}
|
|
|
|
// FetchSpec implements util.SubCommand.FetchSpec.
|
|
func (u *Update) FetchSpec(conf *config.Config, f *flag.FlagSet) (string, *specs.Spec, error) {
|
|
c, err := u.loadContainer(conf, f, container.LoadOpts{})
|
|
if err != nil {
|
|
return "", nil, fmt.Errorf("loading container: %w", err)
|
|
}
|
|
return c.ID, c.Spec, nil
|
|
}
|
|
|
|
// Execute implements subcommands.Command.Execute.
|
|
func (u *Update) Execute(_ context.Context, f *flag.FlagSet, args ...any) subcommands.ExitStatus {
|
|
if f.NArg() != 1 {
|
|
f.Usage()
|
|
return subcommands.ExitUsageError
|
|
}
|
|
|
|
conf := args[0].(*config.Config)
|
|
|
|
c, err := u.loadContainer(conf, f, container.LoadOpts{})
|
|
if err != nil {
|
|
util.Fatalf("loading container %v", err)
|
|
}
|
|
|
|
r := specs.LinuxResources{
|
|
Memory: &specs.LinuxMemory{
|
|
CheckBeforeUpdate: boolPtr(false),
|
|
},
|
|
CPU: &specs.LinuxCPU{},
|
|
BlockIO: &specs.LinuxBlockIO{},
|
|
Pids: nil,
|
|
}
|
|
if in := u.resources; in != "" {
|
|
var (
|
|
f *os.File
|
|
err error
|
|
)
|
|
switch in {
|
|
case "-":
|
|
f = os.Stdin
|
|
default:
|
|
if f, err = os.Open(in); err != nil {
|
|
return util.Errorf("opening %q: %v", in, err)
|
|
}
|
|
defer f.Close()
|
|
}
|
|
if err := json.NewDecoder(f).Decode(&r); err != nil {
|
|
return util.Errorf("decoding %q: %v", in, err)
|
|
}
|
|
} else {
|
|
if u.l3CacheSchema != "" || u.memBwSchema != "" {
|
|
return util.Errorf("Intel RDT support is not yet implemented")
|
|
}
|
|
|
|
if u.blkioWeight != 0 {
|
|
r.BlockIO.Weight = u16Ptr(uint16(u.blkioWeight))
|
|
}
|
|
|
|
r.CPU.Cpus = u.cpusetCpus
|
|
r.CPU.Mems = u.cpusetMems
|
|
|
|
for _, pair := range []struct {
|
|
strval string
|
|
dest **uint64
|
|
}{
|
|
{u.cpuBurst, &r.CPU.Burst},
|
|
{u.cpuPeriod, &r.CPU.Period},
|
|
{u.cpuRtPeriod, &r.CPU.RealtimePeriod},
|
|
{u.cpuShares, &r.CPU.Shares},
|
|
} {
|
|
if pair.strval == "" {
|
|
continue
|
|
}
|
|
v, err := strconv.ParseUint(pair.strval, 10, 64)
|
|
if err != nil {
|
|
return util.Errorf("invalid value for %s: %v", pair.strval, err)
|
|
}
|
|
*pair.dest = &v
|
|
}
|
|
|
|
for _, pair := range []struct {
|
|
strval string
|
|
dest **int64
|
|
}{
|
|
{u.cpuIdle, &r.CPU.Idle},
|
|
{u.cpuQuota, &r.CPU.Quota},
|
|
{u.cpuRtRuntime, &r.CPU.RealtimeRuntime},
|
|
{u.memory, &r.Memory.Limit},
|
|
{u.memoryReservation, &r.Memory.Reservation},
|
|
{u.memorySwap, &r.Memory.Swap},
|
|
} {
|
|
if pair.strval == "" {
|
|
continue
|
|
}
|
|
v, err := strconv.ParseInt(pair.strval, 10, 64)
|
|
if err != nil {
|
|
return util.Errorf("invalid value for %s: %v", pair.strval, err)
|
|
}
|
|
*pair.dest = &v
|
|
}
|
|
|
|
if u.pidsLimit > 0 {
|
|
r.Pids = &specs.LinuxPids{Limit: u.pidsLimit}
|
|
}
|
|
}
|
|
|
|
prev := c.Spec.Linux.Resources
|
|
// Retain existing values if not set
|
|
if prev.CPU != nil {
|
|
if r.CPU.Burst == nil {
|
|
r.CPU.Burst = prev.CPU.Burst
|
|
}
|
|
if r.CPU.Idle == nil {
|
|
r.CPU.Idle = prev.CPU.Idle
|
|
}
|
|
if r.CPU.Period == nil {
|
|
r.CPU.Period = prev.CPU.Period
|
|
}
|
|
if r.CPU.Quota == nil {
|
|
r.CPU.Quota = prev.CPU.Quota
|
|
}
|
|
if r.CPU.RealtimePeriod == nil {
|
|
r.CPU.RealtimePeriod = prev.CPU.RealtimePeriod
|
|
}
|
|
if r.CPU.RealtimeRuntime == nil {
|
|
r.CPU.RealtimeRuntime = prev.CPU.RealtimeRuntime
|
|
}
|
|
if r.CPU.Shares == nil {
|
|
r.CPU.Shares = prev.CPU.Shares
|
|
}
|
|
}
|
|
|
|
if prev.Memory != nil {
|
|
if r.Memory.Limit == nil {
|
|
r.Memory.Limit = prev.Memory.Limit
|
|
}
|
|
if r.Memory.Reservation == nil {
|
|
r.Memory.Reservation = prev.Memory.Reservation
|
|
}
|
|
if r.Memory.Swap == nil {
|
|
r.Memory.Swap = prev.Memory.Swap
|
|
}
|
|
}
|
|
|
|
if prev.BlockIO != nil {
|
|
if r.BlockIO.Weight == nil {
|
|
r.BlockIO.Weight = prev.BlockIO.Weight
|
|
}
|
|
}
|
|
|
|
if err := c.Update(&r); err != nil {
|
|
return util.Errorf("setting resources: %v", err)
|
|
}
|
|
|
|
return subcommands.ExitSuccess
|
|
}
|