Files
Tamir Duberstein 4a4b76e37e checklocks: move checklocksalias to type
Repurpose checklocksalias as a type-level annotation so alias
relationships are declared once per type instead of per call. Update
tcp/ipv4 annotations accordingly and drop per-call workarounds.

Enhance checklocksfail to allow substring matching so that robust tests
for checklocksalias are possible.
2026-01-12 13:29:29 -05:00

1039 lines
33 KiB
Go

// Copyright 2020 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package checklocks
import (
"encoding/gob"
"fmt"
"go/ast"
"go/token"
"go/types"
"regexp"
"slices"
"strings"
"golang.org/x/tools/go/analysis/passes/buildssa"
"golang.org/x/tools/go/ssa"
)
// atomicAlignment is saved per type.
//
// This represents the alignment required for the type, which may
// be implied and imposed by other types within the aggregate type.
type atomicAlignment int
// AFact implements analysis.Fact.AFact.
func (*atomicAlignment) AFact() {}
// atomicDisposition is saved per field.
//
// This represents how the field must be accessed. It must either
// be non-atomic (default), atomic or ignored.
type atomicDisposition int
const (
atomicDisallow atomicDisposition = iota
atomicIgnore
atomicRequired
)
// fieldEntry is a single field type.
type fieldEntry interface {
// synthesize produces a string that is compatible with valueAndObject,
// along with the same object that should be produced in that case.
//
// Note that it is called synthesize because this is produced only the
// type information, and not with any ssa.Value objects.
synthesize(s string, typ types.Type) (string, types.Object)
}
// fieldStruct is a non-pointer struct element.
type fieldStruct struct {
Field int
}
// synthesize implements fieldEntry.synthesize.
func (f *fieldStruct) synthesize(s string, typ types.Type) (string, types.Object) {
field, ok := findField(typ, f.Field)
if !ok {
// Should not happen as long as fieldList construction is correct.
panic(fmt.Sprintf("unable to resolve field %d in %s", f.Field, typ.String()))
}
return fmt.Sprintf("&(%s.%s)", s, field.Name()), field
}
// fieldStructPtr is a pointer struct element.
type fieldStructPtr struct {
Field int
}
// synthesize implements fieldEntry.synthesize.
func (f *fieldStructPtr) synthesize(s string, typ types.Type) (string, types.Object) {
field, ok := findField(typ, f.Field)
if !ok {
// See above, this should not happen.
panic(fmt.Sprintf("unable to resolve ptr field %d in %s", f.Field, typ.String()))
}
return fmt.Sprintf("*(&(%s.%s))", s, field.Name()), field
}
func fieldEntryEqual(left, right fieldEntry) bool {
if left, ok := left.(*fieldStruct); ok {
if right, ok := right.(*fieldStruct); ok {
return left.Field == right.Field
}
}
if left, ok := left.(*fieldStructPtr); ok {
if right, ok := right.(*fieldStructPtr); ok {
return left.Field == right.Field
}
}
return false
}
// fieldList is a simple list of fields, used in two types below.
type fieldList []fieldEntry
// resolvedValue is an ssa.Value with additional fields.
//
// This can be resolved to a string as part of a lock state.
type resolvedValue struct {
value ssa.Value
fieldList fieldList
}
// makeResolvedValue makes a new resolvedValue.
func makeResolvedValue(v ssa.Value, fl fieldList) resolvedValue {
return resolvedValue{
value: v,
fieldList: fl,
}
}
// valid indicates whether this is a valid resolvedValue.
func (rv *resolvedValue) valid() bool {
return rv.value != nil
}
// valueAndObject returns a string and object.
//
// This uses the lockState valueAndObject in order to produce a string and
// object for the base ssa.Value, then synthesizes a string representation
// based on the fieldList.
func (rv *resolvedValue) valueAndObject(ls *lockState) (string, types.Object) {
// N.B. obj.Type() and typ should be equal, but a check is omitted
// since, 1) we automatically chase through pointers during field
// resolution, and 2) obj may be nil if there is no source object.
s, obj := ls.valueAndObject(rv.value)
typ := rv.value.Type()
for _, entry := range rv.fieldList {
s, obj = entry.synthesize(s, typ)
typ = obj.Type()
}
return s, obj
}
// fieldGuardResolver details a guard for a field.
type fieldGuardResolver interface {
// resolveField is used to resolve a guard during a field access. The
// parent structure is available, as well as the current lock state.
resolveField(pc *passContext, ls *lockState, parent ssa.Value) resolvedValue
}
// functionGuardResolver details a guard for a function.
type functionGuardResolver interface {
// resolveStatic is used to resolve a guard during static analysis,
// e.g. based on static annotations applied to a method. The function's
// ssa object is available, as well as the return value.
resolveStatic(pc *passContext, ls *lockState, fn *ssa.Function, rv any) resolvedValue
// resolveCall is used to resolve a guard during a call. The ssa
// return value is available from the instruction context where the
// call occurs, but the target's ssa representation is not available.
resolveCall(pc *passContext, ls *lockState, args []ssa.Value, rv ssa.Value) resolvedValue
}
// lockGuardFacts contains guard information.
type lockGuardFacts struct {
// GuardedBy is the set of locks that are guarding this field. The key
// is the original annotation value, and the field list is the object
// traversal path.
GuardedBy map[string]fieldGuardResolver
// AtomicDisposition is the disposition for this field. Note that this
// can affect the interpretation of the GuardedBy field above, see the
// relevant comment.
AtomicDisposition atomicDisposition
}
// AFact implements analysis.Fact.AFact.
func (*lockGuardFacts) AFact() {}
// globalGuard is a global value.
type globalGuard struct {
// ObjectName indicates the object from which resolution should occur.
ObjectName string
// PackageName is the package where the object lives.
PackageName string
// FieldList is the traversal path from object.
FieldList fieldList
}
// ssaPackager returns the ssa package.
type ssaPackager interface {
Package() *ssa.Package
}
// resolveCommon implements resolution for all cases.
func (g *globalGuard) resolveCommon(pc *passContext, ls *lockState) resolvedValue {
state := pc.pass.ResultOf[buildssa.Analyzer].(*buildssa.SSA)
pkg := state.Pkg
if g.PackageName != "" && g.PackageName != state.Pkg.Pkg.Path() {
pkg = state.Pkg.Prog.ImportedPackage(g.PackageName)
}
v := pkg.Members[g.ObjectName].(ssa.Value)
return makeResolvedValue(v, g.FieldList)
}
// resolveStatic implements functionGuardResolver.resolveStatic.
func (g *globalGuard) resolveStatic(pc *passContext, ls *lockState, _ *ssa.Function, v any) resolvedValue {
return g.resolveCommon(pc, ls)
}
// resolveCall implements functionGuardResolver.resolveCall.
func (g *globalGuard) resolveCall(pc *passContext, ls *lockState, _ []ssa.Value, v ssa.Value) resolvedValue {
return g.resolveCommon(pc, ls)
}
// resolveField implements fieldGuardResolver.resolveField.
func (g *globalGuard) resolveField(pc *passContext, ls *lockState, parent ssa.Value) resolvedValue {
return g.resolveCommon(pc, ls)
}
// fieldGuard is a field-based guard.
type fieldGuard struct {
// FieldList is the traversal path from the parent.
FieldList fieldList
}
// resolveField implements fieldGuardResolver.resolveField.
func (f *fieldGuard) resolveField(_ *passContext, _ *lockState, parent ssa.Value) resolvedValue {
return makeResolvedValue(parent, f.FieldList)
}
// parameterGuard is a parameter-based guard.
type parameterGuard struct {
// Index is the parameter index of the object that contains the
// guarding mutex.
Index int
// fieldList is the traversal path from the parameter.
FieldList fieldList
}
// resolveStatic implements functionGuardResolver.resolveStatic.
func (p *parameterGuard) resolveStatic(_ *passContext, _ *lockState, fn *ssa.Function, _ any) resolvedValue {
return makeResolvedValue(fn.Params[p.Index], p.FieldList)
}
// resolveCall implements functionGuardResolver.resolveCall.
func (p *parameterGuard) resolveCall(_ *passContext, _ *lockState, args []ssa.Value, _ ssa.Value) resolvedValue {
return makeResolvedValue(args[p.Index], p.FieldList)
}
// returnGuard is a return-based guard.
type returnGuard struct {
// Index is the index of the return value.
Index int
// NeedsExtract is used in the case of a return value, and indicates
// that the field must be extracted from a tuple.
NeedsExtract bool
// FieldList is the traversal path from the return value.
FieldList fieldList
}
// resolveCommon implements resolution for both cases.
func (r *returnGuard) resolveCommon(rv any) resolvedValue {
if rv == nil {
// For defers and other objects, this may be nil. This is
// handled in state.go in the actual lock checking logic. This
// means that there is no resolvedValue available.
return resolvedValue{}
}
// If this is a *ssa.Return object, i.e. we are analyzing the function
// and not the call site, then we can just pull the result directly.
if ret, ok := rv.(*ssa.Return); ok {
return makeResolvedValue(ret.Results[r.Index], r.FieldList)
}
if r.NeedsExtract {
// Resolve on the extracted field, this is necessary if the
// type here is not an explicit return. Note that rv must be an
// ssa.Value, since it is not an *ssa.Return.
v := rv.(ssa.Value)
if refs := v.Referrers(); refs != nil {
for _, inst := range *refs {
if x, ok := inst.(*ssa.Extract); ok && x.Tuple == v && x.Index == r.Index {
return makeResolvedValue(x, r.FieldList)
}
}
}
// Nothing resolved.
return resolvedValue{}
}
if r.Index != 0 {
// This should not happen, NeedsExtract should always be set.
panic("NeedsExtract is false, but return value index is non-zero")
}
// Resolve on the single return.
return makeResolvedValue(rv.(ssa.Value), r.FieldList)
}
// resolveStatic implements functionGuardResolver.resolveStatic.
func (r *returnGuard) resolveStatic(_ *passContext, _ *lockState, _ *ssa.Function, rv any) resolvedValue {
return r.resolveCommon(rv)
}
// resolveCall implements functionGuardResolver.resolveCall.
func (r *returnGuard) resolveCall(_ *passContext, _ *lockState, _ []ssa.Value, rv ssa.Value) resolvedValue {
return r.resolveCommon(rv)
}
// functionGuardInfo is information about a method guard.
type functionGuardInfo struct {
// Resolver is the resolver for this guard.
Resolver functionGuardResolver
// Exclusive indicates an exclusive lock is required or excluded.
Exclusive bool
}
// lockFunctionFacts apply on every method.
type lockFunctionFacts struct {
// HeldOnEntry tracks the names and number of parameter (including receiver)
// lockFuncfields that guard calls to this function.
//
// The key is the name specified in the checklocks annotation. e.g given
// the following code:
//
// ```
// type A struct {
// mu sync.Mutex
// a int
// }
//
// // +checklocks:a.mu
// func xyz(a *A) {..}
// ```
//
// '`+checklocks:a.mu' will result in an entry in this map as shown below.
// HeldOnEntry: {"a.mu" => {Resolver: &parameterGuard{Index: 0}}
HeldOnEntry map[string]functionGuardInfo
// HeldOnExit tracks the locks that are expected to be held on exit.
HeldOnExit map[string]functionGuardInfo
// ExcludedOnEntry tracks locks that must not be held on entry.
//
// ExcludedOnEntry differs from HeldOnEntry in that it is checked only at call
// sites, and does not affect the caller's lock state after the call.
//
// Exclusive indicates whether the lock must not be held exclusively. If
// false, then the lock must not be held in any mode.
ExcludedOnEntry map[string]functionGuardInfo
// Ignore means this function has local analysis ignores.
//
// This is not used outside the local package.
Ignore bool
}
// AFact implements analysis.Fact.AFact.
func (*lockFunctionFacts) AFact() {}
// checkGuard validates the guardName.
func (lff *lockFunctionFacts) checkGuard(pc *passContext, d *ast.FuncDecl, guardName string, exclusive bool, allowReturn bool) (functionGuardInfo, bool) {
if fg, ok := lff.ExcludedOnEntry[guardName]; ok {
if exclusive || !fg.Exclusive {
pc.maybeFail(d.Pos(), "annotation %s cannot be both required and forbidden", guardName)
return functionGuardInfo{}, false
}
}
if _, ok := lff.HeldOnEntry[guardName]; ok {
pc.maybeFail(d.Pos(), "annotation %s specified more than once, already required", guardName)
return functionGuardInfo{}, false
}
if _, ok := lff.HeldOnExit[guardName]; ok {
pc.maybeFail(d.Pos(), "annotation %s specified more than once, already acquired", guardName)
return functionGuardInfo{}, false
}
res, lockObj, ok := pc.resolveFunctionGuard(d, guardName, allowReturn)
if !ok {
return functionGuardInfo{}, false
}
if !exclusive && !pc.validateMutex(d.Pos(), lockObj, false /* exclusive */) {
return functionGuardInfo{}, false
}
return functionGuardInfo{
Resolver: res,
Exclusive: exclusive,
}, true
}
func (lff *lockFunctionFacts) addExcludes(pc *passContext, d *ast.FuncDecl, guardName string, exclusiveOnly bool) {
if _, ok := lff.ExcludedOnEntry[guardName]; ok {
pc.maybeFail(d.Pos(), "annotation %s specified more than once, already forbidden", guardName)
return
}
if fg, ok := lff.HeldOnEntry[guardName]; ok {
if !exclusiveOnly || fg.Exclusive {
pc.maybeFail(d.Pos(), "annotation %s cannot be both required and forbidden", guardName)
return
}
}
res, _, ok := pc.resolveFunctionGuard(d, guardName, false /* allowReturn */)
if !ok {
return
}
if lff.ExcludedOnEntry == nil {
lff.ExcludedOnEntry = make(map[string]functionGuardInfo)
}
lff.ExcludedOnEntry[guardName] = functionGuardInfo{
Resolver: res,
Exclusive: exclusiveOnly,
}
}
// addGuardedBy adds a field to both HeldOnEntry and HeldOnExit.
func (lff *lockFunctionFacts) addGuardedBy(pc *passContext, d *ast.FuncDecl, guardName string, exclusive bool) {
if fg, ok := lff.checkGuard(pc, d, guardName, exclusive, false /* allowReturn */); ok {
if lff.HeldOnEntry == nil {
lff.HeldOnEntry = make(map[string]functionGuardInfo)
}
if lff.HeldOnExit == nil {
lff.HeldOnExit = make(map[string]functionGuardInfo)
}
lff.HeldOnEntry[guardName] = fg
lff.HeldOnExit[guardName] = fg
}
}
// addAcquires adds a field to HeldOnExit.
func (lff *lockFunctionFacts) addAcquires(pc *passContext, d *ast.FuncDecl, guardName string, exclusive bool) {
if fg, ok := lff.checkGuard(pc, d, guardName, exclusive, true /* allowReturn */); ok {
if lff.HeldOnExit == nil {
lff.HeldOnExit = make(map[string]functionGuardInfo)
}
lff.HeldOnExit[guardName] = fg
}
}
// addReleases adds a field to HeldOnEntry.
func (lff *lockFunctionFacts) addReleases(pc *passContext, d *ast.FuncDecl, guardName string, exclusive bool) {
if fg, ok := lff.checkGuard(pc, d, guardName, exclusive, false /* allowReturn */); ok {
if lff.HeldOnEntry == nil {
lff.HeldOnEntry = make(map[string]functionGuardInfo)
}
lff.HeldOnEntry[guardName] = fg
}
}
func fieldListEqual(left fieldList, right fieldList) bool {
return slices.EqualFunc(left, right, fieldEntryEqual)
}
func aliasPathHasPtrOrIface(fl fieldList) bool {
return slices.ContainsFunc(fl, func(entry fieldEntry) bool {
_, ok := entry.(*fieldStructPtr)
return ok
})
}
type typeAlias struct {
Left fieldList
Right fieldList
}
type lockTypeFacts struct {
Aliases []typeAlias
}
// AFact implements analysis.Fact.AFact.
func (*lockTypeFacts) AFact() {}
func (ltf *lockTypeFacts) addTypeAlias(pc *passContext, ts *ast.TypeSpec, structType *types.Struct, guardName string) {
parts := strings.Split(guardName, "=")
if len(parts) != 2 {
pc.maybeFail(ts.Pos(), "invalid annotation %s for alias", guardName)
return
}
leftName := parts[0]
rightName := parts[1]
if leftName == rightName {
pc.maybeFail(ts.Pos(), "alias annotation %s refers to the same lock", guardName)
return
}
leftParts := strings.Split(leftName, ".")
leftFL, leftPrefixLens, leftObjs, ok := pc.resolveFieldListParts(ts.Pos(), structType, leftParts)
if !ok {
return
}
rightParts := strings.Split(rightName, ".")
rightFL, rightPrefixLens, rightObjs, ok := pc.resolveFieldListParts(ts.Pos(), structType, rightParts)
if !ok {
return
}
leftObj := leftObjs[len(leftObjs)-1]
rightObj := rightObjs[len(rightObjs)-1]
if !pc.validateMutex(ts.Pos(), leftObj, true /* exclusive */) {
return
}
if !pc.validateMutex(ts.Pos(), rightObj, true /* exclusive */) {
return
}
if !aliasPathHasPtrOrIface(leftFL) && !aliasPathHasPtrOrIface(rightFL) {
pc.maybeFail(ts.Pos(), "alias annotation %s requires a pointer or interface lock", guardName)
return
}
min := slices.Min([]int{len(leftPrefixLens), len(rightPrefixLens)})
for i := -1; i < min; i++ {
var aliases []typeAlias
var leftSuffix fieldList
var rightSuffix fieldList
if i == -1 {
aliases = ltf.Aliases
leftSuffix = leftFL
rightSuffix = rightFL
} else {
leftPrefix := leftFL[:leftPrefixLens[i]]
rightPrefix := rightFL[:rightPrefixLens[i]]
if !fieldListEqual(leftPrefix, rightPrefix) {
break
}
leftSuffix = leftFL[leftPrefixLens[i]:]
rightSuffix = rightFL[rightPrefixLens[i]:]
var nestedFacts lockTypeFacts
pc.importLockTypeFacts(leftObjs[i].Type(), &nestedFacts)
aliases = nestedFacts.Aliases
}
for _, alias := range aliases {
redundant := false
redundant = redundant || (fieldListEqual(alias.Left, leftSuffix) && fieldListEqual(alias.Right, rightSuffix))
redundant = redundant || (fieldListEqual(alias.Left, rightSuffix) && fieldListEqual(alias.Right, leftSuffix))
if redundant {
pc.maybeFail(ts.Pos(), "alias annotation %s is redundant", guardName)
return
}
}
}
ltf.Aliases = append(ltf.Aliases, typeAlias{
Left: leftFL,
Right: rightFL,
})
}
// fieldEntryFor returns the fieldList value for the given object.
func (pc *passContext) fieldEntryFor(fieldObj types.Object, index int) fieldEntry {
// Return the resolution path.
switch types.Unalias(fieldObj.Type()).Underlying().(type) {
case *types.Pointer, *types.Interface:
return &fieldStructPtr{Field: index}
default:
return &fieldStruct{Field: index}
}
}
// findField resolves a field in a single struct.
func (pc *passContext) findField(structType *types.Struct, fieldName string) (fieldList, types.Object, bool) {
var fl fieldList
// Scan to match the next field.
for i := 0; i < structType.NumFields(); i++ {
fieldObj := structType.Field(i)
if fieldObj.Name() != fieldName {
continue
}
fl = append(fl, pc.fieldEntryFor(fieldObj, i))
return fl, fieldObj, true
}
// Is this an embed?
for i := 0; i < structType.NumFields(); i++ {
fieldObj := structType.Field(i)
if !fieldObj.Embedded() {
continue
}
// Is this an embedded struct?
structType, ok := resolveStruct(fieldObj.Type())
if !ok {
continue
}
// Need to check that there is a resolution path. If there is
// no resolution path that's not a failure: we just continue
// scanning the next embed to find a match.
flEmbed := pc.fieldEntryFor(fieldObj, i)
flNext, fieldObjNext, ok := pc.findField(structType, fieldName)
if !ok {
continue
}
// Found an embedded chain.
fl = append(fl, flEmbed)
fl = append(fl, flNext...)
return fl, fieldObjNext, true
}
return nil, nil, false
}
var (
mutexRE = regexp.MustCompile(".*Mutex")
rwMutexRE = regexp.MustCompile(".*RWMutex")
lockerRE = regexp.MustCompile(".*sync.Locker")
)
type lockKind interface {
isLockKind()
}
type lockKindMutex struct{}
func (*lockKindMutex) isLockKind() {}
type lockKindRWMutex struct{}
func (*lockKindRWMutex) isLockKind() {}
// lockKind validates the mutex type and returns its kind.
//
// This function returns nil iff obj is not a supported lock and reports an
// error at the given position.
func (pc *passContext) lockKind(pos token.Pos, obj types.Object) lockKind {
// Check that it is indeed a mutex.
s := obj.Type().String()
switch {
case rwMutexRE.MatchString(s):
return &lockKindRWMutex{}
case mutexRE.MatchString(s), lockerRE.MatchString(s):
return &lockKindMutex{}
default:
// Not a mutex at all?
pc.maybeFail(pos, "field %s is not a Mutex or an RWMutex", obj.Name())
return nil
}
}
// validateMutex validates the mutex type.
//
// This function returns true iff the object is a valid mutex with an error
// reported at the given position if necessary.
func (pc *passContext) validateMutex(pos token.Pos, obj types.Object, exclusive bool) bool {
kind := pc.lockKind(pos, obj)
switch kind.(type) {
case nil:
return false
case *lockKindMutex:
// If we require a non-exclusive hold, this must be a RWMutex.
if !exclusive {
pc.maybeFail(pos, "field %s must be a RWMutex", obj.Name())
return false
}
case *lockKindRWMutex:
default:
panic(fmt.Sprintf("unknown lock kind: %T", kind))
}
return true
}
func (pc *passContext) resolveFieldListParts(pos token.Pos, structType *types.Struct, parts []string) (fieldList, []int, []types.Object, bool) {
var fl fieldList
prefixLens := make([]int, 0, len(parts))
objs := make([]types.Object, 0, len(parts))
// This loop requires at least one iteration in order to ensure that
// obj above is non-nil, and the type can be validated.
for i, fieldName := range parts {
flOne, fieldObj, ok := pc.findField(structType, fieldName)
if !ok {
return nil, nil, nil, false
}
fl = append(fl, flOne...)
prefixLens = append(prefixLens, len(fl))
objs = append(objs, fieldObj)
if i < len(parts)-1 {
var ok bool
structType, ok = resolveStruct(fieldObj.Type())
if !ok {
// N.B. This is associated with the original position.
pc.maybeFail(pos, "field %s expected to be struct", fieldName)
return nil, nil, nil, false
}
}
}
return fl, prefixLens, objs, true
}
// maybeFindFieldList resolves the given object.
//
// Parts may be the empty list, unlike findFieldList.
func (pc *passContext) maybeFindFieldListObj(pos token.Pos, obj types.Object, parts []string) (fieldList, types.Object, bool) {
if len(parts) > 0 {
structType, ok := resolveStruct(obj.Type())
if !ok {
// This does not have any fields; the access is not allowed.
pc.maybeFail(pos, "attempted field access on non-struct")
return nil, nil, false
}
fl, _, objs, ok := pc.resolveFieldListParts(pos, structType, parts)
if !ok {
return nil, nil, false
}
return fl, objs[len(objs)-1], true
}
return nil, obj, true
}
// findFieldGuardResolver finds a symbol resolver.
type findFieldGuardResolver func(pos token.Pos, guardName string) (fieldGuardResolver, bool)
// findFunctionGuardResolver finds a symbol resolver.
type findFunctionGuardResolver func(pos token.Pos, guardName string) (functionGuardResolver, bool)
// fillLockGuardFacts fills the facts with guard information.
func (pc *passContext) fillLockGuardFacts(obj types.Object, cg *ast.CommentGroup, find findFieldGuardResolver, lgf *lockGuardFacts) {
if cg == nil {
return
}
for _, l := range cg.List {
pc.extractAnnotations(l.Text, map[string]func(string){
checkAtomicAnnotation: func(string) {
switch lgf.AtomicDisposition {
case atomicRequired:
pc.maybeFail(obj.Pos(), "annotation is redundant, already atomic required")
case atomicIgnore:
pc.maybeFail(obj.Pos(), "annotation is contradictory, already atomic ignored")
}
lgf.AtomicDisposition = atomicRequired
},
checkLocksIgnore: func(string) {
switch lgf.AtomicDisposition {
case atomicIgnore:
pc.maybeFail(obj.Pos(), "annotation is redundant, already atomic ignored")
case atomicRequired:
pc.maybeFail(obj.Pos(), "annotation is contradictory, already atomic required")
}
lgf.AtomicDisposition = atomicIgnore
},
checkLocksAnnotation: func(guardName string) {
// Check for a duplicate annotation.
if _, ok := lgf.GuardedBy[guardName]; ok {
pc.maybeFail(obj.Pos(), "annotation %s specified more than once", guardName)
return
}
// Add the item.
if lgf.GuardedBy == nil {
lgf.GuardedBy = make(map[string]fieldGuardResolver)
}
fr, ok := find(obj.Pos(), guardName)
if !ok {
pc.maybeFail(obj.Pos(), "annotation %s cannot be resolved", guardName)
return
}
lgf.GuardedBy[guardName] = fr
},
// N.B. We support only the vanilla annotation on
// individual fields. If the field is a read lock, then
// we will allow read access by default.
checkLocksAnnotationRead: func(guardName string) {
pc.maybeFail(obj.Pos(), "annotation %s not legal on fields", guardName)
},
})
}
// Save only if there is something meaningful.
if len(lgf.GuardedBy) > 0 || lgf.AtomicDisposition != atomicDisallow {
pc.pass.ExportObjectFact(obj, lgf)
}
}
// findGlobalGuard attempts to resolve a name globally.
func (pc *passContext) findGlobalGuard(pos token.Pos, guardName string) (*globalGuard, types.Object, bool) {
// Attempt to resolve the object.
parts := strings.Split(guardName, ".")
globalObj := pc.pass.Pkg.Scope().Lookup(parts[0])
if globalObj == nil {
// No global object.
return nil, nil, false
}
fl, lockObj, ok := pc.maybeFindFieldListObj(pos, globalObj, parts[1:])
if !ok {
// Invalid fields.
return nil, nil, false
}
if pc.lockKind(pos, lockObj) == nil {
return nil, nil, false
}
return &globalGuard{
ObjectName: parts[0],
PackageName: pc.pass.Pkg.Path(),
FieldList: fl,
}, lockObj, true
}
// findGlobalFieldGuard is compatible with findFieldGuardResolver.
func (pc *passContext) findGlobalFieldGuard(pos token.Pos, guardName string) (fieldGuardResolver, bool) {
g, _, ok := pc.findGlobalGuard(pos, guardName)
return g, ok
}
// findGlobalFunctionGuard is compatible with findFunctionGuardResolver.
func (pc *passContext) findGlobalFunctionGuard(pos token.Pos, guardName string) (functionGuardResolver, bool) {
g, _, ok := pc.findGlobalGuard(pos, guardName)
return g, ok
}
// structLockGuardFacts finds all relevant guard information for structures.
func (pc *passContext) structLockGuardFacts(structType *types.Struct, ss *ast.StructType) {
var fieldObj *types.Var
findLocal := func(pos token.Pos, guardName string) (fieldGuardResolver, bool) {
// Try to resolve from the local structure first.
if fl, _, objs, ok := pc.resolveFieldListParts(pos, structType, strings.Split(guardName, ".")); ok {
lockObj := objs[len(objs)-1]
// Validate the final field.
if pc.validateMutex(pos, lockObj, true /* exclusive */) {
// Found a valid resolution.
return &fieldGuard{
FieldList: fl,
}, true
}
}
// Attempt a global resolution.
return pc.findGlobalFieldGuard(pos, guardName)
}
for i, field := range ss.Fields.List {
var lgf lockGuardFacts
fieldObj = structType.Field(i) // N.B. Captured above.
if field.Doc != nil {
pc.fillLockGuardFacts(fieldObj, field.Doc, findLocal, &lgf)
}
if field.Comment != nil {
pc.fillLockGuardFacts(fieldObj, field.Comment, findLocal, &lgf)
}
// See above, for anonymous structure fields.
if ss, ok := field.Type.(*ast.StructType); ok {
if st, ok := types.Unalias(fieldObj.Type()).(*types.Struct); ok {
pc.structLockGuardFacts(st, ss)
}
}
}
}
// globalLockGuardFacts finds all relevant guard information for globals.
//
// Note that the Type is checked in checklocks.go at the top-level.
func (pc *passContext) globalLockGuardFacts(vs *ast.ValueSpec) {
var lgf lockGuardFacts
globalObj := pc.pass.TypesInfo.ObjectOf(vs.Names[0])
pc.fillLockGuardFacts(globalObj, vs.Doc, pc.findGlobalFieldGuard, &lgf)
}
// countFields gives an accurate field count, according for unnamed arguments
// and return values and the compact identifier format.
func countFields(fl []*ast.Field) (count int) {
for _, field := range fl {
if len(field.Names) == 0 {
count++
continue
}
count += len(field.Names)
}
return
}
// matchFieldList attempts to match the given field.
//
// This function may or may not report an error. This is indicated in the
// reported return value. If reported is true, then the specification is
// ambiguous or not valid, and should be propagated.
func (pc *passContext) matchFieldList(pos token.Pos, fields []*ast.Field, guardName string) (number int, fl fieldList, lockObj types.Object, reported, ok bool) {
parts := strings.Split(guardName, ".")
firstName := parts[0]
index := 0
for _, field := range fields {
// See countFields, above.
if len(field.Names) == 0 {
index++
continue
}
for _, name := range field.Names {
if name.Name != firstName {
index++
continue
}
obj := pc.pass.TypesInfo.ObjectOf(name)
fl, lockObj, ok := pc.maybeFindFieldListObj(pos, obj, parts[1:])
if !ok {
// Some intermediate name does not match. The
// resolveField function will not report.
pc.maybeFail(pos, "name %s does not resolve to a field", guardName)
return 0, nil, nil, true, false
}
if pc.lockKind(pos, lockObj) == nil {
return 0, nil, nil, true, false
}
// Successfully found a field.
return index, fl, lockObj, false, true
}
}
// Nothing matching.
return 0, nil, nil, false, false
}
// resolveFunctionGuard identifies the guard resolver for a particular string
// of the form 'a.b'.
//
// This function reports errors directly, but does not impose any lock-mode
// requirements (e.g. RWMutex-only for non-exclusive holds).
func (pc *passContext) resolveFunctionGuard(d *ast.FuncDecl, guardName string, allowReturn bool) (functionGuardResolver, types.Object, bool) {
// Match against receiver & parameters.
var parameterList []*ast.Field
if d.Recv != nil {
parameterList = append(parameterList, d.Recv.List...)
}
if d.Type.Params != nil {
parameterList = append(parameterList, d.Type.Params.List...)
}
if index, fl, lockObj, reported, ok := pc.matchFieldList(d.Pos(), parameterList, guardName); reported || ok {
if !ok {
return nil, nil, false
}
return &parameterGuard{
Index: index,
FieldList: fl,
}, lockObj, true
}
// Match against return values, if allowed.
if allowReturn {
var returnList []*ast.Field
if d.Type.Results != nil {
returnList = append(returnList, d.Type.Results.List...)
}
if index, fl, lockObj, reported, ok := pc.matchFieldList(d.Pos(), returnList, guardName); reported || ok {
if !ok {
return nil, nil, false
}
return &returnGuard{
Index: index,
FieldList: fl,
NeedsExtract: countFields(returnList) > 1,
}, lockObj, true
}
}
// Match against globals.
if g, lockObj, ok := pc.findGlobalGuard(d.Pos(), guardName); ok {
return g, lockObj, true
}
// No match found.
pc.maybeFail(d.Pos(), "annotation %s does not have a match any parameter, return value or global", guardName)
return nil, nil, false
}
// functionFacts exports relevant function findings.
func (pc *passContext) functionFacts(d *ast.FuncDecl) {
// Extract guard information.
if d.Doc == nil || d.Doc.List == nil {
return
}
var lff lockFunctionFacts
for _, l := range d.Doc.List {
pc.extractAnnotations(l.Text, map[string]func(string){
checkLocksIgnore: func(string) {
// Note that this applies to all atomic
// analysis as well. There is no provided way
// to selectively ignore only lock analysis or
// atomic analysis, as we expect this use to be
// extremely rare.
lff.Ignore = true
},
checkLocksAnnotation: func(guardName string) { lff.addGuardedBy(pc, d, guardName, true /* exclusive */) },
checkLocksAnnotationRead: func(guardName string) { lff.addGuardedBy(pc, d, guardName, false /* exclusive */) },
checkLocksAcquires: func(guardName string) { lff.addAcquires(pc, d, guardName, true /* exclusive */) },
checkLocksAcquiresRead: func(guardName string) { lff.addAcquires(pc, d, guardName, false /* exclusive */) },
checkLocksReleases: func(guardName string) { lff.addReleases(pc, d, guardName, true /* exclusive */) },
checkLocksReleasesRead: func(guardName string) { lff.addReleases(pc, d, guardName, false /* exclusive */) },
checkLocksExcludes: func(guardName string) { lff.addExcludes(pc, d, guardName, false /* exclusiveOnly */) },
checkLocksExcludesWrite: func(guardName string) { lff.addExcludes(pc, d, guardName, true /* exclusiveOnly */) },
})
}
// Export the function facts if there is anything to save.
if lff.Ignore || len(lff.HeldOnEntry) > 0 || len(lff.HeldOnExit) > 0 || len(lff.ExcludedOnEntry) > 0 {
funcObj := pc.pass.TypesInfo.Defs[d.Name].(*types.Func)
pc.pass.ExportObjectFact(funcObj, &lff)
}
}
func (pc *passContext) typeAliasFacts(ts *ast.TypeSpec, decl *ast.GenDecl) {
var ltf lockTypeFacts
structType, ok := resolveStruct(pc.pass.TypesInfo.TypeOf(ts.Name))
for _, cg := range []*ast.CommentGroup{ts.Doc, ts.Comment, decl.Doc} {
if cg == nil {
continue
}
for _, l := range cg.List {
pc.extractAnnotations(l.Text, map[string]func(string){
checkLocksAlias: func(guardName string) {
if !ok {
pc.maybeFail(ts.Pos(), "annotation %s is only valid on struct types", guardName)
return
}
ltf.addTypeAlias(pc, ts, structType, guardName)
},
})
}
}
if len(ltf.Aliases) > 0 {
typeObj := pc.pass.TypesInfo.Defs[ts.Name].(*types.TypeName)
pc.pass.ExportObjectFact(typeObj, &ltf)
}
}
func init() {
gob.Register((*returnGuard)(nil))
gob.Register((*globalGuard)(nil))
gob.Register((*parameterGuard)(nil))
gob.Register((*fieldGuard)(nil))
gob.Register((*fieldStructPtr)(nil))
gob.Register((*fieldStruct)(nil))
}