Files
visor/tools/checklocks/test/closures.go
T
Adin ScannellandgVisor bot 2e330e733d Minor checklocks improvements.
* Support sync.Locker.
* Prevent runaway recursion when locks are acquired in a loop.
* Allowing ignoring of anonymous functions (inherited from parent function).
* Add support for aliases.

PiperOrigin-RevId: 407221521
2021-11-02 18:04:26 -07:00

119 lines
2.9 KiB
Go

// Copyright 2020 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package test
func testClosureInvalid(tc *oneGuardStruct) {
// This is expected to fail.
callClosure(func() {
tc.guardedField = 1 // +checklocksfail
})
}
func testClosureUnsupported(tc *oneGuardStruct) {
// Locked outside the closure, so may or may not be valid. This cannot
// be handled and we should explicitly fail. This can't be handled
// because of the call through callClosure, below, which means the
// closure will actually be passed as a value somewhere.
tc.mu.Lock()
callClosure(func() {
tc.guardedField = 1 // +checklocksfail
})
tc.mu.Unlock()
}
func testClosureValid(tc *oneGuardStruct) {
// All locking happens within the closure. This should not present a
// problem for analysis.
callClosure(func() {
tc.mu.Lock()
tc.guardedField = 1
tc.mu.Unlock()
})
}
func testClosureInline(tc *oneGuardStruct) {
// If the closure is being dispatching inline only, then we should be
// able to analyze this call and give it a thumbs up.
tc.mu.Lock()
func() {
tc.guardedField = 1
}()
tc.mu.Unlock()
}
// +checklocksignore
func testClosureIgnore(tc *oneGuardStruct) {
// Inherit the checklocksignore.
x := func() {
tc.guardedField = 1
}
x()
}
func testAnonymousInvalid(tc *oneGuardStruct) {
// Invalid, as per testClosureInvalid above.
callAnonymous(func(tc *oneGuardStruct) {
tc.guardedField = 1 // +checklocksfail
}, tc)
}
func testAnonymousUnsupported(tc *oneGuardStruct) {
// Not supportable, as per testClosureUnsupported above.
tc.mu.Lock()
callAnonymous(func(tc *oneGuardStruct) {
tc.guardedField = 1 // +checklocksfail
}, tc)
tc.mu.Unlock()
}
func testAnonymousValid(tc *oneGuardStruct) {
// Valid, as per testClosureValid above.
callAnonymous(func(tc *oneGuardStruct) {
tc.mu.Lock()
tc.guardedField = 1
tc.mu.Unlock()
}, tc)
}
func testAnonymousInline(tc *oneGuardStruct) {
// Unlike the closure case, we are able to dynamically infer the set of
// preconditions for the function dispatch and assert that this is
// a valid call.
tc.mu.Lock()
func(tc *oneGuardStruct) {
tc.guardedField = 1
}(tc)
tc.mu.Unlock()
}
// +checklocksignore
func testAnonymousIgnore(tc *oneGuardStruct) {
// Inherit the checklocksignore.
x := func(tc *oneGuardStruct) {
tc.guardedField = 1
}
x(tc)
}
//go:noinline
func callClosure(fn func()) {
fn()
}
//go:noinline
func callAnonymous(fn func(*oneGuardStruct), tc *oneGuardStruct) {
fn(tc)
}