Files
visor/pkg/sentry/fsimpl/fuse/read_write.go
T
Rahat MahmoodandgVisor bot 0fb93a3804 Fix error handling on fusefs mount.
Don't propagate arbitrary golang errors up from fusefs because errors
that don't map to an errno result in a sentry panic.

Reported-by: [email protected]
PiperOrigin-RevId: 346220306
2020-12-07 18:00:54 -08:00

237 lines
7.2 KiB
Go

// Copyright 2020 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package fuse
import (
"io"
"sync/atomic"
"gvisor.dev/gvisor/pkg/abi/linux"
"gvisor.dev/gvisor/pkg/context"
"gvisor.dev/gvisor/pkg/log"
"gvisor.dev/gvisor/pkg/sentry/kernel"
"gvisor.dev/gvisor/pkg/sentry/kernel/auth"
"gvisor.dev/gvisor/pkg/syserror"
"gvisor.dev/gvisor/pkg/usermem"
)
// ReadInPages sends FUSE_READ requests for the size after round it up to
// a multiple of page size, blocks on it for reply, processes the reply
// and returns the payload (or joined payloads) as a byte slice.
// This is used for the general purpose reading.
// We do not support direct IO (which read the exact number of bytes)
// at this moment.
func (fs *filesystem) ReadInPages(ctx context.Context, fd *regularFileFD, off uint64, size uint32) ([][]byte, uint32, error) {
attributeVersion := atomic.LoadUint64(&fs.conn.attributeVersion)
t := kernel.TaskFromContext(ctx)
if t == nil {
log.Warningf("fusefs.Read: couldn't get kernel task from context")
return nil, 0, syserror.EINVAL
}
// Round up to a multiple of page size.
readSize, _ := usermem.PageRoundUp(uint64(size))
// One request cannnot exceed either maxRead or maxPages.
maxPages := fs.conn.maxRead >> usermem.PageShift
if maxPages > uint32(fs.conn.maxPages) {
maxPages = uint32(fs.conn.maxPages)
}
var outs [][]byte
var sizeRead uint32
// readSize is a multiple of usermem.PageSize.
// Always request bytes as a multiple of pages.
pagesRead, pagesToRead := uint32(0), uint32(readSize>>usermem.PageShift)
// Reuse the same struct for unmarshalling to avoid unnecessary memory allocation.
in := linux.FUSEReadIn{
Fh: fd.Fh,
LockOwner: 0, // TODO(gvisor.dev/issue/3245): file lock
ReadFlags: 0, // TODO(gvisor.dev/issue/3245): |= linux.FUSE_READ_LOCKOWNER
Flags: fd.statusFlags(),
}
// This loop is intended for fragmented read where the bytes to read is
// larger than either the maxPages or maxRead.
// For the majority of reads with normal size, this loop should only
// execute once.
for pagesRead < pagesToRead {
pagesCanRead := pagesToRead - pagesRead
if pagesCanRead > maxPages {
pagesCanRead = maxPages
}
in.Offset = off + (uint64(pagesRead) << usermem.PageShift)
in.Size = pagesCanRead << usermem.PageShift
// TODO(gvisor.dev/issue/3247): support async read.
req := fs.conn.NewRequest(auth.CredentialsFromContext(ctx), uint32(t.ThreadID()), fd.inode().nodeID, linux.FUSE_READ, &in)
res, err := fs.conn.Call(t, req)
if err != nil {
return nil, 0, err
}
if err := res.Error(); err != nil {
return nil, 0, err
}
// Not enough bytes in response,
// either we reached EOF,
// or the FUSE server sends back a response
// that cannot even fit the hdr.
if len(res.data) <= res.hdr.SizeBytes() {
// We treat both case as EOF here for now
// since there is no reliable way to detect
// the over-short hdr case.
break
}
// Directly using the slice to avoid extra copy.
out := res.data[res.hdr.SizeBytes():]
outs = append(outs, out)
sizeRead += uint32(len(out))
pagesRead += pagesCanRead
}
defer fs.ReadCallback(ctx, fd, off, size, sizeRead, attributeVersion)
// No bytes returned: offset >= EOF.
if len(outs) == 0 {
return nil, 0, io.EOF
}
return outs, sizeRead, nil
}
// ReadCallback updates several information after receiving a read response.
// Due to readahead, sizeRead can be larger than size.
func (fs *filesystem) ReadCallback(ctx context.Context, fd *regularFileFD, off uint64, size uint32, sizeRead uint32, attributeVersion uint64) {
// TODO(gvisor.dev/issue/3247): support async read.
// If this is called by an async read, correctly process it.
// May need to update the signature.
i := fd.inode()
i.InodeAttrs.TouchAtime(ctx, fd.vfsfd.Mount())
// Reached EOF.
if sizeRead < size {
// TODO(gvisor.dev/issue/3630): If we have writeback cache, then we need to fill this hole.
// Might need to update the buf to be returned from the Read().
// Update existing size.
newSize := off + uint64(sizeRead)
fs.conn.mu.Lock()
if attributeVersion == i.attributeVersion && newSize < atomic.LoadUint64(&i.size) {
fs.conn.attributeVersion++
i.attributeVersion = i.fs.conn.attributeVersion
atomic.StoreUint64(&i.size, newSize)
}
fs.conn.mu.Unlock()
}
}
// Write sends FUSE_WRITE requests and return the bytes
// written according to the response.
//
// Preconditions: len(data) == size.
func (fs *filesystem) Write(ctx context.Context, fd *regularFileFD, off uint64, size uint32, data []byte) (uint32, error) {
t := kernel.TaskFromContext(ctx)
if t == nil {
log.Warningf("fusefs.Read: couldn't get kernel task from context")
return 0, syserror.EINVAL
}
// One request cannnot exceed either maxWrite or maxPages.
maxWrite := uint32(fs.conn.maxPages) << usermem.PageShift
if maxWrite > fs.conn.maxWrite {
maxWrite = fs.conn.maxWrite
}
// Reuse the same struct for unmarshalling to avoid unnecessary memory allocation.
in := linux.FUSEWriteIn{
Fh: fd.Fh,
// TODO(gvisor.dev/issue/3245): file lock
LockOwner: 0,
// TODO(gvisor.dev/issue/3245): |= linux.FUSE_READ_LOCKOWNER
// TODO(gvisor.dev/issue/3237): |= linux.FUSE_WRITE_CACHE (not added yet)
WriteFlags: 0,
Flags: fd.statusFlags(),
}
inode := fd.inode()
var written uint32
// This loop is intended for fragmented write where the bytes to write is
// larger than either the maxWrite or maxPages or when bigWrites is false.
// Unless a small value for max_write is explicitly used, this loop
// is expected to execute only once for the majority of the writes.
for written < size {
toWrite := size - written
// Limit the write size to one page.
// Note that the bigWrites flag is obsolete,
// latest libfuse always sets it on.
if !fs.conn.bigWrites && toWrite > usermem.PageSize {
toWrite = usermem.PageSize
}
// Limit the write size to maxWrite.
if toWrite > maxWrite {
toWrite = maxWrite
}
in.Offset = off + uint64(written)
in.Size = toWrite
req := fs.conn.NewRequest(auth.CredentialsFromContext(ctx), uint32(t.ThreadID()), inode.nodeID, linux.FUSE_WRITE, &in)
req.payload = data[written : written+toWrite]
// TODO(gvisor.dev/issue/3247): support async write.
res, err := fs.conn.Call(t, req)
if err != nil {
return 0, err
}
if err := res.Error(); err != nil {
return 0, err
}
out := linux.FUSEWriteOut{}
if err := res.UnmarshalPayload(&out); err != nil {
return 0, err
}
// Write more than requested? EIO.
if out.Size > toWrite {
return 0, syserror.EIO
}
written += out.Size
// Break if short write. Not necessarily an error.
if out.Size != toWrite {
break
}
}
inode.InodeAttrs.TouchCMtime(ctx)
return written, nil
}