mirror of
https://github.com/hanzoai/visor.git
synced 2026-09-24 17:04:14 +00:00
Ayush RanjanandgVisor bot
efe2391a05
There are 2 interfaces in gVisor which are exactly the same: - pkg/tcpip/stack.UniqueID - pkg/sentry/uniqueid.Provider Before this change, both were using the Kernel as the unique number generator. However, we want to decouple the netstack from the kernel. This coupling is causing bugs in restore because netstack needs to be created before the Kernel is restored. So right now, netstack ends up using a "temporary" Kernel which is later destroyed in the restore sequence, but netstack keeps referencing it. Before this change, the unique ID generator in pkg/tcpip/stack.Stack was used for 2 things: 1. Provide NIC IDs which are unique across all network namespaces. 2. Implement stack.TransportEndpoint.UniqueID. (2) is not used anywhere, so deleted it. (1) is overly unique. NIC IDs do not need to be unique across network namespace. So instead of holding a pointer to the kernel, added a NIC ID generator in stack.Stack itself and added NextNICID() function with proper typing. PiperOrigin-RevId: 646997006