mirror of
https://github.com/hanzoai/yoga.git
synced 2026-10-30 19:34:29 +00:00
Summary: X-link: https://github.com/facebook/react-native/pull/44791 Pull Request resolved: https://github.com/facebook/yoga/pull/1662 This should fix https://github.com/facebook/yoga/issues/1657. Rather insidious bug but we had code like ``` // The total padding/border for a given axis does not depend on the direction // so hardcoding LTR here to avoid piping direction to this function return node->style().computeInlineStartPaddingAndBorder( axis, Direction::LTR, widthSize) + node->style().computeInlineEndPaddingAndBorder( axis, Direction::LTR, widthSize); ``` That comment is NOT true if someone sets both the physical edge and relative edge. So like paddingLeft and paddingEnd for RTL. This diff simply pipes the direction to that spot to use instead of hardcoding LTR. Every file changed is just to pipe `direction`. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D58169843 fbshipit-source-id: 5b4854dddc019285076bd06955557edf73ef7ec5
353 lines
11 KiB
TypeScript
353 lines
11 KiB
TypeScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @generated SignedSource<<688d750852e836fc6403042d89d5ab51>>
|
|
* generated by gentest/gentest-driver.ts from gentest/fixtures/YGPaddingTest.html
|
|
*/
|
|
|
|
import Yoga from 'yoga-layout';
|
|
import {
|
|
Align,
|
|
Direction,
|
|
Display,
|
|
Edge,
|
|
Errata,
|
|
ExperimentalFeature,
|
|
FlexDirection,
|
|
Gutter,
|
|
Justify,
|
|
MeasureMode,
|
|
Overflow,
|
|
PositionType,
|
|
Unit,
|
|
Wrap,
|
|
} from 'yoga-layout';
|
|
|
|
test('padding_no_size', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setPadding(Edge.Left, 10);
|
|
root.setPadding(Edge.Top, 10);
|
|
root.setPadding(Edge.Right, 10);
|
|
root.setPadding(Edge.Bottom, 10);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(20);
|
|
expect(root.getComputedHeight()).toBe(20);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(20);
|
|
expect(root.getComputedHeight()).toBe(20);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test('padding_container_match_child', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setPadding(Edge.Left, 10);
|
|
root.setPadding(Edge.Top, 10);
|
|
root.setPadding(Edge.Right, 10);
|
|
root.setPadding(Edge.Bottom, 10);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setWidth(10);
|
|
root_child0.setHeight(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(30);
|
|
expect(root.getComputedHeight()).toBe(30);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(30);
|
|
expect(root.getComputedHeight()).toBe(30);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test('padding_flex_child', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setPadding(Edge.Left, 10);
|
|
root.setPadding(Edge.Top, 10);
|
|
root.setPadding(Edge.Right, 10);
|
|
root.setPadding(Edge.Bottom, 10);
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setFlexGrow(1);
|
|
root_child0.setWidth(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(80);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(80);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(80);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test('padding_stretch_child', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setPadding(Edge.Left, 10);
|
|
root.setPadding(Edge.Top, 10);
|
|
root.setPadding(Edge.Right, 10);
|
|
root.setPadding(Edge.Bottom, 10);
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setHeight(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(80);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(10);
|
|
expect(root_child0.getComputedTop()).toBe(10);
|
|
expect(root_child0.getComputedWidth()).toBe(80);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test('padding_center_child', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setJustifyContent(Justify.Center);
|
|
root.setAlignItems(Align.Center);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setPadding(Edge.Start, 10);
|
|
root.setPadding(Edge.End, 20);
|
|
root.setPadding(Edge.Bottom, 20);
|
|
root.setWidth(100);
|
|
root.setHeight(100);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setWidth(10);
|
|
root_child0.setHeight(10);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(40);
|
|
expect(root_child0.getComputedTop()).toBe(35);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(100);
|
|
expect(root.getComputedHeight()).toBe(100);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(50);
|
|
expect(root_child0.getComputedTop()).toBe(35);
|
|
expect(root_child0.getComputedWidth()).toBe(10);
|
|
expect(root_child0.getComputedHeight()).toBe(10);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test('child_with_padding_align_end', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setJustifyContent(Justify.FlexEnd);
|
|
root.setAlignItems(Align.FlexEnd);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setWidth(200);
|
|
root.setHeight(200);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setPadding(Edge.Left, 20);
|
|
root_child0.setPadding(Edge.Top, 20);
|
|
root_child0.setPadding(Edge.Right, 20);
|
|
root_child0.setPadding(Edge.Bottom, 20);
|
|
root_child0.setWidth(100);
|
|
root_child0.setHeight(100);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(200);
|
|
expect(root.getComputedHeight()).toBe(200);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(100);
|
|
expect(root_child0.getComputedTop()).toBe(100);
|
|
expect(root_child0.getComputedWidth()).toBe(100);
|
|
expect(root_child0.getComputedHeight()).toBe(100);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(200);
|
|
expect(root.getComputedHeight()).toBe(200);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(0);
|
|
expect(root_child0.getComputedTop()).toBe(100);
|
|
expect(root_child0.getComputedWidth()).toBe(100);
|
|
expect(root_child0.getComputedHeight()).toBe(100);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
test('physical_and_relative_edge_defined', () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setPositionType(PositionType.Absolute);
|
|
root.setPadding(Edge.Left, 20);
|
|
root.setPadding(Edge.End, 50);
|
|
root.setWidth(200);
|
|
root.setHeight(200);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setWidth("100%");
|
|
root_child0.setHeight(50);
|
|
root.insertChild(root_child0, 0);
|
|
root.calculateLayout(undefined, undefined, Direction.LTR);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(200);
|
|
expect(root.getComputedHeight()).toBe(200);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(20);
|
|
expect(root_child0.getComputedTop()).toBe(0);
|
|
expect(root_child0.getComputedWidth()).toBe(130);
|
|
expect(root_child0.getComputedHeight()).toBe(50);
|
|
|
|
root.calculateLayout(undefined, undefined, Direction.RTL);
|
|
|
|
expect(root.getComputedLeft()).toBe(0);
|
|
expect(root.getComputedTop()).toBe(0);
|
|
expect(root.getComputedWidth()).toBe(200);
|
|
expect(root.getComputedHeight()).toBe(200);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(50);
|
|
expect(root_child0.getComputedTop()).toBe(0);
|
|
expect(root_child0.getComputedWidth()).toBe(150);
|
|
expect(root_child0.getComputedHeight()).toBe(50);
|
|
} finally {
|
|
if (typeof root !== 'undefined') {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|