mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
87 lines
1.9 KiB
Go
87 lines
1.9 KiB
Go
package kv_test
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"sync"
|
|
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
// commandRecorder records the last N commands executed by a KV client.
|
|
type commandRecorder struct {
|
|
mu sync.Mutex
|
|
commands []string
|
|
maxSize int
|
|
}
|
|
|
|
// newCommandRecorder creates a new command recorder with the specified maximum size.
|
|
func newCommandRecorder(maxSize int) *commandRecorder {
|
|
return &commandRecorder{
|
|
commands: make([]string, 0, maxSize),
|
|
maxSize: maxSize,
|
|
}
|
|
}
|
|
|
|
// Record adds a command to the recorder.
|
|
func (r *commandRecorder) Record(cmd string) {
|
|
cmd = strings.ToLower(cmd)
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
r.commands = append(r.commands, cmd)
|
|
if len(r.commands) > r.maxSize {
|
|
r.commands = r.commands[1:]
|
|
}
|
|
}
|
|
|
|
// LastCommands returns a copy of the recorded commands.
|
|
func (r *commandRecorder) LastCommands() []string {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
return append([]string(nil), r.commands...)
|
|
}
|
|
|
|
// Contains checks if the recorder contains a specific command.
|
|
func (r *commandRecorder) Contains(cmd string) bool {
|
|
cmd = strings.ToLower(cmd)
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
for _, c := range r.commands {
|
|
if strings.Contains(c, cmd) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// Hook returns a KV hook that records commands.
|
|
func (r *commandRecorder) Hook() kv.Hook {
|
|
return &commandHook{recorder: r}
|
|
}
|
|
|
|
// commandHook implements the kv.Hook interface to record commands.
|
|
type commandHook struct {
|
|
recorder *commandRecorder
|
|
}
|
|
|
|
func (h *commandHook) DialHook(next kv.DialHook) kv.DialHook {
|
|
return next
|
|
}
|
|
|
|
func (h *commandHook) ProcessHook(next kv.ProcessHook) kv.ProcessHook {
|
|
return func(ctx context.Context, cmd kv.Cmder) error {
|
|
h.recorder.Record(cmd.String())
|
|
return next(ctx, cmd)
|
|
}
|
|
}
|
|
|
|
func (h *commandHook) ProcessPipelineHook(next kv.ProcessPipelineHook) kv.ProcessPipelineHook {
|
|
return func(ctx context.Context, cmds []kv.Cmder) error {
|
|
for _, cmd := range cmds {
|
|
h.recorder.Record(cmd.String())
|
|
}
|
|
return next(ctx, cmds)
|
|
}
|
|
}
|