mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
68 lines
1.9 KiB
Go
68 lines
1.9 KiB
Go
package kv_test
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
|
|
. "github.com/bsm/ginkgo/v2"
|
|
. "github.com/bsm/gomega"
|
|
"github.com/hanzokv/go/v9"
|
|
"github.com/hanzokv/go/v9/internal/proto"
|
|
)
|
|
|
|
type testTimeout struct {
|
|
timeout bool
|
|
}
|
|
|
|
func (t testTimeout) Timeout() bool {
|
|
return t.timeout
|
|
}
|
|
|
|
func (t testTimeout) Error() string {
|
|
return "test timeout"
|
|
}
|
|
|
|
var _ = Describe("error", func() {
|
|
BeforeEach(func() {
|
|
|
|
})
|
|
|
|
AfterEach(func() {
|
|
|
|
})
|
|
|
|
It("should retry", func() {
|
|
data := map[error]bool{
|
|
io.EOF: true,
|
|
io.ErrUnexpectedEOF: true,
|
|
nil: false,
|
|
context.Canceled: false,
|
|
context.DeadlineExceeded: false,
|
|
kv.ErrPoolTimeout: true,
|
|
// Use typed errors instead of plain errors.New()
|
|
proto.ParseErrorReply([]byte("-ERR max number of clients reached")): true,
|
|
proto.ParseErrorReply([]byte("-LOADING KV is loading the dataset in memory")): true,
|
|
proto.ParseErrorReply([]byte("-READONLY You can't write against a read only replica")): true,
|
|
proto.ParseErrorReply([]byte("-CLUSTERDOWN The cluster is down")): true,
|
|
proto.ParseErrorReply([]byte("-TRYAGAIN Command cannot be processed, please try again")): true,
|
|
proto.ParseErrorReply([]byte("-NOREPLICAS Not enough good replicas to write")): true,
|
|
proto.ParseErrorReply([]byte("-ERR other")): false,
|
|
}
|
|
|
|
for err, expected := range data {
|
|
Expect(kv.ShouldRetry(err, false)).To(Equal(expected))
|
|
Expect(kv.ShouldRetry(err, true)).To(Equal(expected))
|
|
}
|
|
})
|
|
|
|
It("should retry timeout", func() {
|
|
t1 := testTimeout{timeout: true}
|
|
Expect(kv.ShouldRetry(t1, true)).To(Equal(true))
|
|
Expect(kv.ShouldRetry(t1, false)).To(Equal(false))
|
|
|
|
t2 := testTimeout{timeout: false}
|
|
Expect(kv.ShouldRetry(t2, true)).To(Equal(true))
|
|
Expect(kv.ShouldRetry(t2, false)).To(Equal(true))
|
|
})
|
|
})
|