mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
156 lines
2.6 KiB
Go
156 lines
2.6 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync"
|
|
"time"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
func main() {
|
|
ctx := context.Background()
|
|
|
|
rdb := kv.NewClient(&kv.Options{
|
|
Addr: ":6379",
|
|
})
|
|
|
|
_ = rdb.Set(ctx, "key_with_ttl", "bar", time.Minute).Err()
|
|
_ = rdb.Set(ctx, "key_without_ttl_1", "", 0).Err()
|
|
_ = rdb.Set(ctx, "key_without_ttl_2", "", 0).Err()
|
|
|
|
checker := NewKeyChecker(rdb, 100)
|
|
|
|
start := time.Now()
|
|
checker.Start(ctx)
|
|
|
|
iter := rdb.Scan(ctx, 0, "", 0).Iterator()
|
|
for iter.Next(ctx) {
|
|
checker.Add(iter.Val())
|
|
}
|
|
if err := iter.Err(); err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
deleted := checker.Stop()
|
|
fmt.Println("deleted", deleted, "keys", "in", time.Since(start))
|
|
}
|
|
|
|
type KeyChecker struct {
|
|
rdb *kv.Client
|
|
batchSize int
|
|
ch chan string
|
|
delCh chan string
|
|
wg sync.WaitGroup
|
|
deleted int
|
|
logger *zap.Logger
|
|
}
|
|
|
|
func NewKeyChecker(rdb *kv.Client, batchSize int) *KeyChecker {
|
|
return &KeyChecker{
|
|
rdb: rdb,
|
|
batchSize: batchSize,
|
|
ch: make(chan string, batchSize),
|
|
delCh: make(chan string, batchSize),
|
|
logger: zap.L(),
|
|
}
|
|
}
|
|
|
|
func (c *KeyChecker) Add(key string) {
|
|
c.ch <- key
|
|
}
|
|
|
|
func (c *KeyChecker) Start(ctx context.Context) {
|
|
c.wg.Add(1)
|
|
go func() {
|
|
defer c.wg.Done()
|
|
if err := c.del(ctx); err != nil {
|
|
panic(err)
|
|
}
|
|
}()
|
|
|
|
c.wg.Add(1)
|
|
go func() {
|
|
defer c.wg.Done()
|
|
defer close(c.delCh)
|
|
|
|
keys := make([]string, 0, c.batchSize)
|
|
|
|
for key := range c.ch {
|
|
keys = append(keys, key)
|
|
if len(keys) < cap(keys) {
|
|
continue
|
|
}
|
|
|
|
if err := c.checkKeys(ctx, keys); err != nil {
|
|
c.logger.Error("checkKeys failed", zap.Error(err))
|
|
}
|
|
keys = keys[:0]
|
|
}
|
|
|
|
if len(keys) > 0 {
|
|
if err := c.checkKeys(ctx, keys); err != nil {
|
|
c.logger.Error("checkKeys failed", zap.Error(err))
|
|
}
|
|
keys = nil
|
|
}
|
|
}()
|
|
}
|
|
|
|
func (c *KeyChecker) Stop() int {
|
|
close(c.ch)
|
|
c.wg.Wait()
|
|
return c.deleted
|
|
}
|
|
|
|
func (c *KeyChecker) checkKeys(ctx context.Context, keys []string) error {
|
|
cmds, err := c.rdb.Pipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
for _, key := range keys {
|
|
pipe.TTL(ctx, key)
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for i, cmd := range cmds {
|
|
d, err := cmd.(*kv.DurationCmd).Result()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if d == -1 {
|
|
c.delCh <- keys[i]
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *KeyChecker) del(ctx context.Context) error {
|
|
pipe := c.rdb.Pipeline()
|
|
|
|
for key := range c.delCh {
|
|
fmt.Printf("deleting %s...\n", key)
|
|
pipe.Del(ctx, key)
|
|
c.deleted++
|
|
|
|
if pipe.Len() < c.batchSize {
|
|
continue
|
|
}
|
|
|
|
if _, err := pipe.Exec(ctx); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if _, err := pipe.Exec(ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|