mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
77 lines
1.6 KiB
Go
77 lines
1.6 KiB
Go
package kvcensus
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
|
|
"go.opencensus.io/trace"
|
|
|
|
"github.com/hanzokv/go/extra/kvcmd/v9"
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
type TracingHook struct{}
|
|
|
|
var _ kv.Hook = (*TracingHook)(nil)
|
|
|
|
func NewTracingHook() *TracingHook {
|
|
return new(TracingHook)
|
|
}
|
|
|
|
func (TracingHook) DialHook(next kv.DialHook) kv.DialHook {
|
|
return func(ctx context.Context, network, addr string) (net.Conn, error) {
|
|
ctx, span := trace.StartSpan(ctx, "dial")
|
|
defer span.End()
|
|
|
|
span.AddAttributes(
|
|
trace.StringAttribute("db.system", "kv"),
|
|
trace.StringAttribute("network", network),
|
|
trace.StringAttribute("addr", addr),
|
|
)
|
|
|
|
conn, err := next(ctx, network, addr)
|
|
if err != nil {
|
|
recordErrorOnOCSpan(ctx, span, err)
|
|
|
|
return nil, err
|
|
}
|
|
|
|
return conn, nil
|
|
}
|
|
}
|
|
|
|
func (TracingHook) ProcessHook(next kv.ProcessHook) kv.ProcessHook {
|
|
return func(ctx context.Context, cmd kv.Cmder) error {
|
|
ctx, span := trace.StartSpan(ctx, cmd.FullName())
|
|
defer span.End()
|
|
|
|
span.AddAttributes(
|
|
trace.StringAttribute("db.system", "kv"),
|
|
trace.StringAttribute("kv.cmd", kvcmd.CmdString(cmd)),
|
|
)
|
|
|
|
err := next(ctx, cmd)
|
|
if err != nil {
|
|
recordErrorOnOCSpan(ctx, span, err)
|
|
return err
|
|
}
|
|
|
|
if err = cmd.Err(); err != nil {
|
|
recordErrorOnOCSpan(ctx, span, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func (TracingHook) ProcessPipelineHook(next kv.ProcessPipelineHook) kv.ProcessPipelineHook {
|
|
return next
|
|
}
|
|
|
|
func recordErrorOnOCSpan(ctx context.Context, span *trace.Span, err error) {
|
|
if err != kv.Nil {
|
|
span.AddAttributes(trace.BoolAttribute("error", true))
|
|
span.Annotate([]trace.Attribute{trace.StringAttribute("Error", "kv error")}, err.Error())
|
|
}
|
|
}
|