mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
132 lines
2.5 KiB
Go
132 lines
2.5 KiB
Go
package kvcmd
|
|
|
|
import (
|
|
"encoding/hex"
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
func CmdString(cmd kv.Cmder) string {
|
|
b := make([]byte, 0, 32)
|
|
b = AppendCmd(b, cmd)
|
|
return String(b)
|
|
}
|
|
|
|
func CmdsString(cmds []kv.Cmder) (string, string) {
|
|
const numNameLimit = 10
|
|
|
|
seen := make(map[string]struct{}, numNameLimit)
|
|
unqNames := make([]string, 0, numNameLimit)
|
|
|
|
b := make([]byte, 0, 32*len(cmds))
|
|
|
|
for i, cmd := range cmds {
|
|
if i > 0 {
|
|
b = append(b, '\n')
|
|
}
|
|
b = AppendCmd(b, cmd)
|
|
|
|
if len(unqNames) >= numNameLimit {
|
|
continue
|
|
}
|
|
|
|
name := cmd.FullName()
|
|
if _, ok := seen[name]; !ok {
|
|
seen[name] = struct{}{}
|
|
unqNames = append(unqNames, name)
|
|
}
|
|
}
|
|
|
|
summary := strings.Join(unqNames, " ")
|
|
return summary, String(b)
|
|
}
|
|
|
|
func AppendCmd(b []byte, cmd kv.Cmder) []byte {
|
|
for i, arg := range cmd.Args() {
|
|
if i > 0 {
|
|
b = append(b, ' ')
|
|
}
|
|
b = appendArg(b, arg)
|
|
}
|
|
|
|
if err := cmd.Err(); err != nil {
|
|
b = append(b, ": "...)
|
|
b = append(b, err.Error()...)
|
|
}
|
|
|
|
return b
|
|
}
|
|
|
|
func appendArg(b []byte, v interface{}) []byte {
|
|
switch v := v.(type) {
|
|
case nil:
|
|
return append(b, "<nil>"...)
|
|
case string:
|
|
return appendUTF8String(b, Bytes(v))
|
|
case []byte:
|
|
return appendUTF8String(b, v)
|
|
case int:
|
|
return strconv.AppendInt(b, int64(v), 10)
|
|
case int8:
|
|
return strconv.AppendInt(b, int64(v), 10)
|
|
case int16:
|
|
return strconv.AppendInt(b, int64(v), 10)
|
|
case int32:
|
|
return strconv.AppendInt(b, int64(v), 10)
|
|
case int64:
|
|
return strconv.AppendInt(b, v, 10)
|
|
case uint:
|
|
return strconv.AppendUint(b, uint64(v), 10)
|
|
case uint8:
|
|
return strconv.AppendUint(b, uint64(v), 10)
|
|
case uint16:
|
|
return strconv.AppendUint(b, uint64(v), 10)
|
|
case uint32:
|
|
return strconv.AppendUint(b, uint64(v), 10)
|
|
case uint64:
|
|
return strconv.AppendUint(b, v, 10)
|
|
case float32:
|
|
return strconv.AppendFloat(b, float64(v), 'f', -1, 64)
|
|
case float64:
|
|
return strconv.AppendFloat(b, v, 'f', -1, 64)
|
|
case bool:
|
|
if v {
|
|
return append(b, "true"...)
|
|
}
|
|
return append(b, "false"...)
|
|
case time.Time:
|
|
return v.AppendFormat(b, time.RFC3339Nano)
|
|
default:
|
|
return append(b, fmt.Sprint(v)...)
|
|
}
|
|
}
|
|
|
|
func appendUTF8String(dst []byte, src []byte) []byte {
|
|
if isSimple(src) {
|
|
dst = append(dst, src...)
|
|
return dst
|
|
}
|
|
|
|
s := len(dst)
|
|
dst = append(dst, make([]byte, hex.EncodedLen(len(src)))...)
|
|
hex.Encode(dst[s:], src)
|
|
return dst
|
|
}
|
|
|
|
func isSimple(b []byte) bool {
|
|
for _, c := range b {
|
|
if !isSimpleByte(c) {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
func isSimpleByte(c byte) bool {
|
|
return c >= 0x20 && c <= 0x7e
|
|
}
|