mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
55 lines
1.8 KiB
Go
55 lines
1.8 KiB
Go
package kvotel
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"go.opentelemetry.io/otel/attribute"
|
|
)
|
|
|
|
func Test_poolStatsAttrs(t *testing.T) {
|
|
t.Parallel()
|
|
type args struct {
|
|
conf *config
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantPoolAttrs attribute.Set
|
|
wantIdleAttrs attribute.Set
|
|
wantUsedAttrs attribute.Set
|
|
}{
|
|
{
|
|
name: "#3122",
|
|
args: func() args {
|
|
conf := &config{
|
|
attrs: make([]attribute.KeyValue, 0, 4),
|
|
}
|
|
conf.attrs = append(conf.attrs, attribute.String("foo1", "bar1"), attribute.String("foo2", "bar2"))
|
|
conf.attrs = append(conf.attrs, attribute.String("pool.name", "pool1"))
|
|
return args{conf: conf}
|
|
}(),
|
|
wantPoolAttrs: attribute.NewSet(attribute.String("foo1", "bar1"), attribute.String("foo2", "bar2"),
|
|
attribute.String("pool.name", "pool1")),
|
|
wantIdleAttrs: attribute.NewSet(attribute.String("foo1", "bar1"), attribute.String("foo2", "bar2"),
|
|
attribute.String("pool.name", "pool1"), attribute.String("state", "idle")),
|
|
wantUsedAttrs: attribute.NewSet(attribute.String("foo1", "bar1"), attribute.String("foo2", "bar2"),
|
|
attribute.String("pool.name", "pool1"), attribute.String("state", "used")),
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
gotPoolAttrs, gotIdleAttrs, gotUsedAttrs := poolStatsAttrs(tt.args.conf)
|
|
if !reflect.DeepEqual(gotPoolAttrs, tt.wantPoolAttrs) {
|
|
t.Errorf("poolStatsAttrs() gotPoolAttrs = %v, want %v", gotPoolAttrs, tt.wantPoolAttrs)
|
|
}
|
|
if !reflect.DeepEqual(gotIdleAttrs, tt.wantIdleAttrs) {
|
|
t.Errorf("poolStatsAttrs() gotIdleAttrs = %v, want %v", gotIdleAttrs, tt.wantIdleAttrs)
|
|
}
|
|
if !reflect.DeepEqual(gotUsedAttrs, tt.wantUsedAttrs) {
|
|
t.Errorf("poolStatsAttrs() gotUsedAttrs = %v, want %v", gotUsedAttrs, tt.wantUsedAttrs)
|
|
}
|
|
})
|
|
}
|
|
}
|