mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
131 lines
3.2 KiB
Go
131 lines
3.2 KiB
Go
package kv_test
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
. "github.com/bsm/ginkgo/v2"
|
|
. "github.com/bsm/gomega"
|
|
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
var _ = Describe("pool", func() {
|
|
var client *kv.Client
|
|
|
|
BeforeEach(func() {
|
|
opt := kvOptions()
|
|
opt.MinIdleConns = 0
|
|
opt.ConnMaxLifetime = 0
|
|
opt.ConnMaxIdleTime = time.Second
|
|
client = kv.NewClient(opt)
|
|
})
|
|
|
|
AfterEach(func() {
|
|
Expect(client.Close()).NotTo(HaveOccurred())
|
|
})
|
|
|
|
It("respects max size", func() {
|
|
perform(1000, func(id int) {
|
|
val, err := client.Ping(ctx).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal("PONG"))
|
|
})
|
|
|
|
pool := client.Pool()
|
|
Expect(pool.Len()).To(BeNumerically("<=", 10))
|
|
Expect(pool.IdleLen()).To(BeNumerically("<=", 10))
|
|
Expect(pool.Len()).To(Equal(pool.IdleLen()))
|
|
})
|
|
|
|
It("respects max size on multi", func() {
|
|
perform(1000, func(id int) {
|
|
var ping *kv.StatusCmd
|
|
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
cmds, err := tx.Pipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
ping = pipe.Ping(ctx)
|
|
return nil
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(cmds).To(HaveLen(1))
|
|
return err
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
Expect(ping.Err()).NotTo(HaveOccurred())
|
|
Expect(ping.Val()).To(Equal("PONG"))
|
|
})
|
|
|
|
pool := client.Pool()
|
|
Expect(pool.Len()).To(BeNumerically("<=", 10))
|
|
Expect(pool.IdleLen()).To(BeNumerically("<=", 10))
|
|
Expect(pool.Len()).To(Equal(pool.IdleLen()))
|
|
})
|
|
|
|
It("respects max size on pipelines", func() {
|
|
perform(1000, func(id int) {
|
|
pipe := client.Pipeline()
|
|
ping := pipe.Ping(ctx)
|
|
cmds, err := pipe.Exec(ctx)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(cmds).To(HaveLen(1))
|
|
Expect(ping.Err()).NotTo(HaveOccurred())
|
|
Expect(ping.Val()).To(Equal("PONG"))
|
|
})
|
|
|
|
pool := client.Pool()
|
|
Expect(pool.Len()).To(BeNumerically("<=", 10))
|
|
Expect(pool.IdleLen()).To(BeNumerically("<=", 10))
|
|
Expect(pool.Len()).To(Equal(pool.IdleLen()))
|
|
})
|
|
|
|
It("removes broken connections", func() {
|
|
cn, err := client.Pool().Get(context.Background())
|
|
Expect(err).NotTo(HaveOccurred())
|
|
cn.SetNetConn(&badConn{})
|
|
client.Pool().Put(ctx, cn)
|
|
|
|
val, err := client.Ping(ctx).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal("PONG"))
|
|
|
|
val, err = client.Ping(ctx).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal("PONG"))
|
|
|
|
pool := client.Pool()
|
|
Expect(pool.Len()).To(Equal(1))
|
|
Expect(pool.IdleLen()).To(Equal(1))
|
|
|
|
stats := pool.Stats()
|
|
Expect(stats.Hits).To(Equal(uint32(1)))
|
|
Expect(stats.Misses).To(Equal(uint32(2)))
|
|
Expect(stats.Timeouts).To(Equal(uint32(0)))
|
|
})
|
|
|
|
It("reuses connections", func() {
|
|
// explain: https://github.com/hanzokv/go/pull/1675
|
|
opt := kvOptions()
|
|
opt.MinIdleConns = 0
|
|
opt.ConnMaxLifetime = 0
|
|
opt.ConnMaxIdleTime = 10 * time.Second
|
|
client = kv.NewClient(opt)
|
|
|
|
for i := 0; i < 100; i++ {
|
|
val, err := client.Ping(ctx).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal("PONG"))
|
|
}
|
|
|
|
pool := client.Pool()
|
|
Expect(pool.Len()).To(Equal(1))
|
|
Expect(pool.IdleLen()).To(Equal(1))
|
|
|
|
stats := pool.Stats()
|
|
Expect(stats.Hits).To(Equal(uint32(99)))
|
|
Expect(stats.Misses).To(Equal(uint32(1)))
|
|
Expect(stats.Timeouts).To(Equal(uint32(0)))
|
|
})
|
|
})
|