mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
320 lines
6.9 KiB
Go
320 lines
6.9 KiB
Go
package kv_test
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"net"
|
|
"strconv"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
. "github.com/bsm/ginkgo/v2"
|
|
. "github.com/bsm/gomega"
|
|
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
var _ = Describe("races", func() {
|
|
var client *kv.Client
|
|
var C, N int
|
|
|
|
BeforeEach(func() {
|
|
client = kv.NewClient(kvOptions())
|
|
Expect(client.FlushDB(ctx).Err()).To(BeNil())
|
|
|
|
C, N = 10, 1000
|
|
if testing.Short() {
|
|
C = 4
|
|
N = 100
|
|
}
|
|
})
|
|
|
|
AfterEach(func() {
|
|
err := client.Close()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
})
|
|
|
|
It("should echo", func() {
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
msg := fmt.Sprintf("echo %d %d", id, i)
|
|
echo, err := client.Echo(ctx, msg).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(echo).To(Equal(msg))
|
|
}
|
|
})
|
|
})
|
|
|
|
It("should incr", func() {
|
|
key := "TestIncrFromGoroutines"
|
|
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
err := client.Incr(ctx, key).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
})
|
|
|
|
val, err := client.Get(ctx, key).Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal(int64(C * N)))
|
|
})
|
|
|
|
It("should handle many keys", func() {
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
err := client.Set(
|
|
ctx,
|
|
fmt.Sprintf("keys.key-%d-%d", id, i),
|
|
fmt.Sprintf("hello-%d-%d", id, i),
|
|
0,
|
|
).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
})
|
|
|
|
keys := client.Keys(ctx, "keys.*")
|
|
Expect(keys.Err()).NotTo(HaveOccurred())
|
|
Expect(len(keys.Val())).To(Equal(C * N))
|
|
})
|
|
|
|
It("should handle many keys 2", func() {
|
|
perform(C, func(id int) {
|
|
keys := []string{"non-existent-key"}
|
|
for i := 0; i < N; i++ {
|
|
key := fmt.Sprintf("keys.key-%d", i)
|
|
keys = append(keys, key)
|
|
|
|
err := client.Set(ctx, key, fmt.Sprintf("hello-%d", i), 0).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
keys = append(keys, "non-existent-key")
|
|
|
|
vals, err := client.MGet(ctx, keys...).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(len(vals)).To(Equal(N + 2))
|
|
|
|
for i := 0; i < N; i++ {
|
|
Expect(vals[i+1]).To(Equal(fmt.Sprintf("hello-%d", i)))
|
|
}
|
|
|
|
Expect(vals[0]).To(BeNil())
|
|
Expect(vals[N+1]).To(BeNil())
|
|
})
|
|
})
|
|
|
|
It("should handle big vals in Get", func() {
|
|
C, N := 4, 100
|
|
|
|
bigVal := bigVal()
|
|
|
|
err := client.Set(ctx, "key", bigVal, 0).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
// Reconnect to get new connection.
|
|
Expect(client.Close()).To(BeNil())
|
|
client = kv.NewClient(kvOptions())
|
|
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
got, err := client.Get(ctx, "key").Bytes()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(got).To(Equal(bigVal))
|
|
}
|
|
})
|
|
})
|
|
|
|
It("should handle big vals in Set", func() {
|
|
C, N := 4, 100
|
|
|
|
bigVal := bigVal()
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
err := client.Set(ctx, "key", bigVal, 0).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
})
|
|
})
|
|
|
|
It("should select db", Label("NonKVEnterprise"), func() {
|
|
err := client.Set(ctx, "db", 0, 0).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
perform(C, func(id int) {
|
|
opt := kvOptions()
|
|
opt.DB = id
|
|
client := kv.NewClient(opt)
|
|
for i := 0; i < N; i++ {
|
|
err := client.Set(ctx, "db", id, 0).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
n, err := client.Get(ctx, "db").Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(n).To(Equal(int64(id)))
|
|
}
|
|
err := client.Close()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
})
|
|
|
|
n, err := client.Get(ctx, "db").Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(n).To(Equal(int64(0)))
|
|
})
|
|
|
|
It("should select DB with read timeout", func() {
|
|
perform(C, func(id int) {
|
|
opt := kvOptions()
|
|
opt.DB = id
|
|
opt.ReadTimeout = time.Nanosecond
|
|
client := kv.NewClient(opt)
|
|
|
|
perform(C, func(id int) {
|
|
err := client.Ping(ctx).Err()
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(err.(net.Error).Timeout()).To(BeTrue())
|
|
})
|
|
|
|
err := client.Close()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
})
|
|
})
|
|
|
|
It("should Watch/Unwatch", func() {
|
|
err := client.Set(ctx, "key", "0", 0).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
val, err := tx.Get(ctx, "key").Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).NotTo(Equal(kv.Nil))
|
|
|
|
num, err := strconv.ParseInt(val, 10, 64)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
cmds, err := tx.TxPipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
pipe.Set(ctx, "key", strconv.FormatInt(num+1, 10), 0)
|
|
return nil
|
|
})
|
|
Expect(cmds).To(HaveLen(1))
|
|
return err
|
|
}, "key")
|
|
if err == kv.TxFailedErr {
|
|
i--
|
|
continue
|
|
}
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
})
|
|
|
|
val, err := client.Get(ctx, "key").Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal(int64(C * N)))
|
|
})
|
|
|
|
It("should BLPop", func() {
|
|
C := 5
|
|
N := 5
|
|
var received uint32
|
|
|
|
wg := performAsync(C, func(id int) {
|
|
for {
|
|
v, err := client.BLPop(ctx, time.Second, "list").Result()
|
|
if err != nil {
|
|
if err == kv.Nil {
|
|
break
|
|
}
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
Expect(v).To(Equal([]string{"list", "hello"}))
|
|
atomic.AddUint32(&received, 1)
|
|
}
|
|
})
|
|
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
err := client.LPush(ctx, "list", "hello").Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
})
|
|
|
|
wg.Wait()
|
|
Expect(atomic.LoadUint32(&received)).To(Equal(uint32(C * N)))
|
|
})
|
|
})
|
|
|
|
var _ = Describe("cluster races", Label("NonKVEnterprise"), func() {
|
|
var client *kv.ClusterClient
|
|
var C, N int
|
|
|
|
BeforeEach(func() {
|
|
opt := kvClusterOptions()
|
|
client = cluster.newClusterClient(ctx, opt)
|
|
|
|
C, N = 10, 1000
|
|
if testing.Short() {
|
|
C = 4
|
|
N = 100
|
|
}
|
|
})
|
|
|
|
AfterEach(func() {
|
|
err := client.Close()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
})
|
|
|
|
It("should echo", func() {
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
msg := fmt.Sprintf("echo %d %d", id, i)
|
|
echo, err := client.Echo(ctx, msg).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(echo).To(Equal(msg))
|
|
}
|
|
})
|
|
})
|
|
|
|
It("should get", func() {
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
key := fmt.Sprintf("key_%d_%d", id, i)
|
|
_, err := client.Get(ctx, key).Result()
|
|
Expect(err).To(Equal(kv.Nil))
|
|
}
|
|
})
|
|
})
|
|
|
|
It("should incr", func() {
|
|
key := "TestIncrFromGoroutines"
|
|
|
|
perform(C, func(id int) {
|
|
for i := 0; i < N; i++ {
|
|
err := client.Incr(ctx, key).Err()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}
|
|
})
|
|
|
|
val, err := client.Get(ctx, key).Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(val).To(Equal(int64(C * N)))
|
|
})
|
|
|
|
It("write cmd data-race", func() {
|
|
pubsub := client.Subscribe(ctx)
|
|
defer pubsub.Close()
|
|
|
|
pubsub.Channel(kv.WithChannelHealthCheckInterval(time.Millisecond))
|
|
for i := 0; i < 100; i++ {
|
|
key := fmt.Sprintf("channel_%d", i)
|
|
pubsub.Subscribe(ctx, key)
|
|
pubsub.Unsubscribe(ctx, key)
|
|
}
|
|
})
|
|
})
|
|
|
|
func bigVal() []byte {
|
|
return bytes.Repeat([]byte{'*'}, 1<<17) // 128kb
|
|
}
|