mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
zeekay
6994cf05aa
We do not use Redis. The client was a go-redis fork and still said so
everywhere: `package redis`, `redis.NewClient`, `redis://`, `extra/redisotel`.
Consumers wrote `redis.Client` against a Valkey-backed store called KV.
package redis -> package kv (93 decls)
redis.X -> kv.X (2,794 call sites)
"redis: …" errors -> "kv: …" (206)
extra/redis{otel,cmd,prometheus,census} -> extra/kv{otel,cmd,prometheus,census}
redis:// , rediss:// -> kv:// , kvs:// (ParseURL)
Redis*/*Redis* idents -> KV*/*KV*
REDIS_VERSION, REDIS_ENDPOINTS_CONFIG_PATH -> KV_*
I previously argued this rename was unsafe because much of it was "wire
contract". That was wrong, and the categorisation shows why: RESP command names
are GET/SET/HSET — they never contain the word. Of 5,771 occurrences only two
kinds were server-visible at all: the ParseURL scheme (we choose what we pass;
our configs already use kv://) and the CLIENT SETINFO lib-name label, which the
server merely records. Nothing here changes a byte of protocol.
Two things deliberately keep the old spelling:
RediSearch — names a specific external module the FT.* commands map to.
StoreDist — contains the letters by accident (sto-reDis-t), not the word.
Breaking for consumers by design: every import site must move redis.X -> kv.X.
Minor bump, never a major — this module stays v9 forever.
149 lines
3.3 KiB
Go
149 lines
3.3 KiB
Go
package kv_test
|
|
|
|
import (
|
|
"context"
|
|
"strconv"
|
|
"sync"
|
|
|
|
. "github.com/bsm/ginkgo/v2"
|
|
. "github.com/bsm/gomega"
|
|
|
|
"github.com/hanzokv/go/v9"
|
|
)
|
|
|
|
var _ = Describe("Tx", func() {
|
|
var client *kv.Client
|
|
|
|
BeforeEach(func() {
|
|
client = kv.NewClient(kvOptions())
|
|
Expect(client.FlushDB(ctx).Err()).NotTo(HaveOccurred())
|
|
})
|
|
|
|
AfterEach(func() {
|
|
Expect(client.Close()).NotTo(HaveOccurred())
|
|
})
|
|
|
|
It("should Watch", func() {
|
|
var incr func(string) error
|
|
|
|
// Transactionally increments key using GET and SET commands.
|
|
incr = func(key string) error {
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
n, err := tx.Get(ctx, key).Int64()
|
|
if err != nil && err != kv.Nil {
|
|
return err
|
|
}
|
|
|
|
_, err = tx.TxPipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
pipe.Set(ctx, key, strconv.FormatInt(n+1, 10), 0)
|
|
return nil
|
|
})
|
|
return err
|
|
}, key)
|
|
if err == kv.TxFailedErr {
|
|
return incr(key)
|
|
}
|
|
return err
|
|
}
|
|
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 100; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer GinkgoRecover()
|
|
defer wg.Done()
|
|
|
|
err := incr("key")
|
|
Expect(err).NotTo(HaveOccurred())
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
|
|
n, err := client.Get(ctx, "key").Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(n).To(Equal(int64(100)))
|
|
})
|
|
|
|
It("should discard", Label("NonKVEnterprise"), func() {
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
cmds, err := tx.TxPipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
pipe.Set(ctx, "key1", "hello1", 0)
|
|
pipe.Discard()
|
|
pipe.Set(ctx, "key2", "hello2", 0)
|
|
return nil
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(cmds).To(HaveLen(1))
|
|
return err
|
|
}, "key1", "key2")
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
get := client.Get(ctx, "key1")
|
|
Expect(get.Err()).To(Equal(kv.Nil))
|
|
Expect(get.Val()).To(Equal(""))
|
|
|
|
get = client.Get(ctx, "key2")
|
|
Expect(get.Err()).NotTo(HaveOccurred())
|
|
Expect(get.Val()).To(Equal("hello2"))
|
|
})
|
|
|
|
It("returns no error when there are no commands", func() {
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
_, err := tx.TxPipelined(ctx, func(kv.Pipeliner) error { return nil })
|
|
return err
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
v, err := client.Ping(ctx).Result()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(v).To(Equal("PONG"))
|
|
})
|
|
|
|
It("should exec bulks", func() {
|
|
const N = 20000
|
|
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
cmds, err := tx.TxPipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
for i := 0; i < N; i++ {
|
|
pipe.Incr(ctx, "key")
|
|
}
|
|
return nil
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(len(cmds)).To(Equal(N))
|
|
for _, cmd := range cmds {
|
|
Expect(cmd.Err()).NotTo(HaveOccurred())
|
|
}
|
|
return err
|
|
})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
num, err := client.Get(ctx, "key").Int64()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(num).To(Equal(int64(N)))
|
|
})
|
|
|
|
It("should recover from bad connection", func() {
|
|
// Put bad connection in the pool.
|
|
cn, err := client.Pool().Get(context.Background())
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
cn.SetNetConn(&badConn{})
|
|
client.Pool().Put(ctx, cn)
|
|
|
|
do := func() error {
|
|
err := client.Watch(ctx, func(tx *kv.Tx) error {
|
|
_, err := tx.TxPipelined(ctx, func(pipe kv.Pipeliner) error {
|
|
pipe.Ping(ctx)
|
|
return nil
|
|
})
|
|
return err
|
|
})
|
|
return err
|
|
}
|
|
|
|
err = do()
|
|
Expect(err).NotTo(HaveOccurred())
|
|
})
|
|
})
|