mirror of
https://github.com/hanzokv/go.git
synced 2026-09-24 00:31:51 +00:00
c4770cde7c
When a Lua script containing a write command is executed against a read-only replica in a Redis Cluster, the error may contain "-READONLY You can't write against a read only replica" embedded within a larger error message rather than starting with "READONLY ". The existing code only checked for the "READONLY " prefix, missing this format. This caused shouldRetry() and isReadOnlyError() to fail, preventing automatic retry and connection pool cleanup. The fix checks for the exact substring "-READONLY You can't write against a read only replica" which is specific enough to avoid false positives while catching the Lua script error format. Closes #2770 Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
69 lines
2.2 KiB
Go
69 lines
2.2 KiB
Go
package redis_test
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
|
|
. "github.com/bsm/ginkgo/v2"
|
|
. "github.com/bsm/gomega"
|
|
"github.com/redis/go-redis/v9"
|
|
"github.com/redis/go-redis/v9/internal/proto"
|
|
)
|
|
|
|
type testTimeout struct {
|
|
timeout bool
|
|
}
|
|
|
|
func (t testTimeout) Timeout() bool {
|
|
return t.timeout
|
|
}
|
|
|
|
func (t testTimeout) Error() string {
|
|
return "test timeout"
|
|
}
|
|
|
|
var _ = Describe("error", func() {
|
|
BeforeEach(func() {
|
|
|
|
})
|
|
|
|
AfterEach(func() {
|
|
|
|
})
|
|
|
|
It("should retry", func() {
|
|
data := map[error]bool{
|
|
io.EOF: true,
|
|
io.ErrUnexpectedEOF: true,
|
|
nil: false,
|
|
context.Canceled: false,
|
|
context.DeadlineExceeded: false,
|
|
redis.ErrPoolTimeout: true,
|
|
// Use typed errors instead of plain errors.New()
|
|
proto.ParseErrorReply([]byte("-ERR max number of clients reached")): true,
|
|
proto.ParseErrorReply([]byte("-LOADING Redis is loading the dataset in memory")): true,
|
|
proto.ParseErrorReply([]byte("-READONLY You can't write against a read only replica")): true,
|
|
proto.ParseErrorReply([]byte("-ERR Error running script (call to f_abc123): @user_script:1: -READONLY You can't write against a read only replica.")): true,
|
|
proto.ParseErrorReply([]byte("-CLUSTERDOWN The cluster is down")): true,
|
|
proto.ParseErrorReply([]byte("-TRYAGAIN Command cannot be processed, please try again")): true,
|
|
proto.ParseErrorReply([]byte("-NOREPLICAS Not enough good replicas to write")): true,
|
|
proto.ParseErrorReply([]byte("-ERR other")): false,
|
|
}
|
|
|
|
for err, expected := range data {
|
|
Expect(redis.ShouldRetry(err, false)).To(Equal(expected))
|
|
Expect(redis.ShouldRetry(err, true)).To(Equal(expected))
|
|
}
|
|
})
|
|
|
|
It("should retry timeout", func() {
|
|
t1 := testTimeout{timeout: true}
|
|
Expect(redis.ShouldRetry(t1, true)).To(Equal(true))
|
|
Expect(redis.ShouldRetry(t1, false)).To(Equal(false))
|
|
|
|
t2 := testTimeout{timeout: false}
|
|
Expect(redis.ShouldRetry(t2, true)).To(Equal(true))
|
|
Expect(redis.ShouldRetry(t2, false)).To(Equal(true))
|
|
})
|
|
})
|