mirror of
https://github.com/hanzokv/lock.git
synced 2026-10-30 15:07:01 +00:00
zeekayandHanzo Dev
1ad510e19d
github.com/hanzokv/go/v9 v9.22.0 renamed its Go package from "redis" to "kv"; the import path is unchanged. A lock library is typed against the client it wraps -- the adapter's NewPool takes the client's UniversalClient and compares against the client's Nil sentinel -- so the qualifier change is load bearing, not cosmetic. Client-driven: - go.mod: github.com/hanzokv/go/v9 v9.21.1 -> v9.22.0 - the adapter for our client speaks kv.UniversalClient / kv.Nil, imported unaliased as in hanzokv/go's own sources Our own vocabulary follows: - redis/ -> kv/, package redis -> package kv. This is redsync's own Pool/Conn/Script abstraction over a KV backend, not anyone's product. - redis/goredis/v9 -> kv/kvgo (package kvgo). That adapter wraps hanzokv/go, not go-redis; the old name said the wrong thing. Its example moves with it: examples/goredis/v9 -> examples/kvgo. - import alias redsyncredis -> redsynckv - RedisError -> KVError (and its tests) - comments and README speak kv Deliberately NOT renamed, because they name foreign things: - the redigo, rueidis, valkeygo and go-redis v6/v7/v8 adapters, which target genuinely different clients, keep their names and their own "redis." qualifiers (redigo's redis.Conn, go-redis's redis.Nil) - the server-side Lua in scripts.go: redis.call is the store's scripting API. Rewriting it would change the script source and therefore the SHA1 hashes pinned in scripts.go, which TestScripts_Hash verifies against a live server. - upstream links (redis.io distlock post, redigo attribution) Import paths move from .../v4/redis/... to .../v4/kv/...; the module major stays v4 by policy. Verified with a local redis-server: go build ./..., go vet ./..., go test -count=1 ./... and go test -race -count=1 ./... all pass, TestScripts_Hash included. Co-authored-by: Hanzo Dev <[email protected]>
64 lines
1020 B
Go
64 lines
1020 B
Go
package redsync
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func TestKVErrorIs(t *testing.T) {
|
|
cases := map[string]error{
|
|
"defined_error": ErrFailed,
|
|
"other_error": errors.New("other error"),
|
|
"wrapping_error": fmt.Errorf("wrapping: %w", ErrFailed),
|
|
}
|
|
|
|
for k, v := range cases {
|
|
|
|
t.Run(k, func(t *testing.T) {
|
|
err := KVError{
|
|
Node: 0,
|
|
Err: v,
|
|
}
|
|
|
|
if !errors.Is(err, v) {
|
|
t.Errorf("errors.Is must be true")
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestKVErrorAs(t *testing.T) {
|
|
derr := dummyError{}
|
|
|
|
cases := map[string]error{
|
|
"simple_error": derr,
|
|
"wrapping_error": fmt.Errorf("wrapping: %w", derr),
|
|
}
|
|
|
|
for k, v := range cases {
|
|
|
|
t.Run(k, func(t *testing.T) {
|
|
err := KVError{
|
|
Node: 0,
|
|
Err: v,
|
|
}
|
|
|
|
var target dummyError
|
|
if !errors.As(err, &target) {
|
|
t.Errorf("errors.As must be true")
|
|
}
|
|
|
|
if target != derr {
|
|
t.Errorf("Expected target == %q, got %q", derr, target)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
type dummyError struct{}
|
|
|
|
func (err dummyError) Error() string {
|
|
return "dummy"
|
|
}
|