mirror of
https://github.com/luxfi/graph.git
synced 2026-09-24 00:26:07 +00:00
zeekayandHanzo Dev
dfb9c57fc3
A client pages a pool's history as "the N trades before this time". The bound was applied by FilterResults after the database had already taken the newest N, so every page after the first threw its rows away and came back empty. It sits in the WHERE now, on the same index the pool does. Co-authored-by: Hanzo Dev <[email protected]>
90 lines
2.8 KiB
Go
90 lines
2.8 KiB
Go
//go:build !nosqlite
|
|
|
|
package storage
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// A pool's history is read through the index, not by scanning the chain.
|
|
//
|
|
// GetSwaps compares pool COLLATE NOCASE — the address arrives in whatever case
|
|
// the caller typed. SQLite consults an index only when its collation matches
|
|
// the comparison's, so an index on swaps(pool) alone was never used for that
|
|
// read, and a store that had already built it keeps it until told otherwise.
|
|
func TestPoolHistoryReadsTheIndex(t *testing.T) {
|
|
dir := t.TempDir()
|
|
old, err := New(dir)
|
|
if err != nil {
|
|
t.Fatalf("open store: %v", err)
|
|
}
|
|
// The store as it was, with the index that could not be used.
|
|
if _, err := old.db.Exec(`
|
|
CREATE TABLE swaps (id TEXT PRIMARY KEY, data JSON, timestamp INTEGER, pool TEXT, amountUSD REAL NOT NULL DEFAULT 0);
|
|
CREATE INDEX idx_swaps_pool ON swaps(pool);
|
|
`); err != nil {
|
|
t.Fatalf("old schema: %v", err)
|
|
}
|
|
old.Close()
|
|
|
|
s, err := New(dir)
|
|
if err != nil {
|
|
t.Fatalf("reopen store: %v", err)
|
|
}
|
|
defer s.Close()
|
|
if err := s.Init(context.Background()); err != nil {
|
|
t.Fatalf("init: %v", err)
|
|
}
|
|
rows, err := s.db.Query(`EXPLAIN QUERY PLAN SELECT id, data FROM swaps WHERE pool = ? COLLATE NOCASE ORDER BY timestamp DESC LIMIT 10`, "0xPOOL")
|
|
if err != nil {
|
|
t.Fatalf("explain: %v", err)
|
|
}
|
|
defer rows.Close()
|
|
var plan []string
|
|
for rows.Next() {
|
|
var id, parent, notused int
|
|
var detail string
|
|
if err := rows.Scan(&id, &parent, ¬used, &detail); err != nil {
|
|
t.Fatalf("scan: %v", err)
|
|
}
|
|
plan = append(plan, detail)
|
|
}
|
|
joined := strings.Join(plan, " | ")
|
|
if !strings.Contains(joined, "idx_swaps_pool_time") {
|
|
t.Fatalf("pool history is not read through idx_swaps_pool_time: %s", joined)
|
|
}
|
|
if strings.Contains(joined, "SCAN swaps") || strings.Contains(joined, "TEMP B-TREE") {
|
|
t.Fatalf("pool history still scans or sorts: %s", joined)
|
|
}
|
|
}
|
|
|
|
// The page before a cursor is the older trades, not the newest ones thrown away.
|
|
func TestPageBeforeCursorReachesOlderTrades(t *testing.T) {
|
|
s, err := New(t.TempDir())
|
|
if err != nil {
|
|
t.Fatalf("open store: %v", err)
|
|
}
|
|
defer s.Close()
|
|
if err := s.Init(context.Background()); err != nil {
|
|
t.Fatalf("init: %v", err)
|
|
}
|
|
for i := 1; i <= 6; i++ {
|
|
s.SeedSwap(fmt.Sprintf("s%d", i), &SeedSwapData{Timestamp: int64(i * 100), Pool: "0xpool", AmountUSD: "1"})
|
|
}
|
|
got, err := s.GetSwaps(context.Background(), 2, "timestamp", "desc", map[string]interface{}{"pool": "0xPOOL", "timestamp_lt": float64(400)})
|
|
if err != nil {
|
|
t.Fatalf("GetSwaps: %v", err)
|
|
}
|
|
rows := got.([]interface{})
|
|
if len(rows) != 2 {
|
|
t.Fatalf("want the 2 trades before t=400, got %d", len(rows))
|
|
}
|
|
ids := []string{rows[0].(map[string]interface{})["id"].(string), rows[1].(map[string]interface{})["id"].(string)}
|
|
if ids[0] != "s3" || ids[1] != "s2" {
|
|
t.Fatalf("want s3, s2 (newest first, before the cursor); got %v", ids)
|
|
}
|
|
}
|