mirror of
https://github.com/luxfi/mpc.git
synced 2026-09-24 00:26:24 +00:00
zeekay
fd8eb49dc7
Two defects found by capturing the console against production.
1. Every custody write path was dark because a VALID IAM token was
rejected. fetchUserInfo built <issuer>/oauth/userinfo, which the SPA
shell answers 200 text/html; the JSON decode then failed on '<' and
surfaced as 401 "failed to decode userinfo: invalid character '<'".
The issuer serves userinfo at /v1/iam/oauth/userinfo (401 JSON when
unauthenticated, as it should). The provider allowlist keys on the
issuer ORIGIN, so the /v1/iam prefix cannot be supplied by the caller
and belongs in this function.
Verified by hand against lux.id: authorization_code + S256 completes,
token endpoint 200, and userinfo at the /v1/iam path returns
{"email":"[email protected]","isAdmin":true,"owner":"lux"}.
2. /wallets/[id]/smart-wallets rendered two invented wallets: a "2-of-3"
Safe at 0x1234...abcd on Ethereum and an ERC-4337 account at
0x5678...efgh on 96369, both green and marked deployed, hardcoded
under a "TODO: fetch from API". They rendered for ANY key id.
A custody screen claiming a 2-of-3 multisig that exists on no chain is
not a placeholder, it is a false statement about where funds are — and
it contradicted lux.cloud's own honest "1 of 1 today, no ring
deployed". The list is now empty until the API is read.
The login page needs no change: it already uses @hanzo/iam startLogin
with PKCE. Production is serving an older build than main, which is why
it still requested the implicit response_type=token that this repo
removed.
Still required and NOT done here: register
https://mpc.lux.cloud/auth/callback on the lux-mpc IAM client, and
deploy. Neither is a code change.
72 lines
2.4 KiB
TypeScript
72 lines
2.4 KiB
TypeScript
'use client'
|
|
|
|
import { useState } from 'react'
|
|
import { useParams } from 'next/navigation'
|
|
import Link from 'next/link'
|
|
import { SmartWalletCard } from '@/components/smart-wallets/smart-wallet-card'
|
|
|
|
export interface SmartWallet {
|
|
id: string
|
|
type: 'safe' | 'erc4337'
|
|
chain: string
|
|
chainId: number
|
|
contractAddress: string
|
|
threshold: number
|
|
owners: string[]
|
|
status: 'deployed' | 'pending' | 'failed'
|
|
}
|
|
|
|
export default function SmartWalletsPage() {
|
|
const params = useParams<{ id: string }>()
|
|
|
|
// This list is empty until the API is read. It previously held two invented
|
|
// wallets — a "2-of-3" Safe at 0x1234...abcd and an ERC-4337 account at
|
|
// 0x5678...efgh — both marked deployed. They rendered for ANY key id, so a
|
|
// custody screen advertised a multisig that does not exist on any chain.
|
|
// An empty list is the honest state; placeholders on a custody surface are
|
|
// not a stand-in for data, they are a false claim about where funds are.
|
|
const [wallets] = useState<SmartWallet[]>([])
|
|
|
|
return (
|
|
<div className="mx-auto max-w-4xl space-y-8 px-4 py-8">
|
|
<div className="flex items-center justify-between">
|
|
<div>
|
|
<h1 className="text-2xl font-semibold tracking-tight">
|
|
Smart Wallets
|
|
</h1>
|
|
<p className="mt-1 text-sm text-muted-foreground">
|
|
Smart contract wallets backed by MPC key{' '}
|
|
<span className="font-mono">{params.id}</span>
|
|
</p>
|
|
</div>
|
|
<Link
|
|
href={`/wallets/${params.id}/smart-wallets/deploy`}
|
|
className="rounded-md bg-primary px-4 py-2 text-sm font-medium text-primary-foreground hover:bg-primary/90"
|
|
>
|
|
Deploy Smart Wallet
|
|
</Link>
|
|
</div>
|
|
|
|
{wallets.length === 0 ? (
|
|
<div className="rounded-lg border border-border bg-card p-12 text-center">
|
|
<p className="text-muted-foreground">
|
|
No smart wallets deployed yet.
|
|
</p>
|
|
<Link
|
|
href={`/wallets/${params.id}/smart-wallets/deploy`}
|
|
className="mt-4 inline-block text-sm font-medium text-primary hover:underline"
|
|
>
|
|
Deploy your first smart wallet
|
|
</Link>
|
|
</div>
|
|
) : (
|
|
<div className="grid gap-4 sm:grid-cols-2">
|
|
{wallets.map((sw) => (
|
|
<SmartWalletCard key={sw.id} wallet={sw} />
|
|
))}
|
|
</div>
|
|
)}
|
|
</div>
|
|
)
|
|
}
|