mirror of
https://github.com/luxfi/mpc.git
synced 2026-09-24 00:26:24 +00:00
Keygen reached round 2 and every node refused every message, including from legitimate peers, so each attempt sat until the 300s timeout and every crypto deposit answered 503 "the custody service is not accepting new addresses". The handler admits a message only from an id in its OWN party set, and the fleet had built three sets that disagreed: partyIDs=["mpc-node-0:keygen:1","mpc-node-1:keygen:1","peer-2:keygen:1"] while node-2 called itself mpc-node-2:keygen:1. Nobody answers to "peer-2", so its share never arrived and the ceremony could not complete. The synthetic name is what an unprefixed --peer produces: the deployment passes addresses only, self is dropped by address, and everything left took a POSITIONAL id. The comment above that line already said such an id "cannot match a real node id by construction" — it was describing this bug without following it through. So a peer is now named the same way self is recognised: the first DNS label, which IS the node id under StatefulSet naming (mpc-node-2.mpc-node-headless.ns.svc.cluster.local -> mpc-node-2). Deriving both sides by one rule is what makes the sets agree. A bare IP has no label to read and keeps the positional id — the caller must then use nodeID@host:port, which states the name outright. The test asserts the invariant that was violated rather than the helper's return value: the id a node derives for a peer must equal the id that peer uses for itself.