Files
mpc/pkg/mpc/node.go
T
zeekay cb77fab979 Ed25519 keygen is real: sol_address comes from KeygenEd25519 and nothing else
luxfi/threshold v1.12.7 added FROST(Ed25519, SHA-512), so Solana and TON finally
have a signable curve. The sessions named "EdDSA" were calling KeygenTaproot —
BIP-340 over secp256k1 — whose key is also 32 bytes, sails through the
len(EDDSAPubKey)==32 gate, and base58-encodes into a real-looking Solana address
the ring can never sign for.

⚠ A LIVE WRONG-ADDRESS BUG went with it: handlers_wallets served
addresses["ton"] = *wallet.SolAddress. A TON address is not a base58 pubkey — it
is workchain plus a hash of the wallet contract's StateInit, base64url with a
CRC16 — so the API was handing out an address that decodes to nothing. Deleted
rather than guessed; TON returns when its encoding is real.

The keygen tests used to call frost.KeygenEd25519 directly, which validated the
LIBRARY and not the daemon: reintroducing KeygenTaproot left every package
green. They now go through the production session, and so does a test that
constructs the real signing session and proves the caller's bytes reach the
protocol unhashed. Both original bugs reintroduced together fail 11 tests.

secp256k1 keygen changes from fail-open to fail-closed, and that is the one
behavioural change to the existing EVM/BTC path. An empty pubkey previously
meant any of nil config, marshal failure, kvstore.Put failure or keyinfo-save
failure — and was returned as SUCCESS, announcing addresses while fewer than
t+1 nodes hold a share. Applying fail-closed to Solana while leaving the
higher-value leg fail-open is incoherent.

Also: the KMS share classifier still keyed off the retired "frost:" prefix; the
CGGMP21 session published its own local failure onto the same first-wins subject
as the ring's verdict, so one node's failure could beat the ring's success; and
one 120s deadline shared across two sequential ceremonies starved the cheap leg.

NOT YET SPENDABLE. ConsensusKeyInfoStore.Save is the only RegisterKey caller and
hardcodes "secp256k1", and TriggerSign reads the curve from that field, so no
product entry point can reach Ed25519 signing. The address is correct; signing
it needs a wire-contract change shared with lux/wallet.
2026-08-06 13:23:18 -07:00

488 lines
11 KiB
Go

package mpc
import (
"fmt"
"time"
"github.com/luxfi/threshold/pkg/party"
"github.com/luxfi/mpc/pkg/identity"
"github.com/luxfi/mpc/pkg/keyinfo"
"github.com/luxfi/mpc/pkg/kvstore"
"github.com/luxfi/mpc/pkg/logger"
"github.com/luxfi/mpc/pkg/messaging"
)
const (
PurposeKeygen string = "keygen"
PurposeSign string = "sign"
PurposeReshare string = "reshare"
DefaultVersion int = 1
)
type ID string
type Node struct {
nodeID string
peerIDs []string
pubSub messaging.PubSub
kvstore kvstore.KVStore
keyinfoStore keyinfo.Store
identityStore identity.Store
peerRegistry PeerRegistry
}
func ComposeReadyKey(nodeID string) string {
return fmt.Sprintf("ready/%s", nodeID)
}
func NewNode(
nodeID string,
peerIDs []string,
pubSub messaging.PubSub,
kvstore kvstore.KVStore,
keyinfoStore keyinfo.Store,
peerRegistry PeerRegistry,
identityStore identity.Store,
) *Node {
start := time.Now()
elapsed := time.Since(start)
logger.Info("Starting new CGGMP21 node", "nodeID", nodeID, "elapsed", elapsed.Milliseconds())
node := &Node{
nodeID: nodeID,
peerIDs: peerIDs,
pubSub: pubSub,
kvstore: kvstore,
keyinfoStore: keyinfoStore,
peerRegistry: peerRegistry,
identityStore: identityStore,
}
go peerRegistry.WatchPeersReady()
return node
}
func (p *Node) ID() string {
return p.nodeID
}
func (p *Node) KeyInfoStore() keyinfo.Store {
return p.keyinfoStore
}
func (p *Node) CreateKeyGenSession(
walletID string,
threshold int,
resultQueue messaging.MessageQueue,
orgID string,
) (KeyGenSession, error) {
if !p.peerRegistry.ArePeersReady() {
return nil, fmt.Errorf(
"peers are not ready yet. ready: %d, expected: %d",
p.peerRegistry.GetReadyPeersCount(),
len(p.peerIDs)+1,
)
}
readyPeerIDs := p.peerRegistry.GetReadyPeersIncludeSelf()
selfPartyID, allPartyIDs := p.generatePartyIDs(PurposeKeygen, readyPeerIDs, DefaultVersion)
session := newCGGMP21KeygenSession(
walletID,
p.pubSub,
selfPartyID,
allPartyIDs,
threshold,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
orgID,
)
// Note: Init() is called by the caller (keygen handler)
return session, nil
}
// CreateEdDSAKeyGenSession creates a FROST keygen session over edwards25519,
// producing an RFC 8032 Ed25519 key (Solana address, TON wallet key)
func (p *Node) CreateEdDSAKeyGenSession(
walletID string,
threshold int,
resultQueue messaging.MessageQueue,
orgID string,
) (FROSTKeygenSession, error) {
if !p.peerRegistry.ArePeersReady() {
return nil, fmt.Errorf(
"peers are not ready yet. ready: %d, expected: %d",
p.peerRegistry.GetReadyPeersCount(),
len(p.peerIDs)+1,
)
}
readyPeerIDs := p.peerRegistry.GetReadyPeersIncludeSelf()
// Use version 0 for FROST to create raw party IDs without suffixes
// This is required for resharing compatibility - reshare sessions use raw node IDs
selfPartyID, allPartyIDs := p.generatePartyIDs(PurposeKeygen, readyPeerIDs, 0)
session := newFROSTKeygenSession(
walletID,
p.pubSub,
selfPartyID,
allPartyIDs,
threshold,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
orgID,
)
// Note: Init() is called by the caller (keygen handler)
return session, nil
}
// CreateLSSKeyGenSession creates an LSS keygen session for ECDSA
// LSS supports dynamic resharing (changing participants), unlike CGGMP21
func (p *Node) CreateLSSKeyGenSession(
walletID string,
threshold int,
resultQueue messaging.MessageQueue,
orgID string,
) (KeyGenSession, error) {
if !p.peerRegistry.ArePeersReady() {
return nil, fmt.Errorf(
"peers are not ready yet. ready: %d, expected: %d",
p.peerRegistry.GetReadyPeersCount(),
len(p.peerIDs)+1,
)
}
readyPeerIDs := p.peerRegistry.GetReadyPeersIncludeSelf()
// Use version 0 for LSS to create raw party IDs without suffixes
// This is required for resharing compatibility - reshare sessions use raw node IDs
selfPartyID, allPartyIDs := p.generatePartyIDs(PurposeKeygen, readyPeerIDs, 0)
session := newLSSKeygenSession(
walletID,
p.pubSub,
selfPartyID,
allPartyIDs,
threshold,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
orgID,
)
// Note: Init() is called by the caller (keygen handler)
return session, nil
}
// CreateSR25519KeyGenSession creates a FROST keygen session for SR25519 (Ristretto255)
func (p *Node) CreateSR25519KeyGenSession(
walletID string,
threshold int,
resultQueue messaging.MessageQueue,
orgID string,
) (SR25519KeygenSession, error) {
if !p.peerRegistry.ArePeersReady() {
return nil, fmt.Errorf(
"peers are not ready yet. ready: %d, expected: %d",
p.peerRegistry.GetReadyPeersCount(),
len(p.peerIDs)+1,
)
}
readyPeerIDs := p.peerRegistry.GetReadyPeersIncludeSelf()
// Use version 0 for raw party IDs without suffixes (same as FROST)
selfPartyID, allPartyIDs := p.generatePartyIDs(PurposeKeygen, readyPeerIDs, 0)
session := newSR25519KeygenSession(
walletID,
p.pubSub,
selfPartyID,
allPartyIDs,
threshold,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
orgID,
)
// Note: Init() is called by the caller (keygen handler)
return session, nil
}
// CreateSR25519SignSession creates a FROST signing session for SR25519 (Ristretto255)
func (p *Node) CreateSR25519SignSession(
sessionID string,
walletID string,
messageHash []byte,
signingContext string,
signerPeerIDs []string,
resultQueue messaging.MessageQueue,
useBroadcast bool,
orgID string,
) (SR25519SignSession, error) {
// Check if we have enough signers
keyInfo, err := p.keyinfoStore.Get(walletID)
if err != nil {
return nil, fmt.Errorf("failed to get key info: %w", err)
}
if len(signerPeerIDs) < keyInfo.Threshold+1 {
return nil, ErrNotEnoughParticipants
}
// Check if this node is in the signer list
if !contains(signerPeerIDs, p.nodeID) {
return nil, ErrNotInParticipantList
}
// Generate party IDs for signers
// SR25519 uses version 0 for raw party IDs without suffixes (same as FROST)
selfPartyID, signerPartyIDs := p.generatePartyIDs(PurposeKeygen, signerPeerIDs, 0)
session, err := newSR25519SigningSession(
sessionID,
walletID,
messageHash,
signingContext,
p.pubSub,
selfPartyID,
signerPartyIDs,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
useBroadcast,
orgID,
)
if err != nil {
return nil, err
}
// Note: Init() is called by the caller (sign handler)
return session, nil
}
func (p *Node) CreateSignSession(
sessionID string,
walletID string,
messageHash []byte,
signerPeerIDs []string,
resultQueue messaging.MessageQueue,
useBroadcast bool,
orgID string,
) (SignSession, error) {
// Check if we have enough signers
keyInfo, err := p.keyinfoStore.Get(walletID)
if err != nil {
return nil, fmt.Errorf("failed to get key info: %w", err)
}
if len(signerPeerIDs) < keyInfo.Threshold+1 {
return nil, ErrNotEnoughParticipants
}
// Check if this node is in the signer list
if !contains(signerPeerIDs, p.nodeID) {
return nil, ErrNotInParticipantList
}
// Generate party IDs for signers using DefaultVersion and PurposeKeygen
// IMPORTANT: Must use PurposeKeygen because the party IDs stored in the config
// were created during keygen with "UUID:keygen:1" format
selfPartyID, signerPartyIDs := p.generatePartyIDs(PurposeKeygen, signerPeerIDs, DefaultVersion)
session, err := newCGGMP21SigningSession(
sessionID,
walletID,
messageHash,
p.pubSub,
selfPartyID,
signerPartyIDs,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
useBroadcast,
orgID,
)
if err != nil {
return nil, err
}
// Note: Init() is called by the caller (sign handler)
return session, nil
}
// CreateEdDSASignSession creates a FROST signing session over edwards25519.
//
// message is the message itself, not a digest. PureEdDSA hashes it inside the
// challenge, so a caller that pre-hashes signs the wrong thing.
func (p *Node) CreateEdDSASignSession(
sessionID string,
walletID string,
message []byte,
signerPeerIDs []string,
resultQueue messaging.MessageQueue,
useBroadcast bool,
orgID string,
) (FROSTSignSession, error) {
// Check if we have enough signers
keyInfo, err := p.keyinfoStore.Get(walletID)
if err != nil {
return nil, fmt.Errorf("failed to get key info: %w", err)
}
if len(signerPeerIDs) < keyInfo.Threshold+1 {
return nil, ErrNotEnoughParticipants
}
// Check if this node is in the signer list
if !contains(signerPeerIDs, p.nodeID) {
return nil, ErrNotInParticipantList
}
// Generate party IDs for signers
// FROST uses version 0 for raw party IDs without suffixes
selfPartyID, signerPartyIDs := p.generatePartyIDs(PurposeKeygen, signerPeerIDs, 0)
session, err := newFROSTSigningSession(
sessionID,
walletID,
message,
p.pubSub,
selfPartyID,
signerPartyIDs,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.identityStore,
useBroadcast,
orgID,
)
if err != nil {
return nil, err
}
// Note: Init() is called by the caller (sign handler)
return session, nil
}
func (p *Node) generatePartyIDs(purpose string, peerIDs []string, version int) (party.ID, []party.ID) {
partyIDs := make([]party.ID, len(peerIDs))
var selfPartyID party.ID
for i, peerID := range peerIDs {
partyID := createPartyID(peerID, purpose, version)
partyIDs[i] = partyID
if peerID == p.nodeID {
selfPartyID = partyID
}
}
return selfPartyID, partyIDs
}
func createPartyID(sessionID string, keyType string, version int) party.ID {
if version == 0 {
// Backward compatible version - just use sessionID
return party.ID(sessionID)
}
// Include version in party ID
return party.ID(fmt.Sprintf("%s:%s:%d", sessionID, keyType, version))
}
func (p *Node) getVersion(sessionType SessionType, walletID string) int {
// In production, you might want to store and retrieve version info
// For now, always use the default version
return DefaultVersion
}
func (p *Node) CreateReshareSession(
sessionType SessionType,
walletID string,
threshold int,
newThreshold int,
newNodeIDs []string,
isNewPeer bool,
resultQueue messaging.MessageQueue,
orgID string,
) (ReshareSession, error) {
logger.Info("Creating reshare session",
"sessionType", sessionType,
"walletID", walletID,
"threshold", threshold,
"newThreshold", newThreshold,
"newNodeIDs", newNodeIDs,
"isNewPeer", isNewPeer,
"nodeID", p.nodeID,
"orgID", orgID,
)
switch sessionType {
case SessionTypeECDSA:
session, err := newCGGMP21ReshareSession(
walletID,
threshold,
newThreshold,
newNodeIDs,
isNewPeer,
p.pubSub,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.nodeID,
orgID,
)
// Explicitly return nil interface if session is nil
// (prevents nil pointer inside non-nil interface)
if session == nil {
return nil, err
}
return session, err
case SessionTypeEDDSA:
session, err := newEdDSAReshareSession(
walletID,
threshold,
newThreshold,
newNodeIDs,
isNewPeer,
p.pubSub,
p.kvstore,
p.keyinfoStore,
resultQueue,
p.nodeID,
orgID,
)
// Explicitly return nil interface if session is nil
if session == nil {
return nil, err
}
return session, err
default:
return nil, fmt.Errorf("unsupported session type for reshare: %v", sessionType)
}
}
// CreateTFHEKeyGenSession and CreateTFHEComputeSession are gated behind the
// `experimental_tfhe` build tag. See pkg/mpc/tfhe_node.go (experimental impl)
// and pkg/mpc/tfhe_node_stub.go (default-build stub returning
// ErrTFHENotImplemented).
func contains(slice []string, item string) bool {
for _, s := range slice {
if s == item {
return true
}
}
return false
}