mirror of
https://github.com/luxfi/bft.git
synced 2026-10-30 17:01:54 +00:00
The module is luxfi/bft and that is now the only name it answers to. - simplex/ -> engine/. Upstream's module is named for the protocol, so its root package and its engine package shared that name; under luxfi/bft the engine package would have collided with the module's own root package. It is the consensus engine, so engine.Epoch and engine.NewEpoch read without stutter. - Identifiers keep the qualifier where it carries meaning and only change the word: a block produced by this protocol as against a pre-existing chain's block is a real distinction, so makeNonSimplexBlock became makeNonBFTBlock, lastNonSimplexInnerBlockHeight became lastNonBFTInnerBlockHeight, newSnowToSimplexChain became newSnowToBFTChain. Dropping the qualifier outright would have left names that assert nothing. - The canoto-tagged fields of StateMachineMetadata lose the prefix entirely: EpochInfo, ProtocolMetadata, Blacklist. The wire format is unchanged — canoto keys off the tag numbers, which still read 1,2,3,4,5, and the generated .canoto.go files were renamed in step with the source. The msm fuzz and encoding round-trip tests cover this. - Prose cites the protocol paper by reference number instead of by name, so the origin stays findable without the name. The HyperSDK sentence still says Avalanche because that sentence is about Avalanche's VM and is true. Also here, from review of the logger port: - monitor_test's Fatal panics instead of returning. It reported a state the caller had declared impossible and then carried on regardless, which made it the one Fatal in the tree that was weaker than the original. - TestInstanceNonValidatorBootstraps asserts the property it is named for — that the node was still a non-validator when the bootstrap finished — rather than counting how many times a debug line was emitted. The count tracks how often onEpochChange happened to observe the branch, so transitions can coalesce; it measured 2 here where it had been reliably 3, and a logger-cost explanation was tested and refuted. The count never checked the property either way: a node that wrongly became a validator mid-bootstrap would still have counted 3. - SilenceExceptKeywords documents last-call-wins, and Trace/Verbo now reaching hooks is recorded where a future hook author will see it. Co-authored-by: Hanzo Dev <[email protected]>
220 lines
6.7 KiB
Go
220 lines
6.7 KiB
Go
// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
|
|
// See the file LICENSE for licensing terms.
|
|
|
|
package nonvalidator
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/luxfi/bft/common"
|
|
"github.com/luxfi/bft/testutil"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var testNodes = common.Nodes{
|
|
{Id: common.NodeID{1}, Weight: 1},
|
|
{Id: common.NodeID{2}, Weight: 1},
|
|
{Id: common.NodeID{3}, Weight: 1},
|
|
{Id: common.NodeID{4}, Weight: 1},
|
|
}
|
|
|
|
var genesis = testutil.NewTestBlock(common.ProtocolMetadata{
|
|
Seq: 0,
|
|
Round: 0,
|
|
Epoch: 0,
|
|
}, common.Blacklist{})
|
|
|
|
type messageInfo struct {
|
|
msg *common.Message
|
|
from common.NodeID
|
|
to common.NodeID
|
|
}
|
|
|
|
// testChain is a helper that book-keeps the current chain-tip, alongside any
|
|
// blocks and finalizations indexed on the chain. It allows easy creation of block and sealing blocks.
|
|
// It also manages validator sets, and the SignatureAggregatorCreator required by non-validators to verify finalizations.
|
|
type testChain struct {
|
|
*testutil.InMemStorage
|
|
t *testing.T
|
|
|
|
// seq, epoch, prev, sealingBlockHash defines the current tip of testChain.
|
|
// the next block uses seq + 1, epoch, prevDigest = digest, etc...
|
|
seq uint64
|
|
epoch uint64
|
|
digest common.Digest
|
|
sealingBlockHash common.Digest
|
|
|
|
validatorSets map[uint64]common.Nodes
|
|
}
|
|
|
|
func (c *testChain) String() string {
|
|
return fmt.Sprintf("TestChain: Current Epoch: %d, Current Seq: %d", c.epoch, c.seq)
|
|
}
|
|
|
|
// newSeededChain returns a testChain whose storage is indexed through seq=lastSeq:
|
|
//
|
|
// seq 0 — genesis (epoch 0)
|
|
// seq 1 — sealing block opening epoch 1 (validatorSet = testNodes)
|
|
// seq 2..lastSeq — epoch 1 blocks
|
|
func newSeededChain(t *testing.T, nodes common.Nodes, lastSeq uint64) *testChain {
|
|
require.GreaterOrEqual(t, lastSeq, uint64(1), "lastSeq must be >= 1 (0 is genesis, 1 is the first epoch's sealing block)")
|
|
|
|
tc := &testChain{
|
|
InMemStorage: testutil.NewInMemStorage(),
|
|
t: t,
|
|
digest: genesis.Digest,
|
|
validatorSets: make(map[uint64]common.Nodes),
|
|
seq: 0, // set for clarity
|
|
epoch: 0,
|
|
}
|
|
require.NoError(t, tc.Index(context.Background(), genesis, common.Finalization{}))
|
|
tc.validatorSets[0] = nodes
|
|
|
|
// firstBFT comes after genesis
|
|
sealingBlock := tc.appendFirstBFTAfterGenesis(nodes)
|
|
finalization := tc.newFinalization(sealingBlock)
|
|
require.NoError(t, tc.Index(context.Background(), sealingBlock, finalization))
|
|
|
|
for tc.seq < lastSeq {
|
|
b := tc.appendBlock()
|
|
finalization := tc.newFinalization(b)
|
|
|
|
require.NoError(t, tc.Index(context.Background(), b, finalization))
|
|
}
|
|
|
|
return tc
|
|
}
|
|
|
|
// newSnowToBFTChain returns a testChain whose storage is indexed through seq=lastSnowSeq:
|
|
func newSnowToBFTChain(t *testing.T, lastSnowSeq uint64) *testChain {
|
|
require.GreaterOrEqual(t, lastSnowSeq, uint64(1), "genesis must be indexed")
|
|
|
|
tc := &testChain{
|
|
InMemStorage: testutil.NewInMemStorage(),
|
|
t: t,
|
|
digest: genesis.Digest,
|
|
validatorSets: make(map[uint64]common.Nodes),
|
|
seq: 0,
|
|
epoch: 0,
|
|
}
|
|
|
|
// genesis
|
|
require.NoError(t, tc.Index(context.Background(), genesis, common.Finalization{}))
|
|
|
|
for tc.seq < lastSnowSeq {
|
|
b := tc.appendBlock()
|
|
require.NoError(t, tc.Index(context.Background(), b, common.Finalization{}))
|
|
}
|
|
|
|
require.Equal(t, tc.seq, lastSnowSeq)
|
|
return tc
|
|
}
|
|
|
|
// appendBlock advances the chain by one non-sealing block in the current
|
|
// epoch. The block is constructed but NOT indexed.
|
|
func (tc *testChain) appendBlock() *testutil.TestBlock {
|
|
tc.seq++
|
|
block := newBlock(tc.seq, tc.epoch, tc.digest)
|
|
tc.digest = block.Digest
|
|
return block
|
|
}
|
|
|
|
func (tc *testChain) newFinalization(b common.VerifiedBlock) common.Finalization {
|
|
nodes, ok := tc.validatorSets[b.BlockHeader().Epoch]
|
|
require.True(tc.t, ok, "Validator set expected to have before creating a new finalization", b.BlockHeader().Epoch, b.BlockHeader().Seq)
|
|
sigAgg := tc.signatureAggregatorCreator(nodes)
|
|
finalization, _ := testutil.NewFinalizationRecord(tc.t, sigAgg, b, nodes.NodeIDs())
|
|
|
|
return finalization
|
|
}
|
|
|
|
// appendSealing advances the chain by one sealing block announcing nextEpoch
|
|
// and validatorSet. The sealing block's metadata.Epoch is the current epoch;
|
|
// subsequent appendBlock calls live in nextEpoch. Not indexed.
|
|
func (tc *testChain) appendSealing(validatorSet common.Nodes) *sealingTestBlock {
|
|
tc.seq++
|
|
|
|
block := newSealingTestBlock(tc.seq, tc.epoch, tc.digest, &common.SealingBlockInfo{
|
|
ValidatorSet: validatorSet,
|
|
PrevSealingBlockHash: tc.sealingBlockHash,
|
|
})
|
|
tc.digest = block.Digest
|
|
tc.epoch = tc.seq
|
|
tc.validatorSets[tc.epoch] = validatorSet
|
|
tc.sealingBlockHash = block.Digest
|
|
return block
|
|
}
|
|
|
|
// the first bft block must return sealing block information
|
|
func (tc *testChain) appendFirstBFTAfterGenesis(validatorSet common.Nodes) *sealingTestBlock {
|
|
lastBlock, _, err := tc.Retrieve(tc.seq)
|
|
tc.seq++
|
|
firstEverEpoch := tc.seq
|
|
require.NoError(tc.t, err)
|
|
|
|
block := newSealingTestBlock(tc.seq, firstEverEpoch, tc.digest, &common.SealingBlockInfo{
|
|
ValidatorSet: validatorSet,
|
|
PrevSealingBlockHash: lastBlock.BlockHeader().Digest,
|
|
})
|
|
tc.digest = block.Digest
|
|
tc.epoch = firstEverEpoch
|
|
tc.sealingBlockHash = block.Digest
|
|
tc.validatorSets[firstEverEpoch] = validatorSet
|
|
return block
|
|
}
|
|
|
|
func (tc *testChain) signatureAggregatorCreator(nodes []common.Node) common.SignatureAggregator {
|
|
isQuorumFunc := func(signatures []common.NodeID) bool {
|
|
count := 0
|
|
nodeSet := make(map[string]struct{})
|
|
for _, node := range nodes {
|
|
nodeSet[node.Id.String()] = struct{}{}
|
|
}
|
|
|
|
for _, sig := range signatures {
|
|
if _, ok := nodeSet[sig.String()]; ok {
|
|
count++
|
|
}
|
|
}
|
|
|
|
return count >= common.Quorum(len(nodes))
|
|
}
|
|
return &testutil.TestSignatureAggregator{
|
|
IsQuorumFunc: isQuorumFunc,
|
|
N: len(nodes),
|
|
}
|
|
}
|
|
|
|
// indexEpochs indexes sealing blocks at epochs, and normal blocks in between
|
|
func (tc *testChain) indexEpochs(epochs ...uint64) {
|
|
// ensure that the new epoch we are adding is not already indexed
|
|
require.Greater(tc.t, epochs[0], tc.seq)
|
|
|
|
for _, epoch := range epochs {
|
|
for tc.seq < epoch-1 {
|
|
b := tc.appendBlock()
|
|
finalization := tc.newFinalization(b)
|
|
require.NoError(tc.t, tc.Index(context.Background(), b, finalization))
|
|
}
|
|
validatorSet, ok := tc.validatorSets[tc.epoch]
|
|
require.True(tc.t, ok)
|
|
|
|
newNodes := append(validatorSet, common.Node{
|
|
Id: common.NodeID{byte(epoch)},
|
|
Weight: 1,
|
|
})
|
|
sealing := tc.appendSealing(newNodes)
|
|
finalization := tc.newFinalization(sealing)
|
|
require.NoError(tc.t, tc.Index(context.Background(), sealing, finalization))
|
|
}
|
|
}
|
|
|
|
func (tc *testChain) nodes() common.Nodes {
|
|
latestValidatorSet, ok := tc.validatorSets[tc.epoch]
|
|
require.True(tc.t, ok)
|
|
|
|
return latestValidatorSet
|
|
}
|