mirror of
https://github.com/luxfi/bft.git
synced 2026-10-30 17:01:54 +00:00
The module is luxfi/bft and that is now the only name it answers to. - simplex/ -> engine/. Upstream's module is named for the protocol, so its root package and its engine package shared that name; under luxfi/bft the engine package would have collided with the module's own root package. It is the consensus engine, so engine.Epoch and engine.NewEpoch read without stutter. - Identifiers keep the qualifier where it carries meaning and only change the word: a block produced by this protocol as against a pre-existing chain's block is a real distinction, so makeNonSimplexBlock became makeNonBFTBlock, lastNonSimplexInnerBlockHeight became lastNonBFTInnerBlockHeight, newSnowToSimplexChain became newSnowToBFTChain. Dropping the qualifier outright would have left names that assert nothing. - The canoto-tagged fields of StateMachineMetadata lose the prefix entirely: EpochInfo, ProtocolMetadata, Blacklist. The wire format is unchanged — canoto keys off the tag numbers, which still read 1,2,3,4,5, and the generated .canoto.go files were renamed in step with the source. The msm fuzz and encoding round-trip tests cover this. - Prose cites the protocol paper by reference number instead of by name, so the origin stays findable without the name. The HyperSDK sentence still says Avalanche because that sentence is about Avalanche's VM and is true. Also here, from review of the logger port: - monitor_test's Fatal panics instead of returning. It reported a state the caller had declared impossible and then carried on regardless, which made it the one Fatal in the tree that was weaker than the original. - TestInstanceNonValidatorBootstraps asserts the property it is named for — that the node was still a non-validator when the bootstrap finished — rather than counting how many times a debug line was emitted. The count tracks how often onEpochChange happened to observe the branch, so transitions can coalesce; it measured 2 here where it had been reliably 3, and a logger-cost explanation was tested and refuted. The count never checked the property either way: a node that wrongly became a validator mid-bootstrap would still have counted 3. - SilenceExceptKeywords documents last-call-wins, and Trace/Verbo now reaching hooks is recorded where a future hook author will see it. Co-authored-by: Hanzo Dev <[email protected]>
221 lines
5.7 KiB
Go
221 lines
5.7 KiB
Go
// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
|
|
// See the file LICENSE for licensing terms.
|
|
package testutil
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/luxfi/bft/common"
|
|
"github.com/luxfi/bft/engine"
|
|
"github.com/luxfi/log"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type ControlledInMemoryNetwork struct {
|
|
*BasicInMemoryNetwork
|
|
Instances []*ControlledNode
|
|
}
|
|
|
|
// NewControlledNetwork creates an in-memory network. Node IDs must be provided before
|
|
// adding instances, as nodeWeights require prior knowledge of all participants.
|
|
func NewControlledNetwork(t *testing.T, nodes common.NodeIDs) *ControlledInMemoryNetwork {
|
|
common.SortNodes(nodes.EqualWeightedNodes())
|
|
net := &ControlledInMemoryNetwork{
|
|
BasicInMemoryNetwork: NewBasicInMemoryNetwork(t, nodes),
|
|
Instances: make([]*ControlledNode, 0),
|
|
}
|
|
return net
|
|
}
|
|
|
|
func (n *ControlledInMemoryNetwork) TriggerLeaderBlockBuilder(round uint64) {
|
|
leader := engine.LeaderForRound(n.nodes, round)
|
|
for _, instance := range n.Instances {
|
|
if !instance.E.ID.Equals(leader) {
|
|
continue
|
|
}
|
|
if n.IsDisconnected(leader) {
|
|
instance.E.Logger.Info("triggering block build on disconnected leader", log.Stringer("leader", leader))
|
|
}
|
|
|
|
// wait for the node to enter the round we expect it to propose a block for
|
|
// otherwise we may trigger a build block too early
|
|
WaitToEnterRound(n.t, instance.E, round)
|
|
|
|
instance.TriggerNewBlock()
|
|
return
|
|
}
|
|
|
|
// we should always find the leader
|
|
require.Fail(n.t, "leader not found")
|
|
}
|
|
|
|
func (n *ControlledInMemoryNetwork) addNode(node *ControlledNode) {
|
|
n.BasicInMemoryNetwork.AddNode(node.BasicNode)
|
|
n.Instances = append(n.Instances, node)
|
|
}
|
|
|
|
func (n *ControlledInMemoryNetwork) AdvanceWithoutLeader(round uint64, laggingNodeId common.NodeID) {
|
|
// we need to ensure all blocks are waiting for the channel before proceeding
|
|
// otherwise, we may send to a channel that is not ready to receive
|
|
for _, n := range n.Instances {
|
|
if laggingNodeId.Equals(n.E.ID) {
|
|
continue
|
|
}
|
|
|
|
WaitToEnterRound(n.t, n.E, round)
|
|
}
|
|
|
|
for _, n := range n.Instances {
|
|
n.BlockShouldBeBuilt()
|
|
}
|
|
|
|
for _, n := range n.Instances {
|
|
leader := n.E.ID.Equals(engine.LeaderForRound(n.E.Comm.Validators().NodeIDs(), n.E.Metadata().Round))
|
|
if leader || laggingNodeId.Equals(n.E.ID) {
|
|
continue
|
|
}
|
|
epochTime := time.UnixMilli(n.currentTime.Load())
|
|
WaitForBlockProposerTimeout(n.t, n.E, &epochTime, round)
|
|
}
|
|
|
|
for _, n := range n.Instances {
|
|
if laggingNodeId.Equals(n.E.ID) {
|
|
continue
|
|
}
|
|
recordType := n.WAL.AssertNotarization(round)
|
|
require.Equal(n.t, common.EmptyNotarizationRecordType, recordType)
|
|
}
|
|
}
|
|
|
|
type ControlledNode struct {
|
|
*BasicNode
|
|
bb *testControlledBlockBuilder
|
|
WAL *TestWAL
|
|
Storage *InMemStorage
|
|
}
|
|
|
|
// newBFTNode creates a new testNode and adds it to [net].
|
|
func NewControlledBFTNode(t *testing.T, nodeID common.NodeID, net *ControlledInMemoryNetwork, config *TestNodeConfig) *ControlledNode {
|
|
comm := NewTestComm(nodeID, net.BasicInMemoryNetwork, AllowAllMessages)
|
|
bb := NewTestControlledBlockBuilder(t)
|
|
if config != nil && config.BlockBuilder != nil {
|
|
bb = config.BlockBuilder
|
|
}
|
|
|
|
epochConfig, wal, storage := DefaultTestNodeEpochConfig(t, nodeID, comm, bb)
|
|
|
|
if config != nil {
|
|
UpdateEpochConfig(&epochConfig, config)
|
|
if config.WAL != nil {
|
|
wal = config.WAL
|
|
}
|
|
if config.Storage != nil {
|
|
storage = config.Storage
|
|
}
|
|
}
|
|
|
|
e, err := engine.NewEpoch(epochConfig)
|
|
require.NoError(t, err)
|
|
ti := &ControlledNode{
|
|
BasicNode: NewBasicNode(t, e, epochConfig.Logger.(*TestLogger)),
|
|
WAL: wal,
|
|
bb: bb,
|
|
Storage: storage,
|
|
}
|
|
|
|
net.addNode(ti)
|
|
return ti
|
|
}
|
|
|
|
// TimeoutOnRound advances time until the node times out of the given round.
|
|
func (t *ControlledNode) TimeoutOnRound(round uint64) {
|
|
for {
|
|
currentRound := t.E.Metadata().Round
|
|
if currentRound > round {
|
|
return
|
|
}
|
|
|
|
if !t.ShouldBlockBeBuilt() {
|
|
t.BlockShouldBeBuilt()
|
|
}
|
|
|
|
t.AdvanceTime(t.E.MaxProposalWait)
|
|
|
|
// check the wal for an empty vote for that round
|
|
if hasVote := t.WAL.ContainsEmptyVote(round); hasVote {
|
|
return
|
|
}
|
|
|
|
time.Sleep(50 * time.Millisecond)
|
|
}
|
|
}
|
|
|
|
func (t *ControlledNode) ShouldBlockBeBuilt() bool {
|
|
return len(t.bb.BlockShouldBeBuilt) > 0
|
|
}
|
|
|
|
func (t *ControlledNode) TriggerNewBlock() {
|
|
t.bb.TriggerNewBlock()
|
|
}
|
|
func (t *ControlledNode) BlockShouldBeBuilt() {
|
|
select {
|
|
case t.bb.BlockShouldBeBuilt <- struct{}{}:
|
|
default:
|
|
}
|
|
}
|
|
|
|
func (t *ControlledNode) TickUntilRoundAdvanced(round uint64, tick time.Duration) {
|
|
timeout := time.NewTimer(time.Minute)
|
|
defer timeout.Stop()
|
|
|
|
for {
|
|
if t.E.Metadata().Round >= round {
|
|
return
|
|
}
|
|
|
|
select {
|
|
case <-time.After(time.Millisecond * 10):
|
|
t.AdvanceTime(tick)
|
|
continue
|
|
case <-timeout.C:
|
|
require.Fail(t.t, "timed out waiting to enter round", "current round %d, waiting for round %d", t.E.Metadata().Round, round)
|
|
}
|
|
}
|
|
}
|
|
|
|
// testControlledBlockBuilder is a BlockBuilder that only builds a block when
|
|
// a control signal is received.
|
|
type testControlledBlockBuilder struct {
|
|
t *testing.T
|
|
control chan struct{}
|
|
TestBlockBuilder
|
|
}
|
|
|
|
// NewTestControlledBlockBuilder returns a BlockBuilder that only builds a block
|
|
// when triggerNewBlock is called.
|
|
func NewTestControlledBlockBuilder(t *testing.T) *testControlledBlockBuilder {
|
|
return &testControlledBlockBuilder{
|
|
t: t,
|
|
control: make(chan struct{}, 1),
|
|
TestBlockBuilder: *NewTestBlockBuilder(),
|
|
}
|
|
}
|
|
|
|
func (t *testControlledBlockBuilder) TriggerNewBlock() {
|
|
select {
|
|
case t.control <- struct{}{}:
|
|
default:
|
|
}
|
|
}
|
|
|
|
func (t *testControlledBlockBuilder) BuildBlock(ctx context.Context, metadata common.ProtocolMetadata, blacklist common.Blacklist) (common.VerifiedBlock, bool) {
|
|
select {
|
|
case <-t.control:
|
|
case <-ctx.Done():
|
|
return nil, false
|
|
}
|
|
return t.TestBlockBuilder.BuildBlock(ctx, metadata, blacklist)
|
|
}
|