Files
zeekayandHanzo Dev 974d0d5422 rename: drop the upstream protocol name from the tree
The module is luxfi/bft and that is now the only name it answers to.

- simplex/ -> engine/. Upstream's module is named for the protocol, so its root
  package and its engine package shared that name; under luxfi/bft the engine
  package would have collided with the module's own root package. It is the
  consensus engine, so engine.Epoch and engine.NewEpoch read without stutter.
- Identifiers keep the qualifier where it carries meaning and only change the
  word: a block produced by this protocol as against a pre-existing chain's block
  is a real distinction, so makeNonSimplexBlock became makeNonBFTBlock,
  lastNonSimplexInnerBlockHeight became lastNonBFTInnerBlockHeight,
  newSnowToSimplexChain became newSnowToBFTChain. Dropping the qualifier outright
  would have left names that assert nothing.
- The canoto-tagged fields of StateMachineMetadata lose the prefix entirely:
  EpochInfo, ProtocolMetadata, Blacklist. The wire format is unchanged — canoto
  keys off the tag numbers, which still read 1,2,3,4,5, and the generated
  .canoto.go files were renamed in step with the source. The msm fuzz and
  encoding round-trip tests cover this.
- Prose cites the protocol paper by reference number instead of by name, so the
  origin stays findable without the name. The HyperSDK sentence still says
  Avalanche because that sentence is about Avalanche's VM and is true.

Also here, from review of the logger port:
- monitor_test's Fatal panics instead of returning. It reported a state the
  caller had declared impossible and then carried on regardless, which made it
  the one Fatal in the tree that was weaker than the original.
- TestInstanceNonValidatorBootstraps asserts the property it is named for — that
  the node was still a non-validator when the bootstrap finished — rather than
  counting how many times a debug line was emitted. The count tracks how often
  onEpochChange happened to observe the branch, so transitions can coalesce; it
  measured 2 here where it had been reliably 3, and a logger-cost explanation was
  tested and refuted. The count never checked the property either way: a node
  that wrongly became a validator mid-bootstrap would still have counted 3.
- SilenceExceptKeywords documents last-call-wins, and Trace/Verbo now reaching
  hooks is recorded where a future hook author will see it.

Co-authored-by: Hanzo Dev <[email protected]>
2026-08-06 05:16:49 -07:00

252 lines
6.6 KiB
Go

// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
// See the file LICENSE for licensing terms.
package testutil
import (
"context"
"fmt"
"sync"
"sync/atomic"
"testing"
"time"
"github.com/luxfi/bft/common"
"github.com/luxfi/bft/engine"
"github.com/luxfi/log"
"github.com/stretchr/testify/require"
)
// BasicNode is a simple representation of an instance running an epoch. It does not know about any particular custom types, its sole responsibility is to
// run the epoch and handle messages.
type BasicNode struct {
currentTime atomic.Int64
shouldStop atomic.Bool
lock sync.RWMutex
running sync.WaitGroup
E *engine.Epoch
ingress chan struct {
msg *common.Message
from common.NodeID
}
l *TestLogger
t *testing.T
messageTypesSent map[string]uint64
CustomHandler func(msg *common.Message, from common.NodeID) error
}
func NewBasicNode(t *testing.T, epoch *engine.Epoch, logger *TestLogger) *BasicNode {
currentTime := epoch.EpochConfig.StartTime.UnixMilli()
bn := BasicNode{
shouldStop: atomic.Bool{},
lock: sync.RWMutex{},
running: sync.WaitGroup{},
E: epoch,
ingress: make(chan struct {
msg *common.Message
from common.NodeID
}, 100000),
l: logger,
t: t,
messageTypesSent: make(map[string]uint64),
}
bn.currentTime.Store(currentTime)
return &bn
}
func (b *BasicNode) Start() {
b.running.Add(1)
go b.handleMessages()
require.NoError(b.t, b.E.Start())
}
func (b *BasicNode) AdvanceTime(duration time.Duration) {
now := time.UnixMilli(b.currentTime.Load()).Add(duration)
b.currentTime.Store(now.UnixMilli())
b.E.AdvanceTime(now)
}
func (b *BasicNode) Silence() {
b.l.Silence()
}
func (b *BasicNode) SilenceExceptKeywords(keywords ...string) {
b.l.SilenceExceptKeywords(keywords...)
}
func (b *BasicNode) HandleMessage(msg *common.Message, from common.NodeID) error {
err := b.E.HandleMessage(msg, from)
if err != nil {
b.l.Error("error handling message", log.Stringer("from", from), log.Stringer("to", b.E.ID), log.Err(err), log.Err(err), log.Any("message", msg))
panic(fmt.Sprintf("error handling message from %s to %s: %+v. Err message: %v", from.String(), b.E.ID.String(), msg, err))
}
require.NoError(b.t, err, "error handling message from %s to %s: %+v", from.String(), b.E.ID.String(), msg)
return err
}
func (b *BasicNode) handleMessages() {
defer b.running.Done()
for msg := range b.ingress {
if b.shouldStop.Load() {
return
}
var err error
if b.CustomHandler != nil {
err = b.CustomHandler(msg.msg, msg.from)
} else {
b.HandleMessage(msg.msg, msg.from)
}
require.NoError(b.t, err)
if err != nil {
return
}
}
}
func (b *BasicNode) enqueue(msg *common.Message, from, to common.NodeID) {
b.lock.Lock()
defer b.lock.Unlock()
if b.shouldStop.Load() {
b.l.Info("Node is stopped, not enqueuing message", log.Stringer("from", from), log.Stringer("to", to))
return
}
b.RecordMessageTypeSent(msg)
if b.shouldStop.Load() {
b.l.Debug("Node is stopped, not enqueuing message", log.Stringer("from", from), log.Stringer("to", to))
return
}
select {
case b.ingress <- struct {
msg *common.Message
from common.NodeID
}{msg: msg, from: from}:
default:
// drop the message if the ingress channel is full
formattedString := fmt.Sprintf("Ingress channel is too full, failing test. From %v -> to %v", from, to)
panic(formattedString)
}
}
func (b *BasicNode) Stop() {
b.lock.Lock()
defer b.lock.Unlock()
b.E.Stop()
b.shouldStop.Store(true)
close(b.ingress)
b.running.Wait()
}
func (b *BasicNode) RecordMessageTypeSent(msg *common.Message) {
switch {
case msg.BlockMessage != nil:
b.messageTypesSent["BlockMessage"]++
case msg.VerifiedBlockMessage != nil:
b.messageTypesSent["VerifiedBlockMessage"]++
case msg.ReplicationRequest != nil:
b.messageTypesSent["ReplicationRequest"]++
case msg.ReplicationResponse != nil:
b.messageTypesSent["ReplicationResponse"]++
case msg.Notarization != nil:
b.messageTypesSent["VerifiedReplicationRequest"]++
case msg.VerifiedReplicationResponse != nil:
b.messageTypesSent["VerifiedReplicationResponse"]++
case msg.Finalization != nil:
b.messageTypesSent["NotarizationMessage"]++
case msg.FinalizeVote != nil:
b.messageTypesSent["FinalizationMessage"]++
case msg.VoteMessage != nil:
b.messageTypesSent["VoteMessage"]++
case msg.EmptyVoteMessage != nil:
b.messageTypesSent["EmptyVoteMessage"]++
case msg.EmptyNotarization != nil:
b.messageTypesSent["EmptyNotarization"]++
case msg.BlockDigestRequest != nil:
b.messageTypesSent["BlockDigestRequest"]++
default:
panic("unknown message type")
}
}
func (b *BasicNode) PrintMessageTypesSent() {
b.t.Logf("Node %s sent message types: %+v", b.E.ID.String(), b.messageTypesSent)
}
func (b *BasicNode) ResetMessageTypesSent() {
b.messageTypesSent = make(map[string]uint64)
}
func (b *BasicNode) GetMessageTypesSent() map[string]uint64 {
return b.messageTypesSent
}
func UpdateEpochConfig(epochConfig *engine.EpochConfig, testConfig *TestNodeConfig) {
// set the initial storage
for _, data := range testConfig.InitialStorage {
epochConfig.Storage.Index(context.Background(), data.VerifiedBlock, data.Finalization)
}
// TODO: remove optional replication flag
epochConfig.ReplicationEnabled = testConfig.ReplicationEnabled
// custom communication
if testConfig.Comm != nil {
epochConfig.Comm = testConfig.Comm
}
if testConfig.SigAggregatorCreator != nil {
epochConfig.SignatureAggregatorCreator = testConfig.SigAggregatorCreator
}
if testConfig.BlockBuilder != nil {
epochConfig.BlockBuilder = testConfig.BlockBuilder
}
if testConfig.MaxRoundWindow != 0 {
epochConfig.MaxRoundWindow = testConfig.MaxRoundWindow
}
if testConfig.Logger != nil {
epochConfig.Logger = testConfig.Logger
}
if testConfig.WAL != nil {
epochConfig.WAL = testConfig.WAL
}
if testConfig.Storage != nil {
epochConfig.Storage = testConfig.Storage
}
if testConfig.StartTime != 0 {
epochConfig.StartTime = time.UnixMilli(testConfig.StartTime)
}
if testConfig.RandomSeed != nil {
epochConfig.RandomSource = common.NewRandomSourceFromSeed(*testConfig.RandomSeed)
}
}
// NodeConfig
type TestNodeConfig struct {
// optional
InitialStorage []common.VerifiedFinalizedBlock
Comm common.Communication
SigAggregatorCreator common.SignatureAggregatorCreator
ReplicationEnabled bool
BlockBuilder *testControlledBlockBuilder
// Long Running Tests
MaxRoundWindow uint64
Logger *TestLogger
WAL *TestWAL
Storage *InMemStorage
StartTime int64
RandomSeed *int64 // Optional seed for deterministic tests
}