mirror of
https://github.com/luxfi/cli.git
synced 2026-10-30 17:01:20 +00:00
warp v1.24.1 made Message and Envelope DISTINCT types — SignMessage now returns
(*Envelope, error). Two sites had to follow:
* pkg/signatureaggregator SignMessage is a pass-through wrapper that only
forwards to sdkwarp.SignMessage, so its declared return type was simply
stale: *warp.Message -> *warp.Envelope.
* pkg/contract TxToMethodWithWarpMessage took *luxWarp.Message and handed it
to client.TransactWithWarpMessage, which now wants *Envelope. Changed the
parameter.
Checked the blast radius before touching the signature rather than assuming:
TxToMethodWithWarpMessage has ZERO callers in this repo, and that parameter was
the last *Message declaration left. So this is contained, not a rippling change.
REMAINING — 1 error, and it is not fixable here:
cmd/ammcmd/client.go:245: undefined: keys.LoadMnemonic
keys.LoadMnemonic is gone from github.com/luxfi/keys — absent from published
v1.4.1 AND from the local tree, so nothing to pin back to. It has no successor:
DeriveValidatorFromMnemonic / DeriveValidatorsFromMnemonic derive keys FROM a
mnemonic, whereas LoadMnemonic LOADED one from env-or-KMS. Different job.
Three repos still call it — lux/cli, lux/kms, lux/node — so it was removed
without migrating its callers. The fix belongs in luxfi/keys (restore it, or
publish a replacement and migrate all three). Inlining the env/KMS split into
this one caller would duplicate shared logic into the callers it exists to
serve, so it is deliberately not done here.