mirror of
https://github.com/luxfi/coreth.git
synced 2026-10-30 17:00:51 +00:00
zeekayandHanzo Dev
f2d18226a0
constants.BlackholeAddr is a plain [20]byte now, so constants no longer imports geth. Go assigns an unnamed [20]byte to common.Address implicitly, so every call site still compiled, but one of them changed behavior: fmt %v prints [1 0 0 ...] for an array and 0x0100000000000000000000000000000000000000 for a common.Address, so the invalid-coinbase error in syntacticVerify lost its hex form. Writing common.Address(constants.BlackholeAddr) restores the message and names the type at the boundary; the conversion is free. Six sites take the conversion: the etherbase in initializeChain, the simulated backend etherbase, the coinbase error text, the module address in the registerer test, and the two SetCoinbase calls. The last two sit in files carrying //go:build ignore, so the compiler does not check them. Two sites compare bytes and stay as they are, the registerer against a module address and syntacticVerify against the header coinbase. go.mod is untouched. The requirement still reads constants v1.6.2 and the bump waits on the tag. Co-authored-by: Hanzo Dev <[email protected]>