Files
erc-3643/test/proxy/AbstractProxy.t.sol
Mohamad HammoudandGitHub 94182deb9c ✨ BT-1418 integrate foundry & hardhat + migrating solidity tests (#76)
* ✨ integrate foundry alongside hardhat for dual testing framework

- Add foundry.toml configuration
- Reorganize test structure: test/forge/ and test/hardhat/
- Add Foundry scripts to package.json (build:forge, test:forge, coverage:forge)
- Update hardhat.config.ts with evmVersion for compatibility
- Add GitHub workflows and coverage scripts from template
- Add Husky hooks (pre-commit, post-checkout, post-merge)
- Add .vscode/settings.json for better IDE support
- Disable coverage checks until tests are migrated (commented with TODO)

This migration is based on TokenySolutions/contracts-template and enables
gradual migration of tests from Hardhat (TypeScript) to Foundry (Solidity).

Related to: BT-1418

* ✅ trex factory tests

* ⚰️ remove trex suit

* feat(forge): reorganize Foundry test structure and sync GitHub workflows

- Move TREXFactorySetup to helpers folder
- Rename TREXSuite.t.sol to TREXFactory.t.sol
- Update fixture to inherit from Test for proper Foundry pattern
- Transfer ownership to deployer address to match Hardhat behavior
- Sync GitHub workflows with package.json scripts
- Update test.yml to use npm run build and npm run test
- Update push_checking.yml to use unified npm run lint
- Update forge_coverage.sh to use npm run coverage

* fix(ci): install Foundry and skip husky in push_checking workflow

- Add Foundry installation step before npm ci
- Set HUSKY=0 to skip husky setup in CI environment
- Fixes 'forge: not found' error during npm prepare script

* 🔧 keep hardhat settings

* ✅ create addressess directly

* ✅ removed test_StandardAddressesSet

* ✅ fix lint

* 💡 removed title natspecs

* ✅ migrated trex factort tests

* ✅ added test module multicall

* ✅ migrate agent role test

* ✅ migrate claim topics registry

* ✅ migrated trusted issuer registry

* ✅ migrate identity registry storage

* ✅ migrated identity registry tests

* ✅ migrated implementation authority test

* ✅ migrated token agen restrictions

* ✅ migrated token information test

* ✅ migrated token recover

* ✅ migrated token permit

* ✅ migrated token transfer

* ✅ migrated utilities upgrade

* ✅ migrated freeze check

* ✅ migrated compliance check in utilities test

* ✅ migrated eligibility check

* ✅ migrated transfer check in utilities

* ✅ migrated compliance test

* ✅ migrated gateway tests

* 🔥 removed already defined events

* 🗑️ imported Initializable error from openzeppelin

* ➕ added already defined events and errors

* ✅ added base test token

* ✅ used idFactory

* ♻️ refactored compliance test

* ⚰️ remoced useless vm.prank

* 🔧 deleted hardhat configurations

* 💚 fixed ci

* refactor: remove 100% coverage requirement from forge_coverage.sh

- Remove strict 100% coverage checks that were causing workflow failures
- Script now only generates and displays coverage report without failing
- Aligns with previous behavior where coverage was informational only

* ✅ resolve getVerifiedDetails

* ✅ applied _getEligibility and remove via-ir from foundry.toml

* ✅ cover tokena and token permit

* ✅ cover compliance

* ✅ cover identity registry

* ✅ increased trex gateway coverage

* ✅ increase coverage for trex factory

* ✅ increased AbstractModuleUpgradeable.sol coverage

* ⚰️ removed abstract module

* 🔧 updted generate coverage

* ✅ coverage 100% identity registry

* ✅ coverage 100% trex gate way

* ✅ coverage trex factory

* ✅ coverage 100% AbstractModuleUpgradeable by test module

* ✅ coverage IAFactory.sol

* ✅ coverage 100% for implementation authority

* ✅ coverage 1005 abstract proxy

* ✅ coverage 100% claim topic registry

* ✅ coverage 100% identity registry storage

* ✅ coverage 100% modular compliance proxy

* ✅ coverage trusted issuer registry proxy

* ✅ coverage 100% identity registry

* ✅ coverage 100% token proxy

* 🚨 resolve linter in token information

* ✅ coverage 100% roles

* 🚨 resolve linter

* 🔧 added no coverage for test, _testContracts and  utils

* ✅ coverage 100% for token.sol

* ✅ coverage 100% for modular compliance

* ✅ coverage 100% trusted issuer registry

* 🔧 restore package.json

* ✅ coverage 100% for utlity checker

* 🚨 fix linter
2025-12-31 16:58:16 +08:00

77 lines
3.7 KiB
Solidity

// SPDX-License-Identifier: UNLICENSED
pragma solidity 0.8.30;
import { InvalidImplementationAuthority } from "contracts/errors/CommonErrors.sol";
import { ZeroAddress } from "contracts/errors/InvalidArgumentErrors.sol";
import { OnlyCurrentImplementationAuthorityCanCall } from "contracts/proxy/AbstractProxy.sol";
import { ModularComplianceProxy } from "contracts/proxy/ModularComplianceProxy.sol";
import { ITREXImplementationAuthority } from "contracts/proxy/authority/ITREXImplementationAuthority.sol";
import { TREXImplementationAuthority } from "contracts/proxy/authority/TREXImplementationAuthority.sol";
import { ImplementationAuthoritySet } from "contracts/proxy/interface/IProxy.sol";
import { IProxy } from "contracts/proxy/interface/IProxy.sol";
import { Test } from "forge-std/Test.sol";
import { ImplementationAuthorityHelper } from "test/helpers/ImplementationAuthorityHelper.sol";
contract AbstractProxyTest is Test {
address public deployer = makeAddr("deployer");
IProxy public proxy;
TREXImplementationAuthority public implementationAuthority;
function setUp() public {
// Deploy a complete Implementation Authority (reference = true is needed for proxy construction)
ImplementationAuthorityHelper.ImplementationAuthoritySetup memory setup =
ImplementationAuthorityHelper.deploy(true);
implementationAuthority = setup.implementationAuthority;
// Deploy ModularComplianceProxy (which inherits from AbstractProxy)
proxy = IProxy(address(new ModularComplianceProxy(address(implementationAuthority))));
}
// ============ setImplementationAuthority() Tests ============
/// @notice Should revert when called by non-implementation authority
function test_setImplementationAuthority_RevertWhen_NotImplementationAuthority() public {
address randomAddress = makeAddr("random");
ImplementationAuthorityHelper.ImplementationAuthoritySetup memory newIASetup =
ImplementationAuthorityHelper.deploy(true);
vm.prank(randomAddress);
vm.expectRevert(OnlyCurrentImplementationAuthorityCanCall.selector);
proxy.setImplementationAuthority(address(newIASetup.implementationAuthority));
}
/// @notice Should revert when new implementation authority is zero address
function test_setImplementationAuthority_RevertWhen_ZeroAddress() public {
vm.prank(address(implementationAuthority));
vm.expectRevert(ZeroAddress.selector);
proxy.setImplementationAuthority(address(0));
}
/// @notice Should revert when new implementation authority is incomplete
function test_setImplementationAuthority_RevertWhen_IncompleteIA() public {
// Deploy an incomplete IA (no implementations set)
TREXImplementationAuthority incompleteIA = new TREXImplementationAuthority(false, address(0), address(0));
vm.prank(address(implementationAuthority));
vm.expectRevert(InvalidImplementationAuthority.selector);
proxy.setImplementationAuthority(address(incompleteIA));
}
/// @notice Should succeed when called by implementation authority with complete IA
function test_setImplementationAuthority_Success() public {
ImplementationAuthorityHelper.ImplementationAuthoritySetup memory newIASetup =
ImplementationAuthorityHelper.deploy(true);
vm.prank(address(implementationAuthority));
vm.expectEmit(true, false, false, false);
emit ImplementationAuthoritySet(address(newIASetup.implementationAuthority));
proxy.setImplementationAuthority(address(newIASetup.implementationAuthority));
assertEq(
proxy.getImplementationAuthority(), address(newIASetup.implementationAuthority), "IA should be updated"
);
}
}