mirror of
https://github.com/luxfi/erc-3643.git
synced 2026-10-30 16:58:28 +00:00
Mohamad HammoudandGitHub
94182deb9c
* ✨ integrate foundry alongside hardhat for dual testing framework - Add foundry.toml configuration - Reorganize test structure: test/forge/ and test/hardhat/ - Add Foundry scripts to package.json (build:forge, test:forge, coverage:forge) - Update hardhat.config.ts with evmVersion for compatibility - Add GitHub workflows and coverage scripts from template - Add Husky hooks (pre-commit, post-checkout, post-merge) - Add .vscode/settings.json for better IDE support - Disable coverage checks until tests are migrated (commented with TODO) This migration is based on TokenySolutions/contracts-template and enables gradual migration of tests from Hardhat (TypeScript) to Foundry (Solidity). Related to: BT-1418 * ✅ trex factory tests * ⚰️ remove trex suit * feat(forge): reorganize Foundry test structure and sync GitHub workflows - Move TREXFactorySetup to helpers folder - Rename TREXSuite.t.sol to TREXFactory.t.sol - Update fixture to inherit from Test for proper Foundry pattern - Transfer ownership to deployer address to match Hardhat behavior - Sync GitHub workflows with package.json scripts - Update test.yml to use npm run build and npm run test - Update push_checking.yml to use unified npm run lint - Update forge_coverage.sh to use npm run coverage * fix(ci): install Foundry and skip husky in push_checking workflow - Add Foundry installation step before npm ci - Set HUSKY=0 to skip husky setup in CI environment - Fixes 'forge: not found' error during npm prepare script * 🔧 keep hardhat settings * ✅ create addressess directly * ✅ removed test_StandardAddressesSet * ✅ fix lint * 💡 removed title natspecs * ✅ migrated trex factort tests * ✅ added test module multicall * ✅ migrate agent role test * ✅ migrate claim topics registry * ✅ migrated trusted issuer registry * ✅ migrate identity registry storage * ✅ migrated identity registry tests * ✅ migrated implementation authority test * ✅ migrated token agen restrictions * ✅ migrated token information test * ✅ migrated token recover * ✅ migrated token permit * ✅ migrated token transfer * ✅ migrated utilities upgrade * ✅ migrated freeze check * ✅ migrated compliance check in utilities test * ✅ migrated eligibility check * ✅ migrated transfer check in utilities * ✅ migrated compliance test * ✅ migrated gateway tests * 🔥 removed already defined events * 🗑️ imported Initializable error from openzeppelin * ➕ added already defined events and errors * ✅ added base test token * ✅ used idFactory * ♻️ refactored compliance test * ⚰️ remoced useless vm.prank * 🔧 deleted hardhat configurations * 💚 fixed ci * refactor: remove 100% coverage requirement from forge_coverage.sh - Remove strict 100% coverage checks that were causing workflow failures - Script now only generates and displays coverage report without failing - Aligns with previous behavior where coverage was informational only * ✅ resolve getVerifiedDetails * ✅ applied _getEligibility and remove via-ir from foundry.toml * ✅ cover tokena and token permit * ✅ cover compliance * ✅ cover identity registry * ✅ increased trex gateway coverage * ✅ increase coverage for trex factory * ✅ increased AbstractModuleUpgradeable.sol coverage * ⚰️ removed abstract module * 🔧 updted generate coverage * ✅ coverage 100% identity registry * ✅ coverage 100% trex gate way * ✅ coverage trex factory * ✅ coverage 100% AbstractModuleUpgradeable by test module * ✅ coverage IAFactory.sol * ✅ coverage 100% for implementation authority * ✅ coverage 1005 abstract proxy * ✅ coverage 100% claim topic registry * ✅ coverage 100% identity registry storage * ✅ coverage 100% modular compliance proxy * ✅ coverage trusted issuer registry proxy * ✅ coverage 100% identity registry * ✅ coverage 100% token proxy * 🚨 resolve linter in token information * ✅ coverage 100% roles * 🚨 resolve linter * 🔧 added no coverage for test, _testContracts and utils * ✅ coverage 100% for token.sol * ✅ coverage 100% for modular compliance * ✅ coverage 100% trusted issuer registry * 🔧 restore package.json * ✅ coverage 100% for utlity checker * 🚨 fix linter
72 lines
3.0 KiB
Solidity
72 lines
3.0 KiB
Solidity
// SPDX-License-Identifier: UNLICENSED
|
|
pragma solidity 0.8.30;
|
|
|
|
import { OwnableUpgradeable } from "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol";
|
|
import { UtilityChecker } from "contracts/utils/UtilityChecker.sol";
|
|
import { UtilityCheckerProxy } from "contracts/utils/UtilityCheckerProxy.sol";
|
|
import { Test } from "forge-std/Test.sol";
|
|
|
|
contract UpgradeTest is Test {
|
|
|
|
// Standard test addresses
|
|
address public deployer = makeAddr("deployer");
|
|
address public alice = makeAddr("alice");
|
|
|
|
// EIP-1967 implementation slot
|
|
bytes32 constant IMPLEMENTATION_SLOT = 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc;
|
|
|
|
// ============ upgradeToAndCall() Tests ============
|
|
|
|
/// @notice Should revert when calling directly (not owner)
|
|
function test_upgradeToAndCall_RevertWhen_NotOwner() public {
|
|
// Deploy implementation
|
|
UtilityChecker implementation = new UtilityChecker();
|
|
|
|
// Deploy proxy with initialization data
|
|
bytes memory initData = abi.encodeWithSelector(UtilityChecker.initialize.selector);
|
|
UtilityCheckerProxy proxy = new UtilityCheckerProxy(address(implementation), initData);
|
|
UtilityChecker utilityChecker = UtilityChecker(address(proxy));
|
|
|
|
// Transfer ownership to deployer (proxy deployer is address(this))
|
|
utilityChecker.transferOwnership(deployer);
|
|
|
|
// Deploy new implementation
|
|
UtilityChecker newImplementation = new UtilityChecker();
|
|
|
|
// Alice tries to upgrade (not owner)
|
|
vm.prank(alice);
|
|
vm.expectRevert(abi.encodeWithSelector(OwnableUpgradeable.OwnableUnauthorizedAccount.selector, alice));
|
|
utilityChecker.upgradeToAndCall(address(newImplementation), "");
|
|
}
|
|
|
|
/// @notice Should upgrade proxy when calling with owner account
|
|
function test_upgradeToAndCall_Success() public {
|
|
// Deploy implementation
|
|
UtilityChecker implementation = new UtilityChecker();
|
|
|
|
// Deploy proxy with initialization data
|
|
bytes memory initData = abi.encodeWithSelector(UtilityChecker.initialize.selector);
|
|
UtilityCheckerProxy proxy = new UtilityCheckerProxy(address(implementation), initData);
|
|
UtilityChecker utilityChecker = UtilityChecker(address(proxy));
|
|
|
|
// Transfer ownership to deployer (proxy deployer is address(this))
|
|
utilityChecker.transferOwnership(deployer);
|
|
|
|
// Deploy new implementation
|
|
UtilityChecker newImplementation = new UtilityChecker();
|
|
|
|
// Owner upgrades
|
|
vm.prank(deployer);
|
|
utilityChecker.upgradeToAndCall(address(newImplementation), "");
|
|
|
|
// Read the implementation address from the EIP-1967 implementation slot
|
|
bytes32 slotValue = vm.load(address(proxy), IMPLEMENTATION_SLOT);
|
|
|
|
// Convert storage value to address (address is stored in last 20 bytes)
|
|
address actualImplementation = address(uint160(uint256(slotValue)));
|
|
|
|
assertEq(actualImplementation, address(newImplementation));
|
|
}
|
|
|
|
}
|