mirror of
https://github.com/luxfi/kms.git
synced 2026-10-30 16:23:36 +00:00
zeekayandHanzo Dev
12f5cc7ad8
The /sign response was {signature, r, s} — no v, S not low-S normalized, and
signature sometimes empty. A high-S signature is rejected by luxfi/evm (EIP-2)
and a missing v forces a recovery-id guess (wrong guess => wrong address).
mpcd now emits EIP-2 low-S R/S, the recovery id V, and the canonical 65-byte
r‖s‖v (via the wired SigEthereum helper). Carry these through:
- pkg/mpc SignResult: parse V from the wire.
- pkg/keys SignResponse + SignWithBLS/SignWithCorona: propagate V. For
secp256k1 Signature is now the ecrecover-ready r‖s‖v; for ed25519 it stays the
64-byte blob with empty V. Callers build EVM tx v as 27+V (legacy) or
chainID*2+35+V (EIP-155). No empty signature field; r/s/v documented.
Tests: TestSignWithBLS asserts v propagates. End-to-end EVM validity proven in
threshold (SigEthereum: 256 random + high-S recover to signer; live devnet
chainID 31337 tx mined status=success).
Co-authored-by: Hanzo Dev <[email protected]>
52 lines
1.9 KiB
Go
52 lines
1.9 KiB
Go
// Package keys defines validator key types and the key manager.
|
|
package keys
|
|
|
|
import "time"
|
|
|
|
// ValidatorKeySet holds MPC wallet references for a validator's BLS and Corona keys.
|
|
type ValidatorKeySet struct {
|
|
ValidatorID string `json:"validator_id"`
|
|
BLSWalletID string `json:"bls_wallet_id"`
|
|
CoronaWalletID string `json:"corona_wallet_id"`
|
|
BLSPublicKey string `json:"bls_public_key"`
|
|
CoronaPublicKey string `json:"corona_public_key"`
|
|
Threshold int `json:"threshold"`
|
|
Parties int `json:"parties"`
|
|
Status string `json:"status"`
|
|
CreatedAt time.Time `json:"created_at"`
|
|
UpdatedAt time.Time `json:"updated_at"`
|
|
}
|
|
|
|
// GenerateRequest is the input for generating a new validator key set.
|
|
type GenerateRequest struct {
|
|
ValidatorID string `json:"validator_id"`
|
|
Threshold int `json:"threshold"`
|
|
Parties int `json:"parties"`
|
|
}
|
|
|
|
// RotateRequest is the input for resharing a validator's keys.
|
|
type RotateRequest struct {
|
|
NewThreshold int `json:"new_threshold,omitempty"`
|
|
NewParticipants []string `json:"new_participants,omitempty"`
|
|
}
|
|
|
|
// SignRequest is the input for signing with a validator key.
|
|
type SignRequest struct {
|
|
KeyType string `json:"key_type"` // "bls" or "corona"
|
|
Message []byte `json:"message"`
|
|
}
|
|
|
|
// SignResponse contains the signature from a threshold signing operation.
|
|
//
|
|
// For secp256k1/ECDSA ("bls" slot): Signature is the canonical 65-byte
|
|
// r‖s‖v (ecrecover-ready), R/S are the EIP-2 low-S components, and V is the
|
|
// recovery id ("0" or "1"). A caller building an EVM tx uses V directly
|
|
// (legacy: 27+V; EIP-155: chainID*2+35+V). For ed25519/FROST ("corona"
|
|
// slot): Signature is the 64-byte blob and R/S/V are empty.
|
|
type SignResponse struct {
|
|
Signature string `json:"signature"`
|
|
R string `json:"r,omitempty"`
|
|
S string `json:"s,omitempty"`
|
|
V string `json:"v,omitempty"`
|
|
}
|