mirror of
https://github.com/luxfi/kms.git
synced 2026-10-30 16:23:36 +00:00
zeekay
cc986c328d
Squashes all pre-rewrite history into a single root commit. Previous tree: - 14506 commits including upstream Infisical fork history - Multiple merge chains carrying pre-purge content Force-rewrite per disk-space reclamation discipline. GHCR images (1.9.9, 1.9.11) remain immutable; their git lineage is no longer materialized.
1.3 KiB
1.3 KiB
Developer Guidelines
minio-go welcomes your contribution. To make the process as seamless as possible, we ask for the following:
-
Go ahead and fork the project and make your changes. We encourage pull requests to discuss code changes.
- Fork it
- Create your feature branch (git checkout -b my-new-feature)
- Commit your changes (git commit -am 'Add some feature')
- Push to the branch (git push origin my-new-feature)
- Create new Pull Request
-
When you're ready to create a pull request, be sure to:
- Have test cases for the new code. If you have questions about how to do it, please ask in your pull request.
- Run
go fmt - Squash your commits into a single commit.
git rebase -i. It's okay to force update your pull request. - Make sure
go test -race ./...andgo buildcompletes. NOTE: go test runs functional tests and requires you to have a AWS S3 account. Set them as environment variablesACCESS_KEYandSECRET_KEY. To run shorter version of the tests please usego test -short -race ./...
-
Read Effective Go article from Golang project
minio-goproject is strictly conformant with Golang style- if you happen to observe offending code, please feel free to send a pull request