mirror of
https://github.com/luxfi/kms.git
synced 2026-11-03 08:42:32 +00:00
ghcr.io/luxfi/kms-operator has had no new image since v1.12.3. The Build KMS
Operator workflow failed on every tag since (v1.12.4 … v1.12.7) while its
sibling Build KMS succeeded on the same tag, so the tags looked published.
Dockerfile.operator:27 builds with -mod=vendor, and vendor/ had drifted from
go.mod in both directions:
- go.opentelemetry.io/otel/{metric,trace}: in vendor/modules.txt, not in go.mod
- github.com/luxfi/{crypto,geth,ids,keys,zap,address,age,cache,constants,
container,formatting,math,go-bip32,go-bip39}: in go.mod, not marked explicit
`go mod vendor` alone could not fix it — it aborted first on go.sum entries
missing for the k8s packages cmd/kms-operator imports (k8s.io/api/core/v1,
k8s.io/apimachinery/..., k8s.io/client-go/{dynamic,kubernetes,rest}). So:
go mod tidy (adds them, drops now-unused indirects) then go mod vendor.
Verified by stash control:
operator, -mod=vendor: rc=1 -> rc=0 ("inconsistent vendoring" 1 -> 0)
server, -mod=vendor: rc=1 -> rc=1 (unchanged)
The server's vendor build was already broken and stays broken, for an unrelated
reason: blst.h has never been vendored (confirmed absent from HEAD's tree, so it
could not have worked before either) — go mod vendor does not copy cgo headers
that live outside the package dir. It is not a regression and does not affect
CI: the server's Dockerfile builds with GOFLAGS=-mod=mod after `rm -f go.sum &&
go mod download`, i.e. from the module cache, never from vendor/. The operator
is the only -mod=vendor consumer, which is exactly why it was the only failure.
Co-authored-by: Hanzo Dev <[email protected]>
205 lines
9.0 KiB
Go
205 lines
9.0 KiB
Go
// Copyright The OpenTelemetry Authors
|
||
// SPDX-License-Identifier: Apache-2.0
|
||
|
||
/*
|
||
Package metric provides the OpenTelemetry API used to measure metrics about
|
||
source code operation.
|
||
|
||
This API is separate from its implementation so the instrumentation built from
|
||
it is reusable. See [go.opentelemetry.io/otel/sdk/metric] for the official
|
||
OpenTelemetry implementation of this API.
|
||
|
||
All measurements made with this package are made via instruments. These
|
||
instruments are created by a [Meter] which itself is created by a
|
||
[MeterProvider]. Applications need to accept a [MeterProvider] implementation
|
||
as a starting point when instrumenting. This can be done directly, or by using
|
||
the OpenTelemetry global MeterProvider via [GetMeterProvider]. Using an
|
||
appropriately named [Meter] from the accepted [MeterProvider], instrumentation
|
||
can then be built from the [Meter]'s instruments.
|
||
|
||
# Instruments
|
||
|
||
Each instrument is designed to make measurements of a particular type. Broadly,
|
||
all instruments fall into two overlapping logical categories: asynchronous or
|
||
synchronous, and int64 or float64.
|
||
|
||
All synchronous instruments ([Int64Counter], [Int64UpDownCounter],
|
||
[Int64Histogram], [Int64Gauge], [Float64Counter], [Float64UpDownCounter],
|
||
[Float64Histogram], and [Float64Gauge]) are used to measure the operation and
|
||
performance of source code during the source code execution. These instruments
|
||
only make measurements when the source code they instrument is run.
|
||
|
||
All asynchronous instruments ([Int64ObservableCounter],
|
||
[Int64ObservableUpDownCounter], [Int64ObservableGauge],
|
||
[Float64ObservableCounter], [Float64ObservableUpDownCounter], and
|
||
[Float64ObservableGauge]) are used to measure metrics outside of the execution
|
||
of source code. They are said to make "observations" via a callback function
|
||
called once every measurement collection cycle.
|
||
|
||
Each instrument is also grouped by the value type it measures. Either int64 or
|
||
float64. The value being measured will dictate which instrument in these
|
||
categories to use.
|
||
|
||
Outside of these two broad categories, instruments are described by the
|
||
function they are designed to serve. All Counters ([Int64Counter],
|
||
[Float64Counter], [Int64ObservableCounter], and [Float64ObservableCounter]) are
|
||
designed to measure values that never decrease in value, but instead only
|
||
incrementally increase in value. UpDownCounters ([Int64UpDownCounter],
|
||
[Float64UpDownCounter], [Int64ObservableUpDownCounter], and
|
||
[Float64ObservableUpDownCounter]) on the other hand, are designed to measure
|
||
values that can increase and decrease. When more information needs to be
|
||
conveyed about all the synchronous measurements made during a collection cycle,
|
||
a Histogram ([Int64Histogram] and [Float64Histogram]) should be used. Finally,
|
||
when just the most recent measurement needs to be conveyed, a Gauge
|
||
([Int64Gauge], [Float64Gauge], [Int64ObservableGauge], and
|
||
[Float64ObservableGauge]) should be used: the synchronous variants record an
|
||
instantaneous value at a specific point in code, while the observable variants
|
||
sample the value via a callback once per collection cycle.
|
||
|
||
See the [OpenTelemetry documentation] for more information about instruments
|
||
and their intended use.
|
||
|
||
# Instrument Name
|
||
|
||
OpenTelemetry defines an [instrument name syntax] that restricts what
|
||
instrument names are allowed.
|
||
|
||
Instrument names should ...
|
||
|
||
- Not be empty.
|
||
- Have an alphabetic character as their first letter.
|
||
- Have any letter after the first be an alphanumeric character, ‘_’, ‘.’,
|
||
‘-’, or ‘/’.
|
||
- Have a maximum length of 255 letters.
|
||
|
||
To ensure compatibility with observability platforms, all instruments created
|
||
need to conform to this syntax. Not all implementations of the API will validate
|
||
these names, it is the callers responsibility to ensure compliance.
|
||
|
||
# Measurements
|
||
|
||
Measurements are made by recording values and information about the values with
|
||
an instrument. How these measurements are recorded depends on the instrument.
|
||
|
||
Measurements for synchronous instruments ([Int64Counter], [Int64UpDownCounter],
|
||
[Int64Histogram], [Int64Gauge], [Float64Counter], [Float64UpDownCounter],
|
||
[Float64Histogram], and [Float64Gauge]) are recorded using the instrument
|
||
methods directly. All counter instruments have an Add method that is used to
|
||
measure an increment value, and all histogram and synchronous gauge
|
||
instruments have a Record method to measure a data point.
|
||
|
||
Asynchronous instruments ([Int64ObservableCounter],
|
||
[Int64ObservableUpDownCounter], [Int64ObservableGauge],
|
||
[Float64ObservableCounter], [Float64ObservableUpDownCounter], and
|
||
[Float64ObservableGauge]) record measurements within a callback function. The
|
||
callback is registered with the Meter which ensures the callback is called once
|
||
per collection cycle. A callback can be registered two ways: during the
|
||
instrument's creation using an option, or later using the RegisterCallback
|
||
method of the [Meter] that created the instrument.
|
||
|
||
If the following criteria are met, an option ([WithInt64Callback] or
|
||
[WithFloat64Callback]) can be used during the asynchronous instrument's
|
||
creation to register a callback ([Int64Callback] or [Float64Callback],
|
||
respectively):
|
||
|
||
- The measurement process is known when the instrument is created
|
||
- Only that instrument will make a measurement within the callback
|
||
- The callback never needs to be unregistered
|
||
|
||
If the criteria are not met, use the RegisterCallback method of the [Meter] that
|
||
created the instrument to register a [Callback].
|
||
|
||
# Avoiding Expensive Computations
|
||
|
||
All synchronous instruments provide an Enabled method that reports whether the
|
||
instrument will process measurements for the given context. When no SDK is
|
||
registered or the instrument is otherwise disabled, Enabled returns false. This
|
||
can be used to avoid expensive measurement work when a measurement will not be
|
||
recorded:
|
||
|
||
if counter.Enabled(ctx) {
|
||
counter.Add(ctx, 1, metric.WithAttributes(expensiveAttributes()...))
|
||
}
|
||
|
||
This is especially valuable when computing attributes is expensive.
|
||
[WithAttributes] performs non-trivial work on every call to build an
|
||
[attribute.Set] from the provided attributes, and that work is wasted if the
|
||
measurement is not recorded.
|
||
|
||
For performance sensitive code where the same attribute set is used repeatedly,
|
||
prefer [WithAttributeSet]. It accepts a pre-built [attribute.Set], letting you
|
||
pay the construction cost once and reuse it across many measurements:
|
||
|
||
attrs := attribute.NewSet(attribute.String("key", "val"))
|
||
// ... later, on each call:
|
||
counter.Add(ctx, 1, metric.WithAttributeSet(attrs))
|
||
|
||
# API Implementations
|
||
|
||
This package does not conform to the standard Go versioning policy, all of its
|
||
interfaces may have methods added to them without a package major version bump.
|
||
This non-standard API evolution could surprise an uninformed implementation
|
||
author. They could unknowingly build their implementation in a way that would
|
||
result in a runtime panic for their users that update to the new API.
|
||
|
||
The API is designed to help inform an instrumentation author about this
|
||
non-standard API evolution. It requires them to choose a default behavior for
|
||
unimplemented interface methods. There are three behavior choices they can
|
||
make:
|
||
|
||
- Compilation failure
|
||
- Panic
|
||
- Default to another implementation
|
||
|
||
All interfaces in this API embed a corresponding interface from
|
||
[go.opentelemetry.io/otel/metric/embedded]. If an author wants the default
|
||
behavior of their implementations to be a compilation failure, signaling to
|
||
their users they need to update to the latest version of that implementation,
|
||
they need to embed the corresponding interface from
|
||
[go.opentelemetry.io/otel/metric/embedded] in their implementation. For
|
||
example,
|
||
|
||
import "go.opentelemetry.io/otel/metric/embedded"
|
||
|
||
type MeterProvider struct {
|
||
embedded.MeterProvider
|
||
// ...
|
||
}
|
||
|
||
If an author wants the default behavior of their implementations to a panic,
|
||
they need to embed the API interface directly.
|
||
|
||
import "go.opentelemetry.io/otel/metric"
|
||
|
||
type MeterProvider struct {
|
||
metric.MeterProvider
|
||
// ...
|
||
}
|
||
|
||
This is not a recommended behavior as it could lead to publishing packages that
|
||
contain runtime panics when users update other package that use newer versions
|
||
of [go.opentelemetry.io/otel/metric].
|
||
|
||
Finally, an author can embed another implementation in theirs. The embedded
|
||
implementation will be used for methods not defined by the author. For example,
|
||
an author who wants to default to silently dropping the call can use
|
||
[go.opentelemetry.io/otel/metric/noop]:
|
||
|
||
import "go.opentelemetry.io/otel/metric/noop"
|
||
|
||
type MeterProvider struct {
|
||
noop.MeterProvider
|
||
// ...
|
||
}
|
||
|
||
It is strongly recommended that authors only embed
|
||
[go.opentelemetry.io/otel/metric/noop] if they choose this default behavior.
|
||
That implementation is the only one OpenTelemetry authors can guarantee will
|
||
fully implement all the API interfaces when a user updates their API.
|
||
|
||
[instrument name syntax]: https://opentelemetry.io/docs/specs/otel/metrics/api/#instrument-name-syntax
|
||
[OpenTelemetry documentation]: https://opentelemetry.io/docs/concepts/signals/metrics/
|
||
[GetMeterProvider]: https://pkg.go.dev/go.opentelemetry.io/otel#GetMeterProvider
|
||
*/
|
||
package metric // import "go.opentelemetry.io/otel/metric"
|