mirror of
https://github.com/luxfi/metric.git
synced 2026-10-30 16:19:50 +00:00
zeekayandHanzo Dev
31ad0d839d
`Test Before Release` fails at `Install dependencies`:
golangci/golangci-lint err hash_sha256_verify checksum for
'/tmp/.../golangci-lint-2.12.2-linux-amd64.tar.gz'
fd3a137c7e722128143cc8932bcaa00bc73e10ad... vs 8df580d2670fed8fa984aac05070...
make: *** [Makefile:49: install-tools] Error 1
install-tools piped `install.sh` from **master** into sh and let it resolve
**latest**, so it breaks whenever upstream's script and its release assets
disagree. It is reproducible across re-runs — not a corrupted download.
`go install` resolves through the module proxy and is verified against the
checksum database, so a mismatch is a hard, meaningful error rather than a
failed tarball. It is also what luxfi/consensus already does, and its lint job
passes — one way to install a Go tool, not two.
Verified: `go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest`
succeeds and produces the binary; `make install-tools` exits 0.
Co-authored-by: Hanzo Dev <[email protected]>
93 lines
2.6 KiB
Makefile
93 lines
2.6 KiB
Makefile
.PHONY: all build test test-coverage lint fmt bench clean install-tools verify
|
|
|
|
# Variables
|
|
GO := go
|
|
GOFLAGS := -v
|
|
GOTEST := $(GO) test
|
|
GOBUILD := $(GO) build
|
|
GOFMT := gofmt
|
|
GOLINT := golangci-lint
|
|
COVERAGE_OUT := coverage.out
|
|
|
|
# Default target
|
|
all: fmt lint test build
|
|
|
|
# Build the package
|
|
build:
|
|
$(GOBUILD) $(GOFLAGS) ./...
|
|
|
|
# Run tests
|
|
test:
|
|
$(GOTEST) $(GOFLAGS) ./...
|
|
|
|
# Run tests with coverage
|
|
test-coverage:
|
|
$(GOTEST) $(GOFLAGS) -coverprofile=$(COVERAGE_OUT) -covermode=atomic ./...
|
|
$(GO) tool cover -html=$(COVERAGE_OUT) -o coverage.html || true
|
|
@echo "Coverage report generated: coverage.html"
|
|
|
|
# Run benchmarks
|
|
bench:
|
|
$(GOTEST) -bench=. -benchmem ./...
|
|
|
|
# Format code
|
|
fmt:
|
|
$(GOFMT) -s -w .
|
|
$(GO) mod tidy
|
|
|
|
# Lint code
|
|
lint:
|
|
@if ! which $(GOLINT) > /dev/null 2>&1; then \
|
|
echo "golangci-lint not installed, skipping lint"; \
|
|
else \
|
|
$(GOLINT) run ./...; \
|
|
fi
|
|
|
|
# Install development tools
|
|
install-tools:
|
|
@echo "Installing development tools..."
|
|
# `go install`, not curl|sh. The old line fetched install.sh from master and let
|
|
# it resolve "latest", so it broke the moment upstream's script and its release
|
|
# assets disagreed:
|
|
# hash_sha256_verify checksum for golangci-lint-2.12.2-linux-amd64.tar.gz
|
|
# fd3a137c7e722128143cc8932bcaa00bc73e10ad... vs 8df580d2670fed8fa984aac05070...
|
|
# That is reproducible across re-runs, not a corrupted download. `go install`
|
|
# resolves through the module proxy and is verified against the checksum
|
|
# database, so a mismatch becomes a hard, meaningful error instead of a failed
|
|
# tarball — and it is what luxfi/consensus does, whose lint job passes.
|
|
@if ! which $(GOLINT) > /dev/null 2>&1; then \
|
|
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest; \
|
|
fi
|
|
|
|
# Clean build artifacts
|
|
clean:
|
|
rm -f $(COVERAGE_OUT) coverage.html
|
|
$(GO) clean -cache
|
|
|
|
# Verify module
|
|
verify:
|
|
$(GO) mod verify
|
|
$(GO) mod tidy
|
|
@if [ -n "$$(git status --porcelain go.mod go.sum)" ]; then \
|
|
echo "go.mod or go.sum is dirty after go mod tidy"; \
|
|
exit 1; \
|
|
fi
|
|
|
|
# Run all checks (used in CI)
|
|
ci: fmt lint test-coverage bench verify
|
|
|
|
# Help target
|
|
help:
|
|
@echo "Available targets:"
|
|
@echo " all - Format, lint, test, and build"
|
|
@echo " build - Build the package"
|
|
@echo " test - Run tests"
|
|
@echo " test-coverage - Run tests with coverage"
|
|
@echo " bench - Run benchmarks"
|
|
@echo " fmt - Format code"
|
|
@echo " lint - Lint code"
|
|
@echo " install-tools - Install development tools"
|
|
@echo " clean - Clean build artifacts"
|
|
@echo " verify - Verify module dependencies"
|
|
@echo " ci - Run all CI checks"
|
|
@echo " help - Show this help message"
|