Files
zeekay 7cf87b230b node-unified is the node
The module already called itself github.com/luxfi/node while containing no node
in Go: cmd/luxd was twenty-one lines that printed the size of a few types, and
the Go column of the matrix measured a VM plugin. A repo that fetches the thing
it claims to be has not replaced it, so the Go sources move in — 1515 files,
the daemon and everything under it — and the build reaches outside this module
for nothing.

Rust and C++ sit beside it unchanged and are still measured against it by the
differential. That is the point of one repo: the reference implementation and
the two ports are the same checkout, so parity is a thing you can run rather
than a thing you assert.

Verified: builds, and the closure carries no lux-private — checked at build time
rather than believed. The daemon starts twelve chains on a local network
(P X C Q Z A B G K M F, plus D through its plugin) and reports healthy.
2026-09-07 16:15:25 -07:00

656 lines
21 KiB
Go

// Copyright (C) 2019-2025, Lux Industries Inc. All rights reserved.
// See the file LICENSE for licensing terms.
package builder
import (
"context"
"errors"
"testing"
"time"
"github.com/luxfi/log"
"github.com/luxfi/metric"
"github.com/luxfi/mock/gomock"
"github.com/stretchr/testify/require"
"github.com/luxfi/constants"
"github.com/luxfi/crypto/secp256k1"
"github.com/luxfi/database/memdb"
"github.com/luxfi/database/versiondb"
"github.com/luxfi/ids"
"github.com/luxfi/math/set"
"github.com/luxfi/node/vms/xvm/block"
blkexecutor "github.com/luxfi/node/vms/xvm/block/executor"
"github.com/luxfi/node/vms/xvm/block/executor/executormock"
"github.com/luxfi/node/vms/xvm/fxs"
xvmmetrics "github.com/luxfi/node/vms/xvm/metrics"
"github.com/luxfi/node/vms/xvm/state"
"github.com/luxfi/node/vms/xvm/state/statemock"
"github.com/luxfi/node/vms/xvm/txs"
txexecutor "github.com/luxfi/node/vms/xvm/txs/executor"
"github.com/luxfi/node/vms/xvm/txs/mempool"
"github.com/luxfi/node/vms/xvm/txs/txsmock"
"github.com/luxfi/runtime"
"github.com/luxfi/timer/mockable"
lux "github.com/luxfi/utxo"
"github.com/luxfi/utxo/secp256k1fx"
chain "github.com/luxfi/vm/chain"
)
const trackChecksums = false
var (
errTest = errors.New("test error")
chainID = ids.GenerateTestID()
keys = secp256k1.TestKeys()
)
func testRuntime() *runtime.Runtime {
return &runtime.Runtime{ChainID: chainID}
}
func TestBuilderBuildBlock(t *testing.T) {
type test struct {
name string
builderFunc func(*gomock.Controller) Builder
expectedErr error
}
tests := []test{
{
name: "can't get stateless block",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(nil, errTest)
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
ctx := context.Background()
logger := log.NewNoOpLogger()
return New(
&txexecutor.Backend{
Ctx: ctx,
Runtime: testRuntime(),
Log: logger,
},
manager,
&mockable.Clock{},
memPool,
)
},
expectedErr: errTest,
},
{
name: "can't get preferred diff",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
preferredTimestamp := time.Now()
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
manager.EXPECT().GetState(preferredID).Return(nil, false)
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
ctx := context.Background()
logger := log.NewNoOpLogger()
return New(
&txexecutor.Backend{
Ctx: ctx,
Runtime: testRuntime(),
Log: logger,
},
manager,
&mockable.Clock{},
memPool,
)
},
expectedErr: state.ErrMissingParentState,
},
{
name: "tx fails semantic verification",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
preferredTimestamp := time.Now()
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
preferredState := statemock.NewChain(ctrl)
preferredState.EXPECT().GetLastAccepted().Return(preferredID)
preferredState.EXPECT().GetTimestamp().Return(preferredTimestamp)
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
manager.EXPECT().GetState(preferredID).Return(preferredState, true)
unsignedTx := txsmock.NewUnsignedTx(ctrl)
unsignedTx.EXPECT().Visit(gomock.Any()).Return(errTest) // Fail semantic verification
unsignedTx.EXPECT().InputIDs().Return(nil)
tx := &txs.Tx{Unsigned: unsignedTx}
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
require.NoError(t, memPool.Add(tx))
ctx := context.Background()
logger := log.NewNoOpLogger()
return New(
&txexecutor.Backend{
Ctx: ctx,
Runtime: testRuntime(),
Log: logger,
},
manager,
&mockable.Clock{},
memPool,
)
},
expectedErr: ErrNoTransactions, // The only tx was invalid
},
{
name: "tx fails execution",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
preferredTimestamp := time.Now()
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
preferredState := statemock.NewChain(ctrl)
preferredState.EXPECT().GetLastAccepted().Return(preferredID)
preferredState.EXPECT().GetTimestamp().Return(preferredTimestamp)
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
manager.EXPECT().GetState(preferredID).Return(preferredState, true)
unsignedTx := txsmock.NewUnsignedTx(ctrl)
unsignedTx.EXPECT().Visit(gomock.Any()).Return(nil) // Pass semantic verification
unsignedTx.EXPECT().Visit(gomock.Any()).Return(errTest) // Fail execution
unsignedTx.EXPECT().InputIDs().Return(nil)
tx := &txs.Tx{Unsigned: unsignedTx}
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
require.NoError(t, memPool.Add(tx))
ctx := context.Background()
logger := log.NewNoOpLogger()
return New(
&txexecutor.Backend{
Ctx: ctx,
Runtime: testRuntime(),
Log: logger,
},
manager,
&mockable.Clock{},
memPool,
)
},
expectedErr: ErrNoTransactions, // The only tx was invalid
},
{
name: "tx has non-unique inputs",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
preferredTimestamp := time.Now()
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
preferredState := statemock.NewChain(ctrl)
preferredState.EXPECT().GetLastAccepted().Return(preferredID)
preferredState.EXPECT().GetTimestamp().Return(preferredTimestamp)
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
manager.EXPECT().GetState(preferredID).Return(preferredState, true)
manager.EXPECT().VerifyUniqueInputs(preferredID, gomock.Any()).Return(errTest)
unsignedTx := txsmock.NewUnsignedTx(ctrl)
unsignedTx.EXPECT().Visit(gomock.Any()).Return(nil) // Pass semantic verification
unsignedTx.EXPECT().Visit(gomock.Any()).Return(nil) // Pass execution
unsignedTx.EXPECT().InputIDs().Return(nil)
tx := &txs.Tx{Unsigned: unsignedTx}
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
require.NoError(t, memPool.Add(tx))
ctx := context.Background()
logger := log.NewNoOpLogger()
return New(
&txexecutor.Backend{
Ctx: ctx,
Runtime: testRuntime(),
Log: logger,
},
manager,
&mockable.Clock{},
memPool,
)
},
expectedErr: ErrNoTransactions, // The only tx was invalid
},
{
name: "txs consume same input",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
preferredTimestamp := time.Now()
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
// The builder always stamps the execution_root, recomputed from
// the parent's root.
preferredBlock.EXPECT().MerkleRoot().Return(ids.GenerateTestID()).AnyTimes()
preferredState := statemock.NewChain(ctrl)
preferredState.EXPECT().GetLastAccepted().Return(preferredID)
preferredState.EXPECT().GetTimestamp().Return(preferredTimestamp)
// The execution_root projection enumerates the post-block UTXO set
// through the parent; this unit produces none.
preferredState.EXPECT().UTXOs(gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
// tx1 and tx2 both consume [inputID].
// tx1 is added to the block first, so tx2 should be dropped.
inputID := ids.GenerateTestID()
unsignedTx1 := txsmock.NewUnsignedTx(ctrl)
unsignedTx1.EXPECT().Visit(gomock.Any()).Return(nil) // Pass semantic verification
unsignedTx1.EXPECT().Visit(gomock.Any()).DoAndReturn( // Pass execution
func(visitor txs.Visitor) error {
require.IsType(t, &txexecutor.Executor{}, visitor)
executor := visitor.(*txexecutor.Executor)
if executor.Inputs == nil {
executor.Inputs = set.NewSet[ids.ID]()
}
executor.Inputs.Add(inputID)
return nil
},
)
unsignedTx1.EXPECT().SetBytes(gomock.Any()).AnyTimes()
unsignedTx1.EXPECT().InputIDs().Return(nil)
tx1 := &txs.Tx{Unsigned: unsignedTx1}
// Set the bytes of tx1 to something other than nil
// so we can check that the remainingSize is updated
tx1Bytes := []byte{1, 2, 3}
tx1.SetBytes(nil, tx1Bytes)
unsignedTx2 := txsmock.NewUnsignedTx(ctrl)
unsignedTx2.EXPECT().Visit(gomock.Any()).Return(nil) // Pass semantic verification
unsignedTx2.EXPECT().Visit(gomock.Any()).DoAndReturn( // Pass execution
func(visitor txs.Visitor) error {
require.IsType(t, &txexecutor.Executor{}, visitor)
executor := visitor.(*txexecutor.Executor)
if executor.Inputs == nil {
executor.Inputs = set.NewSet[ids.ID]()
}
executor.Inputs.Add(inputID)
return nil
},
)
unsignedTx2.EXPECT().InputIDs().Return(nil)
tx2 := &txs.Tx{Unsigned: unsignedTx2}
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
// GetState is consulted by NewDiff and again by the execution_root
// projection (the diff pages its parent to enumerate the post-block
// UTXO set), so allow repeated calls.
manager.EXPECT().GetState(preferredID).Return(preferredState, true).AnyTimes()
// VerifyUniqueInputs is called once for tx1. tx2 should be dropped due to
// inputs.Overlaps check, so VerifyUniqueInputs should not be called for tx2
// But if it's being called twice, we need to handle it
manager.EXPECT().VerifyUniqueInputs(preferredID, gomock.Any()).Return(nil).AnyTimes()
// Assert created block has one tx, tx1,
// and other fields are set correctly.
manager.EXPECT().NewBlock(gomock.Any()).DoAndReturn(
func(block *block.StandardBlock) chain.Block {
require.Len(t, block.Transactions, 1)
require.Equal(t, tx1, block.Transactions[0])
require.Equal(t, preferredHeight+1, block.Height())
require.Equal(t, preferredID, block.Parent())
return nil
},
)
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
require.NoError(t, memPool.Add(tx1))
require.NoError(t, memPool.Add(tx2))
// To marshal the tx/block
return New(
&txexecutor.Backend{
Ctx: context.Background(),
Runtime: testRuntime(),
Log: log.NewNoOpLogger(),
},
manager,
&mockable.Clock{},
memPool,
)
},
expectedErr: nil,
},
{
name: "preferred timestamp after now",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
preferredTimestamp := time.Now()
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
preferredBlock.EXPECT().MerkleRoot().Return(ids.GenerateTestID()).AnyTimes()
// Clock reads just before the preferred timestamp.
// Created block should have the preferred timestamp since it's later.
clock := &mockable.Clock{}
clock.Set(preferredTimestamp.Add(-2 * time.Second))
preferredState := statemock.NewChain(ctrl)
preferredState.EXPECT().GetLastAccepted().Return(preferredID)
preferredState.EXPECT().GetTimestamp().Return(preferredTimestamp)
preferredState.EXPECT().UTXOs(gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
manager.EXPECT().GetState(preferredID).Return(preferredState, true).AnyTimes()
manager.EXPECT().VerifyUniqueInputs(preferredID, gomock.Any()).Return(nil)
// Assert that the created block has the right timestamp
manager.EXPECT().NewBlock(gomock.Any()).DoAndReturn(
func(block *block.StandardBlock) chain.Block {
require.Equal(t, preferredTimestamp.Unix(), block.Timestamp().Unix())
return nil
},
)
inputID := ids.GenerateTestID()
unsignedTx := txsmock.NewUnsignedTx(ctrl)
unsignedTx.EXPECT().Visit(gomock.Any()).Return(nil) // Pass semantic verification
unsignedTx.EXPECT().Visit(gomock.Any()).DoAndReturn( // Pass execution
func(visitor txs.Visitor) error {
require.IsType(t, &txexecutor.Executor{}, visitor)
executor := visitor.(*txexecutor.Executor)
if executor.Inputs == nil {
executor.Inputs = set.NewSet[ids.ID]()
}
executor.Inputs.Add(inputID)
return nil
},
)
unsignedTx.EXPECT().SetBytes(gomock.Any()).AnyTimes()
unsignedTx.EXPECT().InputIDs().Return(nil)
tx := &txs.Tx{Unsigned: unsignedTx}
// Native-ZAP blocks store each tx's own wire bytes; give the
// mocked tx non-nil bytes so the block builder doesn't try to
// serialize the mock Unsigned (which has no Bytes expectation).
tx.SetBytes(nil, []byte{1, 2, 3})
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
require.NoError(t, memPool.Add(tx))
// To marshal the tx/block
return New(
&txexecutor.Backend{
Ctx: context.Background(),
Runtime: testRuntime(),
Log: log.NewNoOpLogger(),
},
manager,
clock,
memPool,
)
},
expectedErr: nil,
},
{
name: "preferred timestamp before now",
builderFunc: func(ctrl *gomock.Controller) Builder {
preferredID := ids.GenerateTestID()
preferredHeight := uint64(1337)
// preferred block's timestamp is after the time reported by clock
now := time.Now()
preferredTimestamp := now.Add(-2 * time.Second)
preferredBlock := block.NewMockBlock(ctrl)
preferredBlock.EXPECT().Height().Return(preferredHeight)
preferredBlock.EXPECT().Timestamp().Return(preferredTimestamp)
preferredBlock.EXPECT().MerkleRoot().Return(ids.GenerateTestID()).AnyTimes()
// Clock reads after the preferred timestamp.
// Created block should have [now] timestamp since it's later.
clock := &mockable.Clock{}
clock.Set(now)
preferredState := statemock.NewChain(ctrl)
preferredState.EXPECT().GetLastAccepted().Return(preferredID)
preferredState.EXPECT().GetTimestamp().Return(preferredTimestamp)
preferredState.EXPECT().UTXOs(gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
manager := executormock.NewManager(ctrl)
manager.EXPECT().Preferred().Return(preferredID)
manager.EXPECT().GetStatelessBlock(preferredID).Return(preferredBlock, nil)
manager.EXPECT().GetState(preferredID).Return(preferredState, true).AnyTimes()
manager.EXPECT().VerifyUniqueInputs(preferredID, gomock.Any()).Return(nil)
// Assert that the created block has the right timestamp
manager.EXPECT().NewBlock(gomock.Any()).DoAndReturn(
func(block *block.StandardBlock) chain.Block {
require.Equal(t, now.Unix(), block.Timestamp().Unix())
return nil
},
)
inputID := ids.GenerateTestID()
unsignedTx := txsmock.NewUnsignedTx(ctrl)
unsignedTx.EXPECT().Visit(gomock.Any()).Return(nil) // Pass semantic verification
unsignedTx.EXPECT().Visit(gomock.Any()).DoAndReturn( // Pass execution
func(visitor txs.Visitor) error {
require.IsType(t, &txexecutor.Executor{}, visitor)
executor := visitor.(*txexecutor.Executor)
if executor.Inputs == nil {
executor.Inputs = set.NewSet[ids.ID]()
}
executor.Inputs.Add(inputID)
return nil
},
)
unsignedTx.EXPECT().SetBytes(gomock.Any()).AnyTimes()
unsignedTx.EXPECT().InputIDs().Return(nil)
tx := &txs.Tx{Unsigned: unsignedTx}
// Native-ZAP blocks store each tx's own wire bytes; give the
// mocked tx non-nil bytes so the block builder doesn't try to
// serialize the mock Unsigned (which has no Bytes expectation).
tx.SetBytes(nil, []byte{1, 2, 3})
memPool, err := mempool.New("", metric.NewRegistry())
require.NoError(t, err)
require.NoError(t, memPool.Add(tx))
// To marshal the tx/block
return New(
&txexecutor.Backend{
Ctx: context.Background(),
Runtime: testRuntime(),
Log: log.NewNoOpLogger(),
},
manager,
clock,
memPool,
)
},
expectedErr: nil,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ctrl := gomock.NewController(t)
builder := tt.builderFunc(ctrl)
_, err := builder.BuildBlock(context.Background())
require.ErrorIs(t, err, tt.expectedErr)
})
}
}
func TestBlockBuilderAddLocalTx(t *testing.T) {
transactions := createTxs()
require := require.New(t)
registerer := metric.NewRegistry()
memPool, err := mempool.New("mempool", registerer)
require.NoError(err)
// add a tx to the mempool
tx := transactions[0]
txID := tx.ID()
require.NoError(memPool.Add(tx))
_, ok := memPool.Get(txID)
require.True(ok)
parser, err := block.NewParser(
[]fxs.Fx{
&secp256k1fx.Fx{},
},
)
require.NoError(err)
backend := &txexecutor.Backend{
Ctx: context.Background(),
Runtime: testRuntime(),
Log: log.NewNoOpLogger(),
}
baseDB := versiondb.New(memdb.New())
state, err := state.New(baseDB, parser, registerer, trackChecksums)
require.NoError(err)
clk := &mockable.Clock{}
onAccept := func(*txs.Tx) {}
now := time.Now()
parentTimestamp := now.Add(-2 * time.Second)
parentID := ids.GenerateTestID()
txs, err := createParentTxs()
require.NoError(err)
parentBlk, err := block.NewStandardBlock(parentID, 0, parentTimestamp, txs)
require.NoError(err)
state.AddBlock(parentBlk)
state.SetLastAccepted(parentBlk.ID())
xvmMetrics, err := xvmmetrics.New(registerer)
require.NoError(err)
manager := blkexecutor.NewManager(memPool, xvmMetrics, state, backend, clk, onAccept)
manager.SetPreference(parentBlk.ID())
builder := New(backend, manager, clk, memPool)
// show that build block fails if tx is invalid
_, err = builder.BuildBlock(context.Background())
require.ErrorIs(err, ErrNoTransactions)
}
func createTxs() []*txs.Tx {
return []*txs.Tx{{
Unsigned: &txs.BaseTx{BaseTx: lux.BaseTx{
NetworkID: constants.UnitTestID,
BlockchainID: ids.GenerateTestID(),
Outs: []*lux.TransferableOutput{{
Asset: lux.Asset{ID: ids.GenerateTestID()},
Out: &secp256k1fx.TransferOutput{
OutputOwners: secp256k1fx.OutputOwners{
Addrs: []ids.ShortID{ids.GenerateTestShortID()},
},
},
}},
Ins: []*lux.TransferableInput{{
UTXOID: lux.UTXOID{
TxID: ids.ID{'t', 'x', 'I', 'D'},
OutputIndex: 1,
},
Asset: lux.Asset{ID: ids.GenerateTestID()},
In: &secp256k1fx.TransferInput{
Amt: uint64(54321),
Input: secp256k1fx.Input{
SigIndices: []uint32{2},
},
},
}},
Memo: []byte{1, 2, 3, 4, 5, 6, 7, 8},
}},
Creds: []*fxs.FxCredential{
{
Credential: &secp256k1fx.Credential{},
},
},
}}
}
func createParentTxs() ([]*txs.Tx, error) {
countTxs := 1
testTxs := make([]*txs.Tx, 0, countTxs)
for i := 0; i < countTxs; i++ {
// Create the tx
tx := &txs.Tx{Unsigned: &txs.BaseTx{BaseTx: lux.BaseTx{
NetworkID: constants.UnitTestID,
BlockchainID: chainID,
Outs: []*lux.TransferableOutput{{
Asset: lux.Asset{ID: ids.ID{1, 2, 3}},
Out: &secp256k1fx.TransferOutput{
Amt: uint64(12345),
OutputOwners: secp256k1fx.OutputOwners{
Threshold: 1,
Addrs: []ids.ShortID{keys[0].PublicKey().Address()},
},
},
}},
Ins: []*lux.TransferableInput{{
UTXOID: lux.UTXOID{
TxID: ids.ID{'t', 'x', 'p', 'a', 'r', 'e', 'n', 't'},
OutputIndex: 1,
},
Asset: lux.Asset{ID: ids.ID{1, 2, 3}},
In: &secp256k1fx.TransferInput{
Amt: uint64(54321),
Input: secp256k1fx.Input{
SigIndices: []uint32{2},
},
},
}},
Memo: []byte{1, 2, 9, 4, 5, 6, 7, 8},
}}}
if err := tx.SignSECP256K1Fx([][]*secp256k1.PrivateKey{{keys[0]}}); err != nil {
return nil, err
}
testTxs = append(testTxs, tx)
}
return testTxs, nil
}